Commit Graph

10 Commits

Author SHA1 Message Date
Andrey Lushnikov
6fe7d9c19f
devops: support FF_CHECKOUT_PATH to customize browser checkout (#4607)
**Preamble**

1. We're trying to setup a windows-based github self-hosted runner in the
  playwright-internal repo.
1. Commands on Windows are mandated to have total arguments length
  less then 32767 characters.
1. On windows, github self-hosted runner framework puts repository
checkout at `c:\w\playwright-internal\playwright-internal`
1. Our scripts create a checkout at
`c:\w\playwright-internal\playwright-internal\browser_patches\firefox\checkout`
1. One of the scripts in Firefox buildsystem tries to execute a command,
passing lots of absolute paths to various webidl's
1. The command fails due to restriction in (2)

**Problem**

Firefox build fails since checkout is deeply nested and hits max arg
size on windows.

**Solution**

This patch introduces a new variable `FF_CHECKOUT_PATH` that is
respected by all browser-related scripts. This way we'll be able
to checkout firefox to `c:\firefox` and avoid hitting long arguments
limit.
2020-12-04 18:46:20 -08:00
Andrey Lushnikov
21630d6de4
devops: strictly configure build folder for Firefox builds (#1454)
This strictly defines Firefox build folder as `obj-build-playwright`.

Currently, Firefox build folder encodes current Mac OS version including
patch versions, and thus we might end up with multiple different build
folders.
2020-03-20 19:24:38 -07:00
Andrey Lushnikov
3a32b14f32 devops: bundle firefox preferences alongside with build. 2020-02-11 14:42:04 -08:00
Andrey Lushnikov
e750da376e devops: fix firefox's archive.sh 2020-01-17 15:36:22 -08:00
Andrey Lushnikov
9e381a9d50 devops(firefox): move packaging to archive.sh 2019-12-11 16:56:49 -08:00
Andrey Lushnikov
4f3834dd69 devops: revamp archive.sh scripts to accept a target .zip name
This is required so that we can setup a locking directory for cron
jobs later on.
2019-11-20 18:01:51 -08:00
Andrey Lushnikov
af0ba0e713 devops: move check_cdn to tools 2019-11-20 18:01:51 -08:00
Andrey Lushnikov
f9d2f13540 devops: fix firefox archiving script 2019-11-20 18:01:51 -08:00
Andrey Lushnikov
8a077da565 devops: simplified bash traps 2019-11-19 16:33:11 -08:00
Pavel Feldman
9ba375c063 Initial commit 2019-11-19 10:58:15 -08:00