microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-15 14:11:50 +03:00
Code Issues Projects Releases Wiki Activity
11,126 Commits 32 Branches 139 Tags 214 MiB
4c4525c9e0
Commit Graph

525 Commits

Author SHA1 Message Date
Playwright Service
2dee3c4fc7
feat(webkit): roll to r1813 (#21819) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-03-20 23:56:03 +01:00
Max Schmitt
55df07fd60
test: force crash tests on new worker and keep launchOptions (#21818) 
Fixes https://github.com/microsoft/playwright/issues/21810
 2023-03-20 21:43:51 +01:00
Dmitry Gozman
8accabdb59
test: gardening (#21814) 
Notable changes:
- `page-event-crash` is not a page test, moving out of page/.
- One of the expect tests is directly covered by another, merging them.
 2023-03-20 12:52:52 -07:00
Andrey Lushnikov
36a1055524
test: selectively disable selenium tests (#21741) 
https://github.com/microsoft/playwright/issues/21733
 2023-03-17 17:48:45 -07:00
Dmitry Gozman
3a80d119e0
chore: update routeFromHAR options for release (#21764) 2023-03-17 11:49:45 -07:00
Max Schmitt
84a1368fa4
test: enable XMLHttpRequest upload events test on WK+Windows (#21727) 
Fixes https://github.com/microsoft/playwright/issues/21489
 2023-03-17 12:32:55 +01:00
Max Schmitt
b86395a54a
test: unflake 'serviceWorker should intercept document request' (#21722) 
fixes https://github.com/microsoft/playwright/issues/21691
 2023-03-16 19:24:13 +01:00
Pavel Feldman
c45d8749b0
chore: split trace events into phases (#21696) 2023-03-15 22:33:40 -07:00
Dmitry Gozman
40a6eff8f2
feat: support name option in tracing.startChunk() (#21692) 2023-03-15 17:34:56 -07:00
Dmitry Gozman
bde2e90973
fix(selector generator): do not produce has-text="foo"s (#21679) 
There is no locator counterpart for it. Instead, produce a regex.

Also fix locator generator to not produce incorrect locator in this
case.

Fixes #21649.
 2023-03-15 13:43:42 -07:00
Dmitry Gozman
ccd5d7fd10
fix(hit target): workaround webkit elementsFromPoint bug (#21642) 
Fixes #21596.
 2023-03-13 19:33:56 -07:00
Yury Semikhatsky
555cea38e7
test: unskip setContent with js disabled (#21644) 
Fixes #21574
 2023-03-13 19:03:31 -07:00
Pavel Feldman
b85d670491
chore(ui): show output on demand (#21592) 2023-03-11 11:43:33 -08:00
Pavel Feldman
e45a496850
chore(tv): render error in-line (#21586) 2023-03-10 16:22:19 -08:00
Dmitry Gozman
46f9fa005e
fix(tracing): do not double-zip entries in remote mode (#21579) 
Fixes #21435.
 2023-03-10 14:54:32 -08:00
Andrey Lushnikov
8abe9fcf22
tree gardening: disable & assign failing tests (#21575) 
References https://github.com/microsoft/playwright/issues/21574
References https://github.com/microsoft/playwright/issues/21549
 2023-03-10 12:04:25 -08:00
Dmitry Gozman
0794cb1486
fix(fetch): preserve case in header names (#21543) 
Fixes #21492.
 2023-03-10 08:58:12 -08:00
Andrey Lushnikov
7a1c5b2aa3
test: make the tree green (#21551) 
References https://github.com/microsoft/playwright/issues/20522
References https://github.com/microsoft/playwright/issues/20993
References https://github.com/microsoft/playwright/issues/21435
References https://github.com/microsoft/playwright/issues/21512
References https://github.com/microsoft/playwright/issues/21549
References https://github.com/microsoft/playwright/issues/21550
 2023-03-09 16:56:29 -08:00
Yury Semikhatsky
c30d88a63a
test: setContent with disabled javascript (#21399) 
Fixes https://github.com/microsoft/playwright/issues/21379
 2023-03-09 10:45:19 -08:00
Max Schmitt
9191c72a3f
test: XMLHttpRequest upload events (#21501) 
https://github.com/microsoft/playwright/issues/21489
 2023-03-09 16:21:01 +01:00
Pavel Feldman
cffb6ac269
chore: move sever/isomorphic to utils/ to use it in client (#21445) 2023-03-06 18:49:14 -08:00
Yury Semikhatsky
0ebe090b8c
fix(har): do not hang on chunked response in har recorder (#21397) 
Fixes #21182
 2023-03-03 17:27:34 -08:00
Yury Semikhatsky
be259dac7c
fix: expose window.safari in webkit (#21361) 
The actual API of the object is not implemented because those who want
to test it will likely need their own mock and for the browser detection
logic (as described in the bug) just having the property on window
should be sufficient.

Fixes #21037
 2023-03-03 13:38:13 -08:00
Yury Semikhatsky
26fa0eeae8
test: har does not hang on slow chunked response (#21392) 
#21182
 2023-03-03 11:32:21 -08:00
Max Schmitt
778f8e65d2
chore: do not cache between reused context (#20052) 
Fixes https://github.com/microsoft/playwright/issues/19926
 2023-03-03 12:37:44 +01:00
Pavel Feldman
09ff7eaaf2
chore: throw on context.close() if it was closed externally (#21347) 2023-03-02 13:46:54 -08:00
Yury Semikhatsky
3b800344b0
fix(oopif): get response body from adopting frame (#21324) 
Fixes https://github.com/microsoft/playwright/issues/20809
 2023-03-01 17:18:58 -08:00
Dmitry Gozman
b4bfbb20f6
chore: update selenium 4 tests to not use /wd/hub (#21240) 2023-02-27 19:43:49 -08:00
Dmitry Gozman
cabeb42c8c
chore: update selenium tests from 4.0.0-rc1 to 4.4.0 (#21235) 2023-02-27 16:58:08 -08:00
Pavel Feldman
22d82b6e1b
chore: flatten metadata in trace events (#21214) 2023-02-27 15:29:20 -08:00
NoamGaash
e17e0e40f8
feat(routeFromHAR): add arguments (#21223) 2023-02-27 15:27:38 -08:00
Tarnay Kálmán
e28801f6ef
fix(snapshot): render srcdoc iframe snapshots (#21003) 2023-02-27 13:34:39 -08:00
Pavel Feldman
ed41fd0643
chore: use listview to render stack trace (#21197) 2023-02-24 15:31:10 -08:00
Playwright Service
5affd333a7
feat(webkit): roll to r1801 (#21183) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-02-24 15:34:37 +01:00
Dmitry Gozman
f29d58e87f
chore: remove test that sends SIGTERM to the browser (#21171) 
Fixes #21168.
 2023-02-23 14:49:18 -08:00
Dmitry Gozman
2718123d30
fix(snapshots): define dummy custom elements (#21131) 
For all custom elements defined in the page, we preserve their names and
define them in the rendered snapshot.
This makes things like `:defined` css pseudo work.

Fixes #21030.
 2023-02-22 21:53:27 -08:00
Pavel Feldman
55c95a4463
chore: do not send stacks as a part of the call metainfo (#21089) 2023-02-22 21:08:47 -08:00
Playwright Service
1dfc4c769d
feat(firefox): roll to r1379 (#21080) 
Fixes #20259

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
 2023-02-22 09:52:35 -08:00
Max Schmitt
4efa9e5ea0
test: unskip WK tests (#21033) 
Fixes https://github.com/microsoft/playwright/issues/20370
Fixes https://github.com/microsoft/playwright/issues/12353
 2023-02-21 23:49:14 +01:00
Max Schmitt
147e388ec3
test: serviceWorker should intercept document request (#21031) 
Not sure whats actually going on here, turns out this breaks the trace
viewer on firefox. -> all the iframes won't work.

Can't repro on stock firefox, so seems like something fishy on our end.

References #20259
 2023-02-21 10:36:19 -08:00
Pavel Feldman
a22eaf8672
chore: disable navigating off trace snapshot on hrefs (#21005) 2023-02-17 18:13:45 -08:00
Pavel Feldman
d7a0b3bb4e
chore: implement pick locator in trace viewer (#20965) 
Fixes https://github.com/microsoft/playwright/issues/7853
 2023-02-17 11:19:53 -08:00
Pavel Feldman
c9cc8478b3
chore: minor trace viewer UI tweaks (#20937) 2023-02-16 07:59:21 -08:00
Andrey Lushnikov
fdcd7b549d
chore: mark comparator option back as experimental (#20816) 
This reverts commit 303c5998f8.

Reason for revert: I tried enabling `ssim-cie94` by default on
ionic-framework test suite, and it proves to be overly strict for their
usecase.
 2023-02-13 11:11:44 -08:00
Pavel Feldman
6920a82f50
test: add fixme's (#20826) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-02-10 19:54:00 +01:00
Andrey Lushnikov
bcb2d67c5d
chore: remove experimental dockerfile.remote (#20790) 
We didn't find a compelling-enough use case to release this.
 2023-02-09 12:18:02 -08:00
Dmitry Gozman
6e5964cccd
fix(connect): respect launch options when turning into connect (#20757) 2023-02-08 13:06:05 -08:00
Dmitry Gozman
edfff8cd8c
test: run more tests in 'service' mode (#20734) 2023-02-07 18:25:33 -08:00
Dmitry Gozman
bc74383480
test: remove service2 mode and experimental-grid (#20730) 2023-02-07 14:19:37 -08:00
Andrey Lushnikov
b67cef2c4d
feat: introduce Dockerfile.remote image (#20691) 
When this image is launched, it exposes a single endpoint
that can be used to connect to and to launch browsers.
 2023-02-07 10:50:44 -08:00
Andrey Lushnikov
303c5998f8
feat: release "comparator" option from experiment (#20720) 
The option defines a comparator to be used to compare images.
Possible values are `"pixelmatch"` and `"ssim-cie94"`.

Note: This reverts commit 8167f8bf54.
 2023-02-07 08:51:48 -08:00
Andrey Lushnikov
0a752f3fd6
chore(docker): remove experimental docker integration (#20676) 
This removes everything related to docker integration experiments that
we conducted over the last 6 months.

I'll send a follow-up with an alternative suggestion that was demo'ed on
a team meeting in the end of December.
 2023-02-06 10:50:45 -08:00
Max Schmitt
bcecce6b6e
test: skip resource-timing WK tests on Windows (#20622) 2023-02-06 10:41:09 +01:00
Max Schmitt
c9230c699c
test: add test for cookies of wss requests (#20586) 
https://github.com/microsoft/playwright/issues/20370
 2023-02-02 16:42:58 -08:00
Max Schmitt
b803128a81
test: CloseEvent.wasClean=false when WS server terminates (#20594) 
https://github.com/microsoft/playwright/issues/12353
 2023-02-02 19:04:26 +01:00
Max Schmitt
59d1147247
test: unskip 'should be able to download a inline PDF file via navigation' for WebKit (#20551) 
Fixes https://github.com/microsoft/playwright/issues/20044
 2023-02-01 13:56:38 +01:00
Dmitry Gozman
b39079b51e
feat(trace viewer): popout snapshot in a new tab (#20475) 2023-01-30 19:07:52 -08:00
Max Schmitt
92eb8e5090
chore: make connectOverCDP work with localhost (#20396) 
This wraps happy eyeballs in two places, the place where we make the
JSON request to Chromium and the actual CDP WebSocket request.

It required changes inside our happy eyeballs implementation since the
[websocket library does not
set](https://github.com/websockets/ws/blob/master/lib/websocket.js#L714)
the `clientRequestOptions.hostname` field, it just sets the `host` field
where we then fall back to when its not set.

This test would pass before Node.js 18 and fail after Node.js 18 without
my changes.

Fixes https://github.com/microsoft/playwright/issues/20364
 2023-01-30 17:44:26 +01:00
chimurai
f72d400952
chore: fix typos (#20473) 2023-01-30 09:53:28 +01:00
Dmitry Gozman
821949d580
test: update stale test expectations (#20423) 2023-01-27 21:52:34 -08:00
Yury Semikhatsky
532ca3f7b3
fix: throw on tap when hasTouch=false (#20457) 
Fixes #20430
 2023-01-27 15:51:57 -08:00
Etienne
252b489a7f
feat(trace-viewer): allow host and port to be specified (#20258) 2023-01-27 14:20:25 -08:00
Yury Semikhatsky
faadbba63c
test: webm video player (#20421) 
Fixes #18423
 2023-01-27 09:48:47 -08:00
Max Schmitt
eb87c9276e
test: do not create ipv6 server inside Docker (#20440) 2023-01-27 18:38:27 +01:00
Dmitry Gozman
ad6d24bf94
test: update headful.spec to use modern fixtures (#20428) 2023-01-26 19:01:54 -08:00
Yury Semikhatsky
99f0560122
test: enable video test on macos monterey+ (#20420) 2023-01-26 17:09:22 -08:00
Yury Semikhatsky
249d969d4b
test: navigator.clipboard is present (#20402) 
Fixes #18901
 2023-01-26 10:15:19 -08:00
Yury Semikhatsky
840052a309
test: enable download not attachment on webkit (#20403) 
Fixes #19939
 2023-01-26 10:13:44 -08:00
Max Schmitt
c1487f886b
test: skip 'should be able to visit ipv6' if docker (#20362) 2023-01-25 17:49:49 +01:00
Playwright Service
d7366cfc7c
feat(chromium-tip-of-tree): roll to r1080 (#20323) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-01-25 10:23:12 +01:00
Dmitry Gozman
a9422beecb
Revert "chore: respect headless option when reusing browser (#19980)" (#20336) 
This reverts commit e674ea217f.
 2023-01-24 11:07:53 -08:00
Yury Semikhatsky
2c52d5be59
test: navigation to resource with unknown mime type (#20313) 
https://github.com/microsoft/playwright/issues/20089
 2023-01-24 07:29:46 -08:00
Dmitry Gozman
0ec1d5d452
test: disable "should work with video+trace" on headed (#20299) 2023-01-23 15:26:05 -08:00
Dmitry Gozman
eafa6fda13
fix(expect): poll/toPass should not wait over specified timeout (#20266) 
Drive-by: unflake some timeout-dependent tests.
 2023-01-20 15:47:24 -08:00
Dmitry Gozman
3f79786cf8
test: fix socks proxy test for wk mac (#20227) 
Drive-by: unskip firefox test.
 2023-01-19 09:10:42 -08:00
Andrey Lushnikov
b7e30a8bf6
test: failing test for WebKit (#20088) 
The test fails if the `content-disposition` header does not have
an "attachment" value.

#20089
 2023-01-17 20:15:35 -08:00
Pavel Feldman
d1c161ce99
chore: merge the util exports (#20110) 2023-01-13 13:50:38 -08:00
Pavel Feldman
e065d608b6
chore: introduce defineConfig for easier JS typing (#20061) 
Fixes https://github.com/microsoft/playwright/issues/19694
 2023-01-12 13:12:02 -08:00
Dmitry Gozman
862125e122
test: record trace+video at the same time (#20082) 
Fixes #12266.
 2023-01-12 10:44:20 -08:00
Max Schmitt
a7495c3326
fix: use no internal selectors for frame locators (#19964) 
Fixes https://github.com/microsoft/playwright/issues/19406
 2023-01-11 21:53:19 +01:00
Dmitry Gozman
4f837690e2
fix(connect): do not log ws query params (#20047) 2023-01-11 12:27:27 -08:00
Dmitry Gozman
e674ea217f
chore: respect headless option when reusing browser (#19980) 
References #19746.
 2023-01-10 10:49:53 -08:00
Dmitry Gozman
830c3c9f0f
fix(reuse): workaround long sw unregister (#19930) 
Bogus `importScripts()` sometimes makes `unregister()` hang for long
time. We detect this case and not await it.

Fixes #19789.
 2023-01-06 17:02:40 -08:00
Max Schmitt
c339e1615b
fix(fetch): handle invalid redirect URL (#19890) 
Fixes https://github.com/microsoft/playwright/issues/19879.

This part is then similar to how node-fetch is doing it:
55a4870ae5/src/index.js (L152-L159)

node-fetch also throws as of today with this URL. Before in Python it
was stalling, because the error was written to stdout and on Windows the
stdout wasn't working. On Node.js it ended up in an unhandled exception.
 2023-01-06 10:22:17 -08:00
Dmitry Gozman
cd698a2258
feat(trace viewer): render selectors as locators (#19907) 
Drive-by: fix more places with SerializedValue rendering.

Fixes #19085.
 2023-01-05 16:59:50 -08:00
Yury Semikhatsky
10ccfa9517
feat(fetch): happy eyeballs (#19902) 
Fixes #18790
 2023-01-05 14:39:49 -08:00
Dmitry Gozman
e07d1722ec
test: rebase permission test for Chromium >= 110 (#19899) 
Fixes #19180.
 2023-01-05 13:01:37 -08:00
Playwright Service
abe901d598
feat(chromium-tip-of-tree): roll to r1074 (#19853) 
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-01-05 19:04:20 +01:00
Dmitry Gozman
711a1aadbf
chore: update tracing tests helper (#19848) 
To be reused in future tests.

Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
 2023-01-03 17:30:36 -08:00
Dmitry Gozman
f58015281a
test: attempt to unflake inspector tests (#19845) 
On headed bots, we might get `locator('body')` from initial mouse
position.
 2023-01-03 16:26:21 -08:00
Andrey Lushnikov
caec93ef42
test: enable ssim-cie94 image comparison algorithm for our tests (#19313) 2022-12-29 23:48:28 -08:00
Yury Semikhatsky
b8f96a9411
fix(generator): FilterOptions in java (#19741) 
Fixes #19448
 2022-12-28 09:13:06 -08:00
Dmitry Gozman
0b223b9036
fix(hit target): account for iframes with padding (#19732) 
Padding on iframes moves the `documentElement` inside the iframe, so we
should account for it when converting coordinates between frames.

Fixes #19613.
 2022-12-27 16:59:34 -08:00
Dmitry Gozman
3334d89ad7
fix(socks): support ipv6 (#19727) 
Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
 2022-12-27 14:45:35 -08:00
Dmitry Gozman
3ad65e7ce8
fix(launchServer): disable socks by default (#19723) 
Socks does not support ipV6 yet.

References #19661.
 2022-12-27 10:43:36 -08:00
Dmitry Gozman
1bb019ac81
chore: migrate most of rerunnable tasks to element callback (#19713) 2022-12-27 09:22:22 -08:00
Dmitry Gozman
0087bfac23
fix(role): update allowsNameFromContent to closer align with blink/gecko (#19692) 2022-12-27 09:06:46 -08:00
Pavel Feldman
e61a8c6592
fix(generator): penalize for the selector length (#19672) 2022-12-22 20:54:04 -08:00
Pavel Feldman
8b80e22a03
fix(har): recalculate receive time after response ended (#19646) 
Fixes https://github.com/microsoft/playwright/issues/19327
 2022-12-22 17:30:32 -08:00
Dmitry Gozman
83418aa8ab
fix(socks): cleanup event listeners upon disconnect (#19671) 
References #19661.
 2022-12-22 17:15:51 -08:00
Dmitry Gozman
412c11db20
fix(reuse): make sure all dispose and close sequences are executed (#19572) 
- When disposing recursively, only the root dispatcher received
`_dispose()` call, while some dispatchers need `_onDispose()` to clean
things up.
- When reusing the context, pages should be notified with `_onClose()`
so that all client-side waiting promises could reject.

Fixes #19216.
 2022-12-19 15:54:53 -08:00
Dmitry Gozman
1263bc3edd
feat(console api): first/last/nth (#19485) 2022-12-15 11:17:59 -08:00
Ross Wollman
a1bb1dd94f
test: fix flaky cookie roundtrip test (#19459) 
<img width="1676" alt="Screenshot 2022-12-14 at 2 05 29 PM"
src="https://user-images.githubusercontent.com/11915034/207726274-167d9ee7-c01b-4379-aff1-37dad979d23b.png">

Flakiness dashboard reveals on Window's variants of Chromium, the
decimal for actual vs. expected was slightly off (e.g. 1705568002.677066
vs. 1705568002.674173).

This test fix assumes it's acceptable to suppress the roundtrip floating
point difference (which appears to be constrained to Windows).

Signed-off-by: Ross Wollman <rwoll@users.noreply.github.com>
 2022-12-14 15:24:54 -08:00
Dmitry Gozman
ab9602bebf
chore: remove unused PW_TEST_OUT_OF_PROCESS_DRIVER (#19434) 2022-12-13 16:04:44 -08:00
Dmitry Gozman
b97900b925
tests: use run-server for mode=service tests, restrict to page tests only (#19435) 2022-12-13 16:03:53 -08:00
Andrey Lushnikov
87141f6856
chore: add metadata for 'chromium page tests' project (#19431) 2022-12-13 13:12:07 -08:00
Dmitry Gozman
539893402e
feat(socks): support pattern similar to proxy bypass rules (#19387) 
- `<loopback>` for local interfaces;
- `123.123.123.123` for IPv4;
- `[1:2:3:4:5:6:7:8]` for IPv6;
- `*.example.com` and `.example.com` for subdomains;
- `example.com` for domains;
- `anything:3000` for port matching.
 2022-12-12 12:27:34 -08:00
Dmitry Gozman
3c17a2603a
feat(console api): support locator.filter (#19389) 2022-12-09 15:25:12 -08:00
Dmitry Gozman
256e9fd443
feat(connect): allow exposing local network to the remote browser (experimental) (#19372) 
`connectOptions: { _exposeNetwork: '*' | 'localhost' }`

References #19287.
 2022-12-09 11:16:29 -08:00
Dmitry Gozman
622c1a8da6
tests: run browserType.connect tests against launchServer and run-server (#19340) 2022-12-07 14:36:32 -08:00
Dmitry Gozman
fd22d8bde1
feat(tether): support hostname pattern in socks proxy (#19302) 
For now, only '*' and 'localhost' are supported.

References #19287.
 2022-12-07 08:46:35 -08:00
Playwright Service
84a0aaaaff
feat(chromium-tip-of-tree): roll to r1065 (#19239) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2022-12-05 11:22:03 -08:00
Dmitry Gozman
0be4fa768a
fix(codegen): do not generate Promise.all (#19182) 
Drive-by: fix `download`, `dialog` and `popup` signals to use different
variable names in all languages.
 2022-12-02 17:33:01 -08:00
Dmitry Gozman
c547416e24
test: unflake "should highlight locators with custom testId" (#19236) 2022-12-02 17:32:29 -08:00
Max Schmitt
3565d97a36
feat(recorder): make it work with [contenteditable] (#19066) 
https://github.com/microsoft/playwright/issues/19029
 2022-12-01 12:41:03 -08:00
Pavel Feldman
f0e8d8f074
feat(api): introduce route.fetch and route.fulfill(json) (#19184) 2022-11-30 17:26:19 -08:00
Playwright Service
f952e1147b
feat(chromium-tip-of-tree): roll to r1063 (#19070) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2022-11-30 11:11:54 -08:00
Dmitry Gozman
307a0b6ea7
fix(dotnet): codegen/docs use Name instead of NameString (#19156) 2022-11-29 20:56:18 -08:00
Dmitry Gozman
43a6bf4d45
fix(inspector): support custom test id attribute (#18996) 
Fixes #18959.
 2022-11-29 11:43:47 -08:00
Dmitry Gozman
4f72a895e9
fix(inspector): render expect.not correctly (#19125) 
Also fixes the same in expect logs.

References #19083.
 2022-11-28 20:50:16 -08:00
Pavel Feldman
85467d1b7d
chore: generate get by title (#19119) 2022-11-28 19:55:34 -08:00
Yury Semikhatsky
d3f41eaa47
fix(fetch): cookie with domain=localhost (#18998) 
Fixes https://github.com/microsoft/playwright/issues/18362
 2022-11-23 09:22:49 -08:00
Dmitry Gozman
190ed9465f
fix(chromium): detach from shared workers (#18976) 
This prevents shared workers from stalling upon restart.

We receive `Inspector.targetCrashed` and
`Inspector.targetReloadedAfterCrash` events that assume
`Runtime.runIfWaitingForDebugger` from any attached client. It is easier
and more stable to just detach from shared workers, because we do not
inspect them.

For service workers, we should actually issue
`Runtime.runIfWaitingForDebugger` in such cases, because we attach to
them.

Fixes #18932.
 2022-11-22 15:20:42 -08:00
Pavel Feldman
a0ea9b5fba
chore: simplify slowmo implementation (#18990) 2022-11-22 11:06:45 -08:00
Pavel Feldman
228f78c89d
chore: render browser window in trace (#18870) 2022-11-22 08:41:52 -08:00
Dmitry Gozman
941090f0c4
fix(click): account for transformed iframes (#18926) 
- Properly convert coordinates for iframes with non-zero borders.
- IFrames that have `transform` anywhere in the ancestors skip
`hitPoint`-based check because we cannot reliably translate the viewport
point into frame document's coordinates.

Fixes #18245.
 2022-11-18 16:51:39 -08:00
Dmitry Gozman
f5b4e499fb
fix(locators): frameLocator().nth serialized correctly (#18819) 
Fixes #18798.
 2022-11-15 10:50:46 -08:00
Pavel Feldman
98513c3737
test: fix video channel tests (#18807) 2022-11-14 22:20:00 -08:00
Pavel Feldman
59418aa6f3
chore: ignore untrusted clicks when recording (#18796) 
Fixes https://github.com/microsoft/playwright/issues/18776
 2022-11-14 15:16:25 -08:00
Dmitry Gozman
a7b2b04588
fix(getByRole): name and exact (#18719) 
Following the `getByText()` and other methods:

- By default, matching is substring and case-insensitive. Before, it was
only case-insensitive, but not substring.
- With new option `exact: true`, matching is full string and
case-sensitive.
- Matching always normalizes whitespace.
- Codegen generates `exact: false` by default.
- `internal:role` treats `[name="foo"i]` as non-exact match.

Various fixes:
- Updated `getByRole` docs to match the reality.
- Locator generator edge cases.
 2022-11-11 15:58:36 -08:00
Andrey Lushnikov
f3a99fdd69
chore: address API review comments for the snapshotPathTemplate (#18716) 
This patch:
- updates documentation to lead users from `TestConfig.snapshotDir` and
  `testInfo.snapshotSuffix` to `TestConfig.snapshotPathTemplate` as a
  better and more flexible alternative.
- drops `{snapshotSuffix}` from documentation
- stops using `snapshotSuffix = ''` in our own tests and switches us
  to the `snapshotPathTemplate`.
- adds `{testName}` token.
 2022-11-10 17:23:57 -08:00
Max Schmitt
56d7d47d43
fix(codegen): make select work with size attribute (#18712) 
Fixes https://github.com/microsoft/playwright/issues/18711
 2022-11-10 15:06:53 -08:00
Dmitry Gozman
7c80b77c57
feat(clear): remove clear() methods from all classes except Locator (#18703) 
The preferred way is to use the locator, so we should not encourage the
use of `ElementHandle` or `Page` in the new APIs.
 2022-11-10 12:29:14 -08:00
Pavel Feldman
ca2e7ef199
chore: report paused signal to the debug controller clients (#18701) 2022-11-10 12:15:29 -08:00
Pavel Feldman
c25e67a0e7
chore: conditionally dispatch network events (#18687) 2022-11-09 21:10:57 -08:00
Dmitry Gozman
cafa558845
fix(codegen): update priorites in selector generator (#18688) 
- prefer `role=checkbox` over `input[type=checkbox]`
- prefer `#id` over `input[type=checkbox]` and `role=checkbox`
- prefer `text=foo` over `internal:has-text=foo`
- ignore `none` and `presentation` roles
- remove non-strict support
 2022-11-09 17:22:13 -08:00
Dmitry Gozman
a7f1c8cb65
fix(codegen): fix csharp options syntax (#18662) 2022-11-08 21:48:01 -08:00
Dmitry Gozman
ef1b68a998
feat(locators): support frame locators in asLocator (#18653) 
Drive-by: change `true` to `True` in python.

References #18524.
 2022-11-08 17:08:08 -08:00
Pavel Feldman
0355d8618f
chore: use provided value for the generated test id (#18631) 2022-11-08 12:04:43 -08:00
Dmitry Gozman
05b623e6b0
feat(locators): asLocator supports internal:has= (#18625) 
The following snippet:
```js
rowLocator
    .filter({ hasText: 'John' })
    .filter({ has: page.getByRole('button', { name: 'Say hello' }) })

```

is shown in the logs:

```log
pw:api waiting for getByRole('listitem').filter({ hasText: 'John' }).filter({ has: getByRole('button', { name: 'Say hello' }) })
```
 2022-11-08 08:47:02 -08:00
Dmitry Gozman
28d3f48a65
test: gardening (#18623) 
- Separate worker for some Android tests.
- Use png comparator for some screenshots tests instead of buffer
equality.
- Skip drag&drop tests on Android.
- Various timeout fixes.
 2022-11-07 15:35:21 -08:00
Dmitry Gozman
6a65a43e9a
chore: use consistent asLocator() in all logs (#18586) 
References #18524.
 2022-11-04 15:19:16 -07:00
Pavel Feldman
3bc9e07daf
chore: parse locators strictly (#18553) 2022-11-03 15:17:08 -07:00
Pavel Feldman
17c8554255
chore(recorder): explore using codemirror (#18529) 2022-11-03 09:55:23 -07:00
Dmitry Gozman
20f2e0049c
test: unflake codegen tests waiting for highlight (#18518) 
Clear existing highlights to avoid resolving with the old highlight
value.
 2022-11-02 17:00:33 -07:00
Pavel Feldman
67c9624924
chore: send structured codegen info to the debug controller (#18491) 2022-11-01 18:02:14 -07:00
Pavel Feldman
2183d9e9a2
chore: use codemirror for editor (#18482) 2022-11-01 15:04:30 -07:00
Pavel Feldman
2c3fa1b1ff
chore: add explore locator parser (#18429) 2022-10-31 12:55:35 -07:00
Dmitry Gozman
e725293586
test: print stdout/stderr in signals.spec (#18456) 2022-10-31 12:45:18 -07:00
Pavel Feldman
3e112193a6
test: fix debug controller tests on firefox (#18361) 2022-10-27 09:19:55 -07:00
Yury Semikhatsky
12fdd3336e
test: navigator.storage.getDirectory() across browsers (#18305) 2022-10-26 15:41:36 -07:00
Jean-François Greffier
0fe1998c72
feat(api): add clear() (#18296) 
Add `clear()` method as a convenience shortcut for `fill('')`.
Implemented for AndroidDevice, ElementHandle, Frame, Locator and Page.

Fixes https://github.com/microsoft/playwright/issues/14041
 2022-10-25 12:56:11 -07:00
Pavel Feldman
37250cde17
chore: switch to the new debug controller harness (#18308) 2022-10-25 09:55:20 -07:00
Pavel Feldman
d819f97f40
test: clean up connect options set for debug controller (#18317) 2022-10-25 09:03:04 -07:00
Pavel Feldman
d8ec7cba47
chore: don't generate new lines in codegen (#18309) 2022-10-25 09:02:06 -07:00
Pavel Feldman
d3948d1308
chore: enable debug controller testing (#18270) 2022-10-24 16:19:58 -07:00
Pavel Feldman
3f850d27e9
fix(highlight): fix the testing harness to be real (#18294) 2022-10-24 15:01:48 -07:00
Max Schmitt
be67189a54
fix(fetch): throw on unexpected end of file brotli requests (#18223) 
https://github.com/microsoft/playwright/issues/18190
 2022-10-24 12:51:45 -07:00
Dmitry Gozman
48c44f2c78
fix(selectors): hasText and getByText exact match should consider full text (#18260) 
Fixes #18259.
 2022-10-21 16:29:45 -07:00
Dmitry Gozman
5ed552838e
test: skip "should not include buffers in the trace" on non-default mode (#18215) 2022-10-20 10:19:42 -07:00
Pavel Feldman
84daeafb3a
chore: use internal locator for role (#18187) 2022-10-19 19:38:47 -07:00
Yury Semikhatsky
69092b153a
chore(codegen): do not generate waitForURL (#18167) 
Fixes https://github.com/microsoft/playwright/issues/17179
 2022-10-19 11:26:19 -07:00
Pavel Feldman
1b541c9932
chore: render typed locators in the trace viewer (#18166) 2022-10-18 19:23:40 -07:00
Pavel Feldman
739b64a09a
chore: render typed locators in the recorder (#18162) 2022-10-18 16:39:58 -07:00
Pavel Feldman
304a4ee8ec
chore: migrate to the internal:text selector (#18135) 2022-10-18 13:09:54 -07:00
Dmitry Gozman
6d363888f2
fix(tracing): do not serialize buffers into the trace file (#18132) 
Fixes #18126.
 2022-10-17 16:17:25 -07:00
Yury Semikhatsky
7219a68b12
fix: exception in exposeFunction when oopif detaches (#18078) 
The test is racy but it was reliably failing several times in 100
iterations.

Fixes https://github.com/microsoft/playwright/issues/18067
 2022-10-14 08:37:42 -07:00
Max Schmitt
a60073d664
fix(generator): .NET getByRole w/ name (#18060) 2022-10-13 08:23:43 -07:00
Barbara Lócsi
347544db09
fix: override cookie even if new is expired (#17998) 2022-10-11 23:06:16 -07:00
Pavel Feldman
ec1f8d17f0
fix(generator): generate nice locators for arbitrary selectors (#18010) 2022-10-11 17:50:41 -07:00
Pavel Feldman
35a5e805b3
fix(codegen): use constants when generating C# and Java roles (#17961) 
Fixes #[17960](https://github.com/microsoft/playwright/issues/17960)
 2022-10-10 12:25:56 -07:00
Yury Semikhatsky
1b5c2f9aba
fix(trace): show waitForLoadState when event has already fired (#17826) 
Fixes https://github.com/microsoft/playwright/issues/17807
 2022-10-07 11:27:56 -07:00
Dmitry Gozman
2f918852da
test: rebaseline requestStorageAccess test for firefox-beta (#17879) 2022-10-06 10:11:59 -07:00
Pavel Feldman
c168f5494f
chore: generate getByLabel for inputs (#17845) 2022-10-05 12:02:15 -07:00
Dmitry Gozman
2bcd9ce9ae
chore: internal selectors (#17827) 
- Rename internal selectors `has`, `control` and `attr` to
`internal:has`, `internal:control` and `internal:attr`.
- Fix `getByLabel()` to respect strictness, by introducing
`internal:label` selector.
- Move tests essential for ports to `selectors-by.spec`.
 2022-10-05 08:45:10 -07:00
Dmitry Gozman
a9c02b9753
fix(locators): properly escape various locator methods (#17798) 
References #17604.
 2022-10-04 13:21:38 -07:00
Pavel Feldman
8810b55504
feat(api): shorted getByLabel, getByPlaceholder (#17816) 2022-10-04 10:29:26 -07:00
Yury Semikhatsky
a9ef95f31e
test: update expectations of requestStorageAccess (#17780) 
Fixes https://github.com/microsoft/playwright/issues/17285
 2022-10-03 20:46:47 -07:00
Yury Semikhatsky
cb6b824119
test: update SameSite cookie fetch test (#17797) 2022-10-03 20:46:25 -07:00
Pavel Feldman
1311767f87
chore: generate api calls (#17794) 2022-10-03 17:14:02 -07:00
Pavel Feldman
42a4d8a829
chore(codegen): prioritize role selectors (#17750) 2022-10-03 08:44:24 -07:00
Yury Semikhatsky
ff6d240e83
test: auto accept requestStorageAccess dialog (#17752) 
Reference https://github.com/microsoft/playwright/issues/17285
 2022-09-30 18:56:05 -07:00
Yury Semikhatsky
9b35a8071f
fix(fetch): support SameSite attribute (#17748) 
Fixes https://github.com/microsoft/playwright/issues/17398
 2022-09-30 15:01:59 -07:00
Pavel Feldman
5754fb9c6d
chore: do not emit comments from codegen (#17747) 2022-09-30 12:36:54 -07:00
Pavel Feldman
e09945c637
chore: handle unexpected ws response (#17714) 2022-09-29 14:04:19 -07:00
Pavel Feldman
d9a28bd244
feat(api): introduce get/getByText/getByRole (#17577) 2022-09-27 16:13:56 -07:00
Dmitry Gozman
3409a37f77
feat: allow opening multiple html reporters and trace viewers (#17636) 
This makes `HttpServer` accept `preferredPort` option that will first
try to listen on that port, and if that port is already in use, listen
on some available port instead.

Fixes #17201.
 2022-09-27 12:45:42 -07:00
Yury Semikhatsky
72a24973f3
fix: ignore timing data when request served from memory cache (#17595) 
`Response.timing` contains stale data when the request is served from
memory cache, in that we should ignore it and return -1 where we don't
know the value.

Fixes https://github.com/microsoft/playwright-java/issues/1080
 2022-09-26 17:12:47 -07:00
Yusuke Iwaki
f5d7089819
fix: accept post data params for request.get and request.head (#17566) 2022-09-26 09:28:07 -07:00
Andrey Lushnikov
6b4afbb8df
chore: support http protocol with browserType.connect() (#17483) 2022-09-22 11:59:58 -07:00
Pavel Feldman
df143031e7
chore: move protocol and trace types into the top-level packages (#17486) 2022-09-20 18:41:51 -07:00
Pavel Feldman
3abbe0d850
chore: migrate codegen to controller events (#17450) 2022-09-20 14:32:21 -07:00
Pavel Feldman
e92bdce383
chore: remove connect options after testing (#17380) 2022-09-15 20:37:21 -07:00
Dmitry Gozman
43304e980d
feat: show browser.close() stack in "Browser has been closed" error (#17376) 
Often times we see "Browser has been closed" error, but it's not
entirely clear why. Showing the close stack might help.

```js
page.goto: Connection closed
    ==== Closed by ====
    at /Users/dgozman/code/playwright/tests/library/browsertype-connect.spec.ts:477:32
```
 2022-09-15 17:04:41 -07:00
Andrey Lushnikov
a12112c24d
devops(docker): add docker integration smoke tests (#17267) 2022-09-14 15:05:18 -07:00
Max Schmitt
59c32bf2c6
Revert "chore(generator): use new .NET test attributes (#17172)" (#17344) 
This reverts commit 15add13a6a.
 2022-09-14 22:44:38 +02:00
Yury Semikhatsky
24ee456d43
chore: make maxRedirects available in java, improve docs. tests (#17227) 2022-09-09 13:25:36 -07:00
Vincenzo Gasparo
17b203affb
feat: added follow and redirect arguments to fetch (#17033) 2022-09-09 12:14:42 -07:00
Dmitry Gozman
cbc8d1a19f
test: tracing works with waitForResponse (#17176) 2022-09-08 11:31:02 -07:00
Max Schmitt
15add13a6a
chore(generator): use new .NET test attributes (#17172) 2022-09-08 01:44:58 +02:00