microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 13:45:36 +03:00
Code Issues Projects Releases Wiki Activity
11,845 Commits 32 Branches 139 Tags 213 MiB
778828cc43
Commit Graph

3763 Commits

Author SHA1 Message Date
Playwright Service
7dcba6f5f0
feat(firefox): roll to r1425 (#27427) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-10-04 11:00:50 -07:00
Yury Semikhatsky
ac48a47d33
feat: toHaveAttribute without value (#27418) 
This time not doing it in other languages due to unjustified generator
complexity.

Fixes #27341
 2023-10-04 09:27:28 -07:00
Pavel Feldman
5a7b405bdb
chore: add console icon titles (#27416) 
Fixes https://github.com/microsoft/playwright/issues/27411
 2023-10-03 15:52:37 -07:00
Pavel Feldman
c226d97b87
chore: bump vite to 4.4.10 (#27417) 2023-10-03 14:59:13 -07:00
Dmitry Gozman
65ce4cd213
feat: expose composedTest() instead of test._extendTest() (#27414) 2023-10-03 13:26:30 -07:00
Pavel Feldman
47b0255b89
chore: instrument nested workers (#27400) 
Ref: https://github.com/microsoft/playwright/issues/27376
 2023-10-03 13:08:15 -07:00
Pavel Feldman
ae08d03d75
fix(role): compute <output> accessible name from labels (#27415) 
Fixes: https://github.com/microsoft/playwright/issues/27403
 2023-10-03 13:01:13 -07:00
mash-graz
2c56af3a3b
fix: use most recent stable debian release browser binaries in case of debian testing and unstable (#27397) 
Fixes: #27398
 2023-10-03 12:35:21 -07:00
Yury Semikhatsky
567386c23f
fix(webkit): add libnghttp2 to the deps on older distros (#27399) 
`bin/WPENetworkProcess` depends on `libsoup-3.0.so.0` which we bundle
with the browser on Ubuntu 20 and Debian 11, but soup3 depends on
`libnghttp2.so` which is expected to be installed on the host.

Fixes https://github.com/microsoft/playwright/issues/27255
 2023-10-02 18:06:28 -07:00
Dmitry Gozman
2aca7fdcc2
fix(chromium): scroll into view elements inside iframes before waiting (#27394) 
This forces iframes to be visible, so that `rAF`s always run.

Fixes #27196.
 2023-10-02 17:21:06 -07:00
Playwright Service
1bed74bc8b
feat(webkit): roll to r1914 (#27279) 2023-10-02 11:36:23 -07:00
Andrey Lushnikov
471d12ac7b
chore: keep linux browser deps script up-to-date (#27309) 
References https://github.com/microsoft/playwright/issues/27255
 2023-10-02 11:34:49 -07:00
Yury Semikhatsky
bb8a102164
chore(types): add blob reporter to the known reporter types (#27371) 
Closes https://github.com/microsoft/playwright/issues/27357
 2023-09-29 15:15:18 -07:00
Dmitry Gozman
5deea65bf2
fix(test runner): move removing artifacts dir from stop() to onExit (#27364) 
Fixes #27326.
 2023-09-29 14:57:32 -07:00
Dmitry Gozman
55c4bb97af
chore: extract CDPSession on the server side, remove duplicate code (#27349) 
This makes sure that protocol calls after target close are rejected
correctly.
 2023-09-29 12:50:02 -07:00
Dmitry Gozman
2a8d6a8207
docs: encourage using expect() instead of getters like textContent() (#27362) 2023-09-29 10:52:20 -07:00
Dmitry Gozman
81694b7401
test: unflake some tests (#27354) 2023-09-29 10:45:31 -07:00
Pavel Feldman
d136b0aeb6
feat(step): allow boxing steps (#27334) 2023-09-29 09:44:00 -07:00
Yury Semikhatsky
0f14446518
chore: log formatting for single state (#27351) 
Fixes formatting for "waiting for element to be  and stable".
 2023-09-29 09:14:26 -07:00
Dmitry Gozman
08e71fec5d
test: add installation tests for supposed plugin story (#27331) 2023-09-28 17:18:22 -07:00
Pavel Feldman
4fd2b4adef
chore: bump the babel (#27348) 2023-09-28 17:12:57 -07:00
Pavel Feldman
2892467839
chore: delete temporary artifacts after test (#27332) 2023-09-27 16:29:21 -07:00
Dmitry Gozman
c8143748e6
chore: remove Page._didDisconnect (#27317) 
Instead of having `didClose` based on page creation/destruction and
`didDisconnect` based on session lifetime, we make session lifetime
being managed by the `CRPage`/`FFPage`/`WKPage` instead.
 2023-09-27 14:09:56 -07:00
Sander
2032b64ee6
feat(ct): allow baseUrl and host config (#27295) 
closes: https://github.com/microsoft/playwright/issues/27283
 2023-09-26 16:32:51 -07:00
Pavel Feldman
ffd20f43f8
chore: dispose stale handles to prevent oom, 1000 of a kind max (#27315) 
https://github.com/microsoft/playwright/issues/6319
 2023-09-26 15:54:33 -07:00
Yury Semikhatsky
d198784f1a
fix(blob): use reporters from the merge config (#27301) 
Fixes https://github.com/microsoft/playwright/issues/27281
 2023-09-26 11:41:17 -07:00
Pavel Feldman
07e794eb83
chore: follow up to runnable change (#27300) 2023-09-26 08:57:14 -07:00
Dmitry Gozman
c0dc2328aa
chore: use JobDispatcher helper in one more place (#27299) 2023-09-25 20:08:22 -07:00
Pavel Feldman
aed86c98a8
chore(ct): allow using component as a property (#27272) 2023-09-25 17:00:52 -07:00
Pavel Feldman
4e62468aee
chore: use closures to set current runnable (#27293) 2023-09-25 15:22:25 -07:00
Dmitry Gozman
9a5356f93b
fix(snapshot): invalidate style sheet upon CSSGroupingRule changes (#27296) 
Previously, snapshotter listened to CSSStyleSheet modifications, but one
can also modify the list of rules inside CSSGroupingRule.

Fixes #27288.
 2023-09-25 14:34:17 -07:00
wodyjowski
522782cce6
fix: desiredCapabilities removed (#27275) 
DesiredCapabilities field was removed in selenium grid > 4.8.2
Without this field removed it's impossible to connect to grid.
Grid throws exception on POST /session
[stackoverflow issue](https://stackoverflow.com/a/76695833)

Fixes #27276
 2023-09-25 13:52:16 -07:00
Dmitry Gozman
32a50e2d90
chore(test runner): use helper method in JobDispatcher (#27278) 2023-09-25 11:05:49 -07:00
Dmitry Gozman
7bd8032439
docs: mention Locator.first in toBeVisible (#27292) 
Fixes #26842.
 2023-09-25 10:59:39 -07:00
Dmitry Gozman
0f72ef0584
fix(streams): avoid leaking event listeners (#27291) 
Fixes #26998.
 2023-09-25 10:59:14 -07:00
Dmitry Gozman
66eb3043f5
feat(json report): expose startTime and duration (#27290) 
Fixes #27183.
 2023-09-25 10:58:55 -07:00
Pavel Feldman
d6ec1ae399
chore: document chaining expect.extend (#27262) 
Fixes https://github.com/microsoft/playwright/issues/15951
 2023-09-22 13:56:59 -07:00
Pavel Feldman
a6a0257c88
feat(expect): allow chaining expects (#27248) 2023-09-22 12:12:17 -07:00
Dmitry Gozman
49fd9500fe
fix: handle worker process start failure (#27249) 
Worker process start failure is reported as a test error and skips other
tests from the group.
If happened during stop (e.g. from a Ctrl+C) before worker has fully
initialized, this error is ignored.

Drive-by: send SIGINT in tests to the whole tree, to better emulate
Ctrl+C behavior.
 2023-09-22 10:57:35 -07:00
Pavel Feldman
c7d9ae1c8b
ui(trace): make drawer appear under action list (#27260) 2023-09-22 10:43:44 -07:00
Dmitry Gozman
ccaec034d8
chore(test runner): extract JobDispatcher (#26776) 2023-09-21 17:13:00 -07:00
Pavel Feldman
51a774f8a3
chore: include log in matcherResult (#27164) 2023-09-21 16:23:46 -07:00
Pavel Feldman
287d720b8e
chore: remove dedicated console channel (#27234) 2023-09-21 16:16:43 -07:00
Playwright Service
4bf5af6d86
feat(webkit): roll to r1912 (#27242) 2023-09-21 15:23:14 -07:00
Dmitry Gozman
1857a3fb56
fix(evaluate): make sure to try/catch toJSON access (#27238) 2023-09-21 13:31:28 -07:00
Playwright Service
1d6ec0923c
feat(webkit): roll to r1911 (#27226) 2023-09-21 09:33:12 -07:00
Dmitry Gozman
b9509b3ec6
Revert "feat(evaluate): serialize map and set (#26730)" (#27219) 
This reverts commit ee203b782c.

References #24040.
Fixes #27181.
 2023-09-20 18:31:09 -07:00
Dmitry Gozman
2af7d672ef
fix(tracing): bump trace version to V5, migrate V4 traces to consoleMessage.args (#27162) 
This moves the fix in #27095 from `modernize` to `appendEvent`. The
reason is that `trace V4` is used both for older traces that do not have
`consoleMessage.args` and the new ones with `args`. Since we do not call
`modernize` for traces of the same version, the original fix does not
help in this case.

Fixes #27144.
 2023-09-19 16:21:09 -07:00
Yury Semikhatsky
88038f1b00
fix: do not throw from fetch when response has invalid cookie (#27192) 
Cookie value is limited by 4096 characters in the browsers. If
setCookies failed we try setting each cookie individually just in case
only some of them are bad.

Fixes https://github.com/microsoft/playwright/issues/27165
 2023-09-19 16:18:16 -07:00
Dmitry Gozman
bb4268d165
fix(locators): do not escape regular expressions with u or v flag (#27188) 
Fixes #27163.
 2023-09-19 13:16:50 -07:00
Playwright Service
ddcc52bfcc
feat(chromium-tip-of-tree): roll to r1152 (#27182) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-19 18:29:17 +02:00
Playwright Service
f064fb6840
feat(firefox-beta): roll to r1425 (#27128) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
 2023-09-19 00:31:58 -07:00
Andrey Lushnikov
94e272ba0f
fix(firefox): properly handle navigations (#27132) 
In firefox, the `frameRequestedNavigation` is coming from renderer and
thus can happen **after** the `Network.requestWillBeSent`, which is
dispatched from the browser process.

Fixes https://github.com/microsoft/playwright/issues/24132
 2023-09-18 17:01:19 -07:00
Pavel Feldman
6b36a50969
chore: simplify expect zone wrapper (#27145) 2023-09-18 15:02:50 -07:00
Pavel Feldman
955be6bd61
chore: populate matcherResult for toHaveScreenshot (#27136) 
Ref #26929
 2023-09-18 09:12:23 -07:00
Playwright Service
3b4e21dd99
feat(webkit): roll to r1910 (#27134) 2023-09-18 08:57:34 -07:00
Pavel Feldman
9fe037fb63
chore: populate matcherResult in web assertions (#27133) 
Ref https://github.com/microsoft/playwright/issues/26929
 2023-09-16 14:24:10 -07:00
Dmitry Gozman
3bcf9687e6
fix(test runner): make sure auto worker fixtures run before auto test fixtures (#27131) 
Fixes #27114.
 2023-09-15 14:51:31 -07:00
Pavel Feldman
527d260cbf
chore: hide tracing calls from traces (#27096) 2023-09-15 12:55:49 -07:00
Andrey Lushnikov
a34030be80
browser(firefox): support relative paths for firefox videos (#27099) 
Firefox protocol requires absolute paths for video recording.

Fixes https://github.com/microsoft/playwright/issues/27086
 2023-09-15 10:26:20 -07:00
Pavel Feldman
c914d62c69
chore: nicer network grid header (#27102) 2023-09-15 09:16:29 -07:00
Max Schmitt
0d44405762
fix: custom expect matchers on Locator/Page/APIResponse instance (#27117) 
Fixes https://github.com/microsoft/playwright/issues/27113
 2023-09-15 18:05:44 +02:00
Yury Semikhatsky
ebf6a08290
fix: list tests only once (#27103) 
Fixes #27087
 2023-09-14 20:00:30 -07:00
Pavel Feldman
699e790f69
chore: fit body in the network panel (#27100) 2023-09-14 17:15:24 -07:00
Dmitry Gozman
a26f568b36
fix(tracing): support old traces with consoleMessage.args (#27095) 
Fixes #27072.
 2023-09-14 17:07:29 -07:00
Dmitry Gozman
b3edf8e562
fix(har): handle invalid Expires/Max-Age (#27098) 
Fixes #27073.
 2023-09-14 17:06:56 -07:00
Pavel Feldman
c6510ac000
chore: align select options docs (#27097) 
Fixes: https://github.com/microsoft/playwright/issues/27094
 2023-09-14 16:41:36 -07:00
David Paquette
3170963f42
fix: render JUnit attachment paths relative to outputFile (#27024) 2023-09-14 12:58:09 -07:00
Dmitry Gozman
603861c48d
fix: revert toMatchSnapshot deprecation (#27089) 
- This reverts commit
8348f66107
landed in #26718.
- Update docs to point towards `toHaveScreenshot`.
 2023-09-14 12:52:41 -07:00
Max Schmitt
4431a8366d
fix: collect stdio from forked processes (#27074) 
A summary about the attempts we tried in
https://github.com/microsoft/playwright/pull/26931 for
https://github.com/microsoft/playwright/issues/26859 and
https://github.com/microsoft/playwright/issues/24591.

1. attempt: collect all the stdio from the worker host.
- this made it hard to capture the live console logs for the live trace
2. attempt: collect all the stdio from the worker host, but keep
proxying `process.{stdout,stderr}.write`.
- this solved the live console logs problem, since we could still listen
on them
- we found out about a race that the stdout/stderr streams can still
buffer data while the test already had finished
- we created a best effort flush implementation but didn't like the
complexity it introduced to the project
3. attempt: keep things like they are but also listen to stdio from the
worker host
- this solves the race of console.log in the test (things stay like they
are)
    - this keeps live trace working (things stay like they are)
- a known pitfall is that it could result in logs which don't end up in
the reporter onStdOut/onStdErr, but it is already a significant
improvement over how it was before.
      - before: they were not getting displayed
- after: they are getting displayed and there is a low likelihood that
they don't end up in the reporter API if the write happens slightly
before a test finished.

Closes #26931
Fixes #26859
Fixes #24591
 2023-09-14 18:34:26 +02:00
Playwright Service
57e5183809
feat(chromium): roll to r1081 (#27080) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-14 16:00:21 +02:00
Playwright Service
3b16bbd04a
feat(chromium-tip-of-tree): roll to r1151 (#27081) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-14 16:00:06 +02:00
Dmitry Gozman
f9298cfff6
fix(tracing): unclash trace names between test and hooks (#27063) 
Fixes #27048.
 2023-09-13 19:56:40 -07:00
Max Schmitt
ce43ea7d99
chore: roll @zip.js/zip.js to 2.7.29 (#27047) 2023-09-13 18:39:10 +02:00
Max Schmitt
c06ed8c0bc
chore: add --disable-search-engine-choice-screen flag to Chromium (#27038) 
As per `https://github.com/puppeteer/puppeteer/pull/10880`
 2023-09-13 18:06:50 +02:00
Playwright Service
bf35390c8d
feat(webkit): roll to r1908 (#27049) 2023-09-13 17:40:18 +02:00
Playwright Service
00b74a4aae
feat(chromium): roll to r1080 (#27041) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-13 14:12:45 +02:00
Playwright Service
3203b6c31f
feat(chromium-tip-of-tree): roll to r1150 (#27031) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-13 08:59:12 +02:00
Yury Semikhatsky
fac4560a82
chore(types): host, port in html reporter config (#27027) 2023-09-12 13:38:10 -07:00
Pavel Feldman
02c72e545b
feat(onEnd): allow overriding the exit code (#27010) 
Fixes: https://github.com/microsoft/playwright/issues/26858
 2023-09-12 13:37:30 -07:00
Max Schmitt
d0945192a4
feat: make it possible to filter by column in HTML report (#27020) 2023-09-12 22:13:15 +02:00
Yury Semikhatsky
700b310150
fix(fetch): restore from empty storage state (#27025) 
Fixes #26833
 2023-09-12 13:11:18 -07:00
Pavel Feldman
97b3625049
chore: polish ui mode for better mac appearance (#27008) 2023-09-11 19:01:00 -07:00
Pavel Feldman
91478ea316
chore: document new onEnd params (#27006) 2023-09-11 18:17:49 -07:00
Andrey Lushnikov
41cd9e183a
chore: cut 1.38.0 branch (#27004) 2023-09-11 18:16:16 -07:00
Pavel Feldman
7c838653d6
chore: fix the split view, reset window on timeline click (#27007) 2023-09-11 18:16:02 -07:00
Dmitry Gozman
d9eabda09d
fix(locators): escape quotes in regular expressions (#27002) 
Fixes #26974.
 2023-09-11 15:49:04 -07:00
Max Schmitt
6bbc09c96c
chore: show channel name in trace viewer metadata (#26987) 
Fixes https://github.com/microsoft/playwright/issues/26986
 2023-09-11 23:06:56 +02:00
Max Schmitt
c327d5af5b
chore: roll TypeScript to 5.2.2 (#26977) 2023-09-11 18:18:19 +02:00
Max Schmitt
54f36bee93
chore: make html report image attachment clickable (#26978) 2023-09-11 08:44:00 +02:00
Pavel Feldman
80b9e02837
fix(trace): do not attach screenshots twice (#26971) 2023-09-08 18:00:12 -07:00
Yury Semikhatsky
2feae015aa
chore: remove details from markdown reports (#26961) 
- remove error details from the reports
- collapse flaky tests by default
- limit comment to 65365 character

GitHub API has comment length limit 65536 chars:
```
Unhandled error: HttpError: Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"}
```
 2023-09-08 17:49:34 -07:00
Pavel Feldman
c3f5486dab
chore: group attachments across actions in trace (#26969) 2023-09-08 16:47:45 -07:00
Dmitry Gozman
186f86905c
chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
Pavel Feldman
8ba8c9385d
chore: keep split positions when zooming (#26942) 2023-09-08 12:30:08 -07:00
Playwright Service
f5e6f2e6d2
feat(webkit): roll to r1907 (#26953) 2023-09-08 09:03:51 -07:00
Pavel Feldman
99047cba03
chore: add install browsers dialog (#26940) 2023-09-07 18:34:59 -07:00
Pavel Feldman
167c35ca66
chore: store scroll positions in trace viewer (#26938) 2023-09-07 17:14:39 -07:00
Playwright Service
aa3f4f208e
feat(chromium): roll to r1079 (#26934) 2023-09-07 18:48:50 +02:00
Playwright Service
e814657a38
feat(chromium-tip-of-tree): roll to r1149 (#26933) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-07 17:51:47 +02:00
Playwright Service
bf1f2d2c81
feat(firefox): roll to r1424 (#26915) 
Fixes https://github.com/microsoft/playwright/issues/26463

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-06 23:02:52 -07:00
Playwright Service
bcf59ed721
feat(webkit): roll to r1905 (#26909) 2023-09-07 07:41:46 +02:00
Pavel Feldman
7fa16d2230
chore: pick frame selectors in recorder (#26923) 2023-09-06 18:35:32 -07:00
Pavel Feldman
61a1924328
chore: align recorder drawer with trace viewer (#26922) 2023-09-06 17:13:25 -07:00
Pavel Feldman
d65da74b8f
fix(trace): allow typing in selector w/ frames (#26919) 2023-09-06 16:14:40 -07:00
Pavel Feldman
ea4974ce36
chore: allow resetting the time filter (#26920) 2023-09-06 16:14:26 -07:00
Dmitry Gozman
cb8656f24f
chore: remove @types/node from deps (#26918) 
This effectively reverts #14230. We will install `@types/node` in `npm
init playwright` instead.
 2023-09-06 16:09:35 -07:00
Max Schmitt
f71df9fb50
chore: introduce sdkLanguage based userDataDir misuse error (#26894) 
Fixes https://github.com/microsoft/playwright-python/issues/2059

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
 2023-09-06 22:58:44 +02:00
Max Schmitt
d79dad09e8
fix(ui-mode/tv): do not open new tab on macOS (#26877) 
Fixes https://github.com/microsoft/playwright/issues/9434
 2023-09-06 22:57:29 +02:00
Dmitry Gozman
abea8f4d1c
docs: update deprecation messages for type() methods (#26912) 2023-09-06 12:41:12 -07:00
Dmitry Gozman
361038c950
feat: rename PageError to WebError (#26913) 2023-09-06 12:40:53 -07:00
Andrey Lushnikov
9105a20ac4
fix: remove window.stop() from page.setContent() implementation (#26886) 
The call was added back in 2019 to stop network loading. See commit:
56a48559c2

However, there's no evidence that this call is needed any more:
- all the tests pass without it
- `window.stop()` behavior is poorly defined, so relying on it is
unfortunate.

The `window.stop()` call, however, causes trouble while rolling firefox:
under certain condititions, the call prevents document from firing the
`load` event in the `document.open().write(..).close()` sequence that
comes immediately after the call. While this does look like a bug in
Firefox itself, we failed to reproduce it in isolation.

For the reference, the following tests fail with the Firefox 116 (using
`PWTEST_TRACE=1` triggers the race condition somewhere):

```bash
PWTEST_TRACE=1 npm run ftest cli-codegen
```
 2023-09-06 11:02:38 -07:00
Pavel Feldman
b4012df160
fix(trace): make locator picker work for iframes (#26883) 
Fixes https://github.com/microsoft/playwright/issues/26878
 2023-09-06 09:44:47 -07:00
Playwright Service
500821d1bd
feat(chromium-tip-of-tree): roll to r1148 (#26904) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-06 18:15:32 +02:00
Pavel Feldman
e0db46ae14
chore: highlight ansi in browser messages as well (#26881) 2023-09-05 17:29:07 -07:00
Dmitry Gozman
740472ce8f
fix(trace viewer): retain currentSrc of all images (#26841) 
When `<source>` or `srcset=` are involved, the actual image src is
determinted at runtime based on factors like `devicePixelRatio` and
media queries that depend on width/height.

Since these factors may differ in the Trace Viewer itself, we should
preserve the `currentSrc`, use it as an actual `src`, and disable
various `<source>` and `srcset=`.
 2023-09-05 12:48:07 -07:00
Playwright Service
94c1b749b2
feat(webkit): roll to r1904 (#26855) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-09-04 16:08:23 +02:00
Pavel Feldman
8c494e2519
chore: add log/error tabs and counters (#26843) 2023-09-01 20:12:05 -07:00
Pavel Feldman
1c5f53f216
chore: show innermost error in ui mode (#26840) 2023-09-01 13:48:15 -07:00
Pavel Feldman
a339bead09
chore: implement faster ansi2html format for console (#26826) 2023-09-01 09:09:47 -07:00
Andrey Lushnikov
54e4e5caca
fix: implement atomic append for compilation cache (#26830) 
Note: this reverts commit ffd6cf60eb.

Fixes #26769
 2023-08-31 17:55:13 -07:00
Pavel Feldman
4948920437
fix(ui): do not log from beforeAll twice (#26799) 
Fixes https://github.com/microsoft/playwright/issues/26790
 2023-08-31 17:34:15 -07:00
Dmitry Gozman
f3c02a5b4f
fix(trace viewer): make red dot to the center of the target element (#26825) 
Also make sure red dot is visible in the popout tab.

Fixes #24532.
 2023-08-31 16:52:54 -07:00
Dmitry Gozman
fa286de0b3
fix(test runner): extract FailureTracker helper (#26757) 
This way we can reuse it for:
- tracking `maxFailures` across phases;
- tracking failures for runner;
- tracking failures for `runJob` helper class later on.

Fixes #26344.
 2023-08-31 15:32:29 -07:00
Dmitry Gozman
6d85ba1494
fix: remove connectInsteadOfLaunching (#26828) 2023-08-31 15:29:04 -07:00
Max Schmitt
b387249e45
chore: enhance download/install logic of branded browsers (#26806) 
- Remove the check for 32 vs. 64 bit, since we only support 64 Windows
since a while
- Introduce `$ErrorActionPreference = 'Stop'` which is a best practice
otherwise the code would have continued running even a statement/line
was failing. E.g. download failed, it would still try to install
- `$ms.DownloadFile` checks for the status code internally, so we are
safe regarding this, it will throw otherwise.

This won't fix https://github.com/microsoft/playwright/issues/26591 but
makes the code more safe and might be related.
 2023-08-31 22:48:07 +02:00
Dmitry Gozman
741c649d56
fix(trace viewer): make sure target inside shadow dom is highlighted (#26823) 
References #24532.
 2023-08-31 12:46:49 -07:00
Max Schmitt
cb67427d56
chore: fix html-reporter/trace-viewer TSC errors (#26813) 2023-08-31 18:08:38 +02:00
Playwright Service
6629b31a97
feat(webkit): roll to r1902 (#26812) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-31 17:31:13 +02:00
Playwright Service
51792c1417
feat(chromium-tip-of-tree): roll to r1147 (#26815) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-31 17:16:31 +02:00
Playwright Service
60e70c187d
feat(chromium): roll to r1078 (#26811) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-31 16:03:16 +02:00
Pavel Feldman
123ee9ddc1
chore: trace timeline ux (#26797) 2023-08-30 15:48:51 -07:00
Pavel Feldman
fd31f5bc50
chore: fix har date types (#26783) 2023-08-30 12:40:46 -07:00
Pavel Feldman
a34deffa43
chore: highlight actions and har entries in timeline (#26781) 2023-08-29 22:23:08 -07:00
Pavel Feldman
c209d7e708
chore: more network panel polish (#26780) 2023-08-29 22:20:28 -07:00
Pavel Feldman
34c6197f9e
chore: include start/endTime and duration in onEnd report callback (#26760) 
Fixes https://github.com/microsoft/playwright/issues/23637
 2023-08-29 10:56:21 -07:00
Max Schmitt
a9bc1a1707
fix(trace-viewer): SVG images were not loading (#26755) 
Fixes https://github.com/microsoft/playwright/issues/26745

Drive-by: make Codemirror read-only.
 2023-08-29 18:05:01 +02:00
Playwright Service
f3ece09063
feat(chromium-tip-of-tree): roll to r1146 (#26770) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-29 16:42:49 +02:00
Pavel Feldman
99b8ca2be2
chore: flush har when recording tracing (#26746) 2023-08-28 17:44:48 -07:00
Dmitry Gozman
4bbd16d316
chore(test runner): decouple runJob from the Dispacther (#26756) 
In preparation to extracting a class for it.
 2023-08-28 15:41:14 -07:00
Pavel Feldman
38f1e62642
chore: use custom expect message in trace step (#26752) 2023-08-28 14:48:24 -07:00
Sander
ee203b782c
feat(evaluate): serialize map and set (#26730) 
closes: https://github.com/microsoft/playwright/issues/24040
 2023-08-28 14:32:41 -07:00
Yury Semikhatsky
501ed32856
fix(fetch): update host header on redirect (#26750) 
Fixes https://github.com/microsoft/playwright/issues/26743
 2023-08-28 12:42:50 -07:00
Max Schmitt
5c72cbdb23
feat(webkit): roll WebKit to r1898 (#26738) 2023-08-28 19:44:52 +02:00
Max Schmitt
39f8f2ed8d
fix(trace-viewer): use sdkLanguage for Pick Locator (#26737) 
Fixes https://github.com/microsoft/playwright/issues/26736
 2023-08-28 17:39:02 +02:00
Dmitry Gozman
36347e7fea
feat: make playwright package not install browsers automatically (#26672) 
Additionally introduce `@playwright/browser-<browser>` packages that
just download the respective browser, but do not export anything.

References #26614.
 2023-08-27 07:24:35 -07:00
Playwright Service
72aef6bc1d
feat(chromium-tip-of-tree): roll to r1145 (#26726) 
Fixes https://github.com/microsoft/playwright/issues/26713

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-26 12:36:05 +02:00
Max Schmitt
1b30347ae5
fix: maxFailures reached follow-up (#26717) 2023-08-26 08:10:42 +02:00
Pavel Feldman
eb9ef64e7d
fix(android): use domain socket suffix chrome can discover (#26724) 
Fixes: https://github.com/microsoft/playwright/issues/26721
 2023-08-25 19:30:09 -07:00
Pavel Feldman
ee86b9bc94
chore: network panel ui polish (#26722) 2023-08-25 19:20:36 -07:00
Dmitry Gozman
8348f66107
feat: deprecate toMatchSnapshot for buffers (#26718) 
These are usually used for screenshots instead of toHaveScreenshot.
String-based snapshots are left as is.

<img width="836" alt="deprecated"
src="https://github.com/microsoft/playwright/assets/9881434/d02818da-7eea-47fc-8ea8-4104b0dd49b5">

---

Also deemphasized toMatchSnapshot throughout all docs.

Fixes #26612.
 2023-08-25 18:20:01 -07:00
Pavel Feldman
bc1f6272d8
chore: deflate large web socket messages (#26720) 2023-08-25 16:13:46 -07:00
Pavel Feldman
0ecd561db2
chore: improve network panel rendering (#26708) 2023-08-25 12:10:28 -07:00
Playwright Service
ce446437fb
feat(chromium): roll to r1077 (#26709) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-25 19:31:19 +02:00
Max Schmitt
9ae77a71fd
feat: print message if maxFailures has reached (#26322) 
Fixes https://github.com/microsoft/playwright/issues/24239
 2023-08-25 19:06:49 +02:00
Max Schmitt
70dcaabdee
fix: pass sdkLanguage to service server (#26702) 2023-08-25 17:40:26 +02:00
Pavel Feldman
e7bd1864a8
chore: do not add plugins to config twice (#26670) 2023-08-24 16:19:57 -07:00
Yury Semikhatsky
39a6b23309
devops: create blob reports for all "tests 1" (#26694) 2023-08-24 16:06:41 -07:00
Dmitry Gozman
c970179551
fix(resolver): allow importing packages with non-index main script (#26692) 
Regressed in https://github.com/microsoft/playwright/pull/23254.

Fixes #26650.
 2023-08-24 14:09:00 -07:00
Dmitry Gozman
0ecc13038f
fix(textContent): make it work for ShadowRoot (#26690) 
It used to work, but regressed in v1.36.

Fixes #26636.
 2023-08-24 12:59:42 -07:00
Pavel Feldman
6d4f937674
chore: fix installation tests (#26691) 2023-08-24 12:48:39 -07:00
Dmitry Gozman
c90c943154
fix(test.fail): expect() failure should not skip future tests (#26663) 
We used to stop the worker that would skip future tests. Regressed in
https://github.com/microsoft/playwright/pull/11850.

Fixes #26435.
 2023-08-24 08:32:14 -07:00
Pavel Feldman
0406e45cf3
chore: render download progress in the host process (#26666) 2023-08-24 07:33:32 -07:00
Dmitry Gozman
81cc39ea6e
feat(expect): narrow down available assertions for Page/Locator/APIResponse (#26658) 
Fixes #26381.
 2023-08-23 13:14:39 -07:00
Pavel Feldman
197f79c933
chore: show action on hover even if there is no film (#26655) 2023-08-23 12:55:01 -07:00
Dmitry Gozman
44d3770559
fix(selector generator): escape all tag names in css selectors (#26659) 
Fixes #26657.
 2023-08-23 12:32:08 -07:00
Pavel Feldman
46e33cd384
feat: allow installing browsers from ui (#26628) 2023-08-23 12:26:11 -07:00
Max Schmitt
f41c862ac6
fix: process host early exit crash (#26642) 2023-08-23 18:03:24 +02:00
Dmitry Gozman
218955c155
fix(test runner): make sure static annotations are reported for skipped tests (#26634) 
Fixes #26397.
 2023-08-23 08:40:12 -07:00
Pavel Feldman
f4f9e526a2
chore: tolerate css imports (#26626) 
Fixes https://github.com/microsoft/playwright/issues/24580
 2023-08-23 08:32:23 -07:00
Pavel Feldman
91b784e15e
chore: update icon font (#26627) 2023-08-23 08:31:43 -07:00
Pavel Feldman
00e6540799
feat(ui): show test trace events live (#26619) 2023-08-22 15:46:41 -07:00
Dmitry Gozman
c4e79eb6ed
feat: replace Locator.type with Locator.pressSequentially (#26624) 
Also deprecate `Locator.type`, `Frame.type`, `Page.type` and
`ElementHandle.type`, but not `Keyboard.type`.

References #24614.
 2023-08-22 15:21:00 -07:00
Pavel Feldman
65aa062ea1
fix(console): make format console message w/o args (#26620) 
Fixes https://github.com/microsoft/playwright/issues/26600
 2023-08-22 14:29:35 -07:00
Dmitry Gozman
5646875e5c
fix: make Request.frame throw when page is not ready yet (#26616) 
Suggest to check `request.isNavigationRequest()` beforehand.

Fixes #24603.
 2023-08-22 14:06:21 -07:00
Pavel Feldman
afc5ebe075
chore: give more time to polling matchers to print friendly error (#26595) 2023-08-22 09:01:42 -07:00
Max Schmitt
c27317b6e5
feat(webkit): roll to r1893 (#26596) 
This should make it into v1.38 and once its merged one day later it can
be tested in [Playwright
Canary](https://playwright.dev/docs/canary-releases).

Fixes https://github.com/microsoft/playwright/issues/22569
Fixes https://github.com/microsoft/playwright/issues/23259
 2023-08-22 17:57:02 +02:00
Max Schmitt
18e03da445
docs: use absolute paths for file uploads (#26611) 
Fixes https://github.com/microsoft/playwright/issues/26536

This makes it a bit harder for MJS customers, but I guess they know that
they can do

    const dirname = path.dirname(url.fileURLToPath(import.meta.url));
 2023-08-22 17:38:23 +02:00
Max Schmitt
399f5383bc
chore: fix installation tests (#26602) 2023-08-22 16:48:52 +02:00
Max Schmitt
e4366e59e2
chore: fix docs & lint check (#26598) 
This broke after https://github.com/microsoft/playwright/pull/26594.
 2023-08-22 16:45:41 +02:00
Pavel Feldman
1ceaa923ea
chore: create artifacts dir in the test runner (#26594) 2023-08-21 19:41:10 -07:00
Pavel Feldman
fe7b956c3b
chore: allow toggling sidebar location (#26589) 2023-08-21 19:40:44 -07:00
Dmitry Gozman
72bdd43e69
fix(route): make sure Route.fetch works for popup main request (#26590) 
References #24603.
 2023-08-21 16:48:51 -07:00
Pavel Feldman
c3c3c7f53c
chore: decorate console message sources (#26588) 2023-08-21 16:05:27 -07:00
Max Schmitt
2edecd4244
test: add libsoup3 related tests (#26572) 
https://github.com/microsoft/playwright/issues/22569
https://github.com/microsoft/playwright/issues/23259
 2023-08-21 22:12:12 +02:00
Pavel Feldman
2b16860e06
chore: locator tab polish (#26568) 2023-08-21 10:59:49 -07:00
Pavel Feldman
f83d81956d
chore: make console stream live in ui mode (#26562) 2023-08-21 10:59:37 -07:00
Dmitry Gozman
32a309ccb8
chore: install source map support lazily (#26445) 
This way we allow importing from `@playwright/test` without affecting
stack traces.

Fixes #26346.
 2023-08-21 10:54:42 -07:00
Richard Blažo
bcc30bc71e
feat: add title for before and after hooks (#26523) 2023-08-21 09:50:22 -07:00
Max Schmitt
2f6148bcd1
chore: use SVG icons for web apps (#26564) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
 2023-08-21 18:33:02 +02:00
Tmk
fbe3ef92e5
feat: allow absolute ctTemplateDir (#26526) 2023-08-21 09:30:56 -07:00
Kevin Centeno
ba4c242a82
docs(assertions): remove unneeded await in generic assertions example (#26569) 2023-08-21 18:13:25 +02:00
Sander
06d2e7d480
fix(ct): vue jsx mount options type (#26566) 2023-08-21 08:48:03 -07:00
Pavel Feldman
41c312cd04
chore: fix ui mode to show screenshots (#26563) 2023-08-20 14:47:18 -07:00
Max Schmitt
3ac61f5c49
feat(chromium-tip-of-tree): roll to r1144 (#26565) 
Note: r1143 got skipped due to a Windows build failure.
 2023-08-20 14:08:45 +02:00
Sander
e2a11bed19
feat(ct): svelte vite context (#26554) 2023-08-19 16:26:06 -07:00
Marcin Strzyz
192b697488
chore: remove old webpack folder structure (#26560) 2023-08-19 16:16:44 -07:00
Pavel Feldman
09bb866333
chore: format console message from page (#26555) 2023-08-19 16:13:42 -07:00
Pavel Feldman
8f31191637
chore: pick locator tab (#26532) 2023-08-18 17:53:03 -07:00
Max Schmitt
22dacdb75f
fix: component testing types with moduleresolution: bundler (#26551) 
Fixes https://github.com/microsoft/playwright/issues/24581
 2023-08-18 22:44:05 +02:00
Max Schmitt
29fbcbee69
fix: warn if PWT commands get executed without PWT (#26542) 
Fixes https://github.com/microsoft/playwright/issues/26541
 2023-08-18 18:26:34 +02:00
Max Schmitt
703f590146
feat(webkit): roll to r1887 (#26528) 2023-08-17 22:17:28 +02:00
Marcin Strzyz
6b2d93a890
chore: error on unused eslint disables (#26510) 2023-08-17 20:53:36 +02:00
Pavel Feldman
049f839b30
chore: use glass pane for dragging (#26513) 2023-08-17 09:36:59 -07:00
Vignesh Shanmugam
adc9b2d390
feat: add support for browserContext.on('pageerror') (#24452) 
+ fix #24466
+ Adds support for exposing the `pageerror` events via `browserContext`
API.
+ Helps with capturing the overall exceptions that are thrown outside of
the the current page and also captures the exceptions happens on other
windows/popups.
+ Keeps the API in sync with `context.on('request)',
context.on('console'), etc..`
 2023-08-17 09:10:03 -07:00
Jean-François Greffier
dcab22c307
feat: display package manager in CLI help and tips (#26450) 
Display `npx playwright`, `yarn playwright` or `pnpm exec playwright` in
CLI

Fixes #21425
 2023-08-17 08:53:08 -07:00
Jonah
0c3703fda1
feat: add iPhone 14 family (#24570) 
Fixes #24214
 2023-08-17 11:05:40 +02:00
Max Schmitt
75ed251c9e
fix: download of attachments in UI Mode (#26407) 
Fixes https://github.com/microsoft/playwright/issues/26326.
 2023-08-17 10:57:28 +02:00
Marcin Strzyz
0e6deb7c8d
chore: Update to latest version of TS Eslint to get TS 5.1 support. (#26511) 
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-08-17 10:57:13 +02:00
Marcin Strzyz
42543a48a7
fix: fixed PW_TEST_HTML_REPORT_OPEN + more type safe + doc (#24571) 
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-08-17 09:48:59 +02:00
Pavel Feldman
a705d68c8a
chore: filter actions, console and network based on the timeline window (#26509) 2023-08-16 16:30:17 -07:00
ggorlen
0149c7d56c
docs: fix typo in Reporter.onEnd (#26486) 
Signed-off-by: ggorlen <gsgorlen@gmail.com>
 2023-08-17 00:40:14 +02:00
Pavel Feldman
929a849265
chore: fix .only in dependent tests (#26503) 
Fixes https://github.com/microsoft/playwright/issues/26492
 2023-08-16 13:39:08 -07:00
Max Schmitt
1a1ff6c671
chore: move launchApp into separate function (#26499) 
https://github.com/microsoft/playwright/pull/26407#discussion_r1290727547
 2023-08-16 18:13:40 +02:00
Max Schmitt
4c4525c9e0
chore: make html report produce named attachments (#26421) 
https://github.com/microsoft/playwright/issues/26326
 2023-08-16 18:06:04 +02:00
Max Schmitt
d2165f3e2d
feat(webkit): roll to 1886 (#26490) 2023-08-16 10:10:14 +02:00
Pavel Feldman
576608b69d
chore: revert #24598 (#26484) 2023-08-15 11:29:33 -07:00
Max Schmitt
2deabefa71
fix: Locator.evaluateHandle types (#26469) 
Fixes https://github.com/microsoft/playwright/issues/26449
 2023-08-14 18:27:25 +02:00
Playwright Service
04b71bf660
feat(chromium-tip-of-tree): roll to r1142 (#26441) 2023-08-12 20:00:16 +02:00
Playwright Service
96965cfbe9
feat(webkit): roll to r1885 (#26443) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-08-12 19:17:07 +02:00
Max Schmitt
bd988b34a7
chore: allow calling spawnSync on Node.js file inside test (#26429) 
Fixes https://github.com/microsoft/playwright/issues/24516

Relates https://github.com/microsoft/playwright/pull/16733
 2023-08-11 18:37:14 +02:00
Dmitry Gozman
b899d61a51
docs: examples that save download with suggested filename (#26425) 
Fixes #26341.
 2023-08-10 17:20:39 -07:00
Pavel Feldman
d0fec20fe1
chore: update test certificates (#26423) 2023-08-10 17:06:03 -07:00
Dmitry Gozman
050f26764e
docs: explain how to reset storage state (#26422) 
References #26374.
 2023-08-10 16:32:45 -07:00
Dmitry Gozman
c37dfb379b
docs: make sure usage comes after description when templating (#26420) 2023-08-10 14:48:26 -07:00
Yury Semikhatsky
00c8dd7ecc
chore(html): remove unused map (#26415) 2023-08-10 13:02:35 -07:00
Yury Semikhatsky
ad9d20311a
fix(merge): allow reports with same name as input (#26413) 2023-08-10 12:47:31 -07:00
Playwright Service
ca06aca161
feat(webkit): roll to r1884 (#26406) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-10 17:44:19 +02:00
Playwright Service
167165d179
feat(chromium): roll to r1076 (#26400) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-10 15:16:10 +02:00
Yury Semikhatsky
d44a127014
chore: delete raw reporter (#26391) 
Build HTML reporter using TeleReceiver's structures directly, this saves
us unnecessary memory allocation for the intermediate structures.
 2023-08-09 22:01:44 -07:00
Pavel Feldman
7a250a960b
chore: roll grid deps for socks proxy (#26392) 2023-08-09 21:18:36 -07:00
Pavel Feldman
08d6abab4a
chore: allow merging defineConfig (#26390) 2023-08-09 17:23:34 -07:00
Dmitry Gozman
cadc3153f7
fix(test runner): failed + skipped = flaky (#26385) 
Fixes #17652.
 2023-08-09 16:35:14 -07:00
Andrey Lushnikov
a61431f6bb
chore: cut 1.37.0 branch (#26357) 2023-08-09 01:46:29 -07:00
Pavel Feldman
65ac0d5256
chore: add k8s grid deployments (#26359) 2023-08-08 18:46:32 -07:00
Andrey Lushnikov
ffd6cf60eb
fix: eliminate race in compilation cache (#26353) 
Fixes https://github.com/microsoft/playwright/issues/24569
 2023-08-08 15:09:20 -07:00
Yury Semikhatsky
bc2c7946bb
fix: do not throw when merging into blob report (#26355) 
We cannot import a Symbol to isomorphic code from config. Instead,
__projectId property is used.
 2023-08-08 14:47:12 -07:00
Yury Semikhatsky
8fcb6383ce
chore(blob): store playwright user agent (#26337) 2023-08-08 10:39:48 -07:00
Yury Semikhatsky
0e20d352cf
chore(merge): read test events from one file at a time (#26333) 
Reference https://github.com/microsoft/playwright/issues/24451
 2023-08-07 17:39:32 -07:00
Yury Semikhatsky
7f1f62795d
chore(blob): add dash to report name (#26335) 
This regressed in #25017
 2023-08-07 17:22:31 -07:00
Dmitry Gozman
9509c300e4
fix(reuse): make sure newly created page is not "server-side-only" (#26332) 
This page is going to be the "page for reuse", so it should not be
marked as "server-side-only" and should issue all required events.

Fixes #24574.
 2023-08-07 16:26:30 -07:00
Dmitry Gozman
90c765d31c
chore(blob): split onBegin into multiple onProject events (#26329) 2023-08-07 14:33:18 -07:00
Dmitry Gozman
27c15b705d
fix(blob): replace projectSuffix with reportName (#25017) 
Always ensure unique project/test ids across blobs.
Show `reportName` as a label in the html report.

References #24451.
 2023-08-07 13:38:09 -07:00
Max Schmitt
1383844af8
docs: make --grep more clear (#26324) 
Fixes https://github.com/microsoft/playwright/issues/24604
 2023-08-07 17:40:30 +02:00
Playwright Service
bddd4eadad
feat(webkit): roll to r1883 (#26318) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-07 16:09:37 +02:00
Andrey Lushnikov
fa8f3f6454
fix: use snapshotPath instead of expectedPath for image diffs (#24567) 
This opens a road to the "accept new screenshot" button in
Playwright tools.

References https://github.com/microsoft/playwright/issues/24310
 2023-08-07 04:42:35 -07:00
Marcin Strzyz
53fd4bedb4
chore: ensure the file operations are async in the junit reporter (#24577) 2023-08-07 10:03:01 +02:00
Yury Semikhatsky
f1f43c9ad1
chore(merger): internalize json strings after parse (#25801) 
Reference: https://github.com/microsoft/playwright/issues/24451
 2023-08-05 13:17:39 -07:00
Pavel Feldman
414a4c3ef0
chore: pass color through in web server commands (#24619) 2023-08-05 09:01:27 -07:00
Pavel Feldman
120de62798
chore(grid): add command line options (#24802) 2023-08-04 18:08:50 -07:00
Yury Semikhatsky
6c3142959d
fix(blob): store startTime as a number (#24620) 
Turns out the Date objects have noticeable footprint on large suites and
storing them as umber is much cheaper, e.g.:


![image](https://github.com/microsoft/playwright/assets/9798949/539028d0-3ef8-46f7-be2b-752f24604d18)
 2023-08-04 16:06:23 -07:00
Dmitry Gozman
1d4919cea4
docs: encourage using fill instead of type (#24616) 
References #24614.
 2023-08-04 14:19:57 -07:00
Yury Semikhatsky
d62493f925
chore: intern test ids and abs paths (#24618) 
Created named classes for TeleTestStep and TeleTestResult which makes it
easier to analyze in heap snapshot. Also changing `titlePath` from a
closure to a method on TeleTestStep saved ~100Mb out of 2300Mb.

Intern test ids and absolute paths which showed up a lot of duplicate
strings in heap snapshot.

Clear stepMap after processing onTestEnd.
 2023-08-04 14:10:06 -07:00
Ben McCann
6ebee33857
chore: prefer import over require (#24568) 2023-08-04 13:21:41 -07:00
Pavel Feldman
8fde110c61
chore: allow web server w/o waiting (#24609) 2023-08-04 12:05:16 -07:00
Pavel Feldman
b3ce913551
Revert "chore: allow calling spawnSync on Node.js file inside test" (#24611) 
Reverts microsoft/playwright#24539
 2023-08-04 09:01:38 -07:00
Pavel Feldman
6731f5b6d5
chore: grid placeholder (#24598) 2023-08-04 08:38:07 -07:00
Playwright Service
dfea18b588
feat(chromium): roll to r1075 (#24605) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-04 15:20:52 +02:00
Yury Semikhatsky
9575867f1c
fix(blob): throw if blob report has newer version than the merger (#24593) 2023-08-03 15:11:34 -07:00
Max Schmitt
2193903d03
chore: allow calling spawnSync on Node.js file inside test (#24539) 
Fixes https://github.com/microsoft/playwright/issues/24516 

Relates https://github.com/microsoft/playwright/pull/16733
 2023-08-04 00:03:14 +02:00
Yury Semikhatsky
8e2f33673b
chore(blob): change file name to report{-suffix}{-shard}.zip (#24592) 2023-08-03 13:23:30 -07:00
Playwright Service
b4c9f5ab89
feat(webkit): roll to r1882 (#24584) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-03 17:40:54 +02:00
Yury Semikhatsky
a867e738db
chore(merge): console status updates (#24559) 2023-08-02 14:49:06 -07:00
Max Schmitt
b0473b71cd
chore: limit docs snippet length to 100 (#24563) 2023-08-02 11:23:47 +02:00
Yury Semikhatsky
f5d069541d
chore(blob): add version to metadata (#24556) 2023-08-01 16:06:06 -07:00
Yury Semikhatsky
8da37b364b
chore(blob): zip output directory by default (#24536) 
Changed the logic to add attachment to the zip in onEnd rather than
onTestEnd because attachment files can be deleted if e.g. preserveOutput
option is specified. Instead we add files once all workers have been
shut down. On a simple run with 1000 tests each adding 1Mb attachment
the overall time difference is 49s (streaming attachments) v 1m9s
(attachments added in the end).
 2023-08-01 15:21:23 -07:00
Yury Semikhatsky
ce341ae5b5
docs: clarify setContent semantics (#24553) 
Fixes https://github.com/microsoft/playwright/issues/24503
 2023-08-01 11:45:58 -07:00
Playwright Service
9d5d2c60bb
feat(firefox-beta): roll to r1422 (#24533) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-01 04:28:30 -07:00
Sander
7c5d73a3c3
feat(ct): vue type safe mount props (#23151) 2023-07-31 17:45:34 -07:00
Sander
98cba15938
feat(ct): vue2 type safe mount props (#23194) 2023-07-31 17:44:43 -07:00
Playwright Service
dc5e201611
feat(firefox): roll to r1422 (#24531) 
Fixes https://github.com/microsoft/playwright/issues/24132

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-31 17:10:22 -07:00
Pavel Feldman
009f9994df
fix(html): mobile layout for filters (#24506) 2023-07-31 16:54:07 -07:00
Playwright Service
77b1ec4a53
feat(webkit): roll to r1881 (#24521) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-31 23:31:35 +02:00
Andrey Lushnikov
f135b5f7a8
fix: make sure monotonicTime() value is reasonable (#24518) 
https://github.com/microsoft/playwright/issues/24432
 2023-07-31 09:42:08 -07:00
Dmitry Gozman
d92fe16b76
fix(blob report): default location relative to package.json (#24481) 
Also:
- remove `blob-report` directory at the start;
- markdown's `report.md` next to package.json;
- use default location in playwright's workflows.

References #24451.
 2023-07-28 15:49:31 -07:00
Dmitry Gozman
a74101d98f
docs: document expect's asymmetric matchers (#24498) 
References #24460, #24417.
 2023-07-28 14:04:01 -07:00
Playwright Service
947637d19f
feat(webkit): roll to r1880 (#24496) 2023-07-28 21:26:43 +02:00
Pavel Feldman
b5d49d0849
chore: do not pass access-key header into the redirects (#24478) 2023-07-27 19:03:14 -07:00
Dmitry Gozman
9c70a75d48
fix(merge): make sure testId from different blobs are unique (#24475) 
Fixes a scenario where each shard runs the same setup project.

References #24451.
 2023-07-27 18:54:00 -07:00
Dmitry Gozman
1754755684
fix(tracing): make sure resetForReuse does not throw (#24415) 
When trace chunk recording is in progress, calling `stop()` throws
`Error: Must stop trace file before stopping tracing`.
 2023-07-27 08:06:42 -07:00
Dmitry Gozman
1b233a5ae2
fix(trace viewer): do not serve 304 responses (#24435) 
These do not have any content, and we should server the original
response that was cached by the browser.

Fixes #24255.
 2023-07-27 08:06:00 -07:00
Playwright Service
9b364f072d
feat(chromium-tip-of-tree): roll to r1136 (#24463) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 15:46:16 +02:00
Playwright Service
b1ea9507a8
feat(chromium): roll to r1074 (#24461) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 15:02:40 +02:00
Playwright Service
7524894512
feat(firefox-beta): roll to r1421 (#24439) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 01:29:38 -07:00
Playwright Service
682a7f0227
feat(firefox): roll to r1421 (#24433) 
Fixes https://github.com/microsoft/playwright/issues/22590

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 01:29:17 -07:00
Dmitry Gozman
c8f2fc392a
chore: move fs operation in trace recorder to a separate class (#24383) 2023-07-26 17:31:00 -07:00
Dmitry Gozman
ea6d127f28
feat(connect): exposeNetwork option (#24436) 2023-07-26 17:29:31 -07:00
Dmitry Gozman
e0cbb0882b
fix(launch): default to non-zero launch timeout (#24440) 
When not specified, launch timeout is 3 minutes, taken from the
`DEFAULT_LAUNCH_TIMEOUT` constant.
Also, use the default launch timeout for `electron.launch()` instead of
default regular timeout.
 2023-07-26 16:16:00 -07:00
Dmitry Gozman
c8b45aa844
chore: validate markdown links in doclint (#24444) 
Fixes #24421.
 2023-07-26 16:15:07 -07:00
Dmitry Gozman
4be1e479ea
fix(artifacts): only attach screenshot when it succeeds (#24406) 
Fixes #24378.
 2023-07-26 15:22:04 -07:00
Pavel Feldman
4949cef09c
chore: save chrome trace on the client side (#24414) 2023-07-26 14:11:26 -07:00
Dmitry Gozman
ed99ac7395
fix(sigint): make sure we do not add handler twice (#24413) 
In the following scenario, we were adding SIGINT handler twice, but
removing it just once:
- Task runner starts testing, creates SigIntWatcher, installs SIGINT
handler.
- Press Ctrl+C, task runner interrupts, disarms SigIntWatcher, SIGINT
handler is not removed due to 1000ms cooldown.
- Task runner starts cleanup, creates SigIntWatcher, installs another
SIGINT handler.
- Cleanup finishes, SigIntWatcher disarms, could remove or not remove
SIGINT handler based on timing (same 1000ms cooldown). In any case, we
have one or two SIGINT handlers still on.
- HTML reporter hangs in onExit, while we still have SIGINT handler up,
so Ctrl+C does not exit.

Regressed in #24265.
 2023-07-25 18:35:38 -07:00
Pavel Feldman
b39fd7283f
chore: skip tests that fail in cross-machine service mode (#24412) 2023-07-25 16:47:04 -07:00
Dmitry Gozman
9d0bba9c99
fix(tracing): do not throw on missing attachments (#24409) 
Fixes #24378.
 2023-07-25 14:32:56 -07:00
Pavel Feldman
33d62d9a97
chore: do not use relative xpath when querying from document (#24405) 
Fixes https://github.com/microsoft/playwright/issues/24399
 2023-07-25 12:55:35 -07:00
Playwright Service
afd6f7d342
feat(chromium-tip-of-tree): roll to r1135 (#24393) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-25 15:05:56 +02:00
Max Schmitt
5c41c6e799
chore: allow installing Google Chrome on Debian (#24386) 
Fixes https://github.com/microsoft/playwright/issues/24357
 2023-07-25 00:52:19 +02:00
Dmitry Gozman
4c8912f74e
chore: remove separate process that cleans up directories (#24376) 
A separate process is `spawnSync`'ed on process exit to cleanup
temporary directories, introduced in #13769 that followed up after
#13343.

A separate process might stall for various fs-related issues, which
prevents the original process from exiting.

With the recent changes, we always gracefully close and cleanup after
all launched executables before calling `process.exit()`, and so it
should only be possible to leave temp directories when using Playwright
and calling `process.exit()` programmatically without closing browsers.

We can now drop the extra process and rely on `rimraf.sync` for
last-resort cleanup in these rare circumstances.
 2023-07-24 15:24:29 -07:00
Sander
1abff78de2
fix(ct): remove json typechecking (#24114) 2023-07-24 15:22:20 -07:00
Marcin Strzyz
78a2b7237e
feat: add screen definitions for ipad gen 5 (#24355) 2023-07-24 14:57:12 -07:00
Pavel Feldman
4ba6d789bc
Revert "chore: refactor timeout manager to use scopes (1) (#24315)" (#24382) 
This reverts commit f5df0940c9.
 2023-07-24 14:09:20 -07:00
Playwright Service
d144c5e6e3
feat(webkit): roll to r1879 (#24380) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-24 22:40:54 +02:00
Andrey Lushnikov
fee08a6d3b
fix: properly handle character sets in globs (#24371) 
https://github.com/microsoft/playwright/issues/24316
 2023-07-24 09:49:05 -07:00
Dmitry Gozman
b4c412eb1f
chore: replace process.exit with graceful closure (#24242) 
Everywhere we call `process.exit()`, we might actually need to
gracefully close all browsers.
 2023-07-24 08:29:29 -07:00
Alex Ravenna
b93b2a7155
docs: fix minor grammar and text issues (#24331) 2023-07-24 14:59:15 +02:00
Dmitry Gozman
2cb0622c39
chore: rename ScopedRace to LongStandingScope, preserve Error instance in reject() (#24361) 2023-07-23 21:00:07 -07:00
Marcin Strzyz
2070861807
chore: ensure the file operations are async in the json reporter. (#24356) 2023-07-23 09:26:32 +02:00
Yury Semikhatsky
6a3721eb9c
chore: delete --attachments option from merge-reports command (#24350) 
We recommend uploading all resources along with the generated report. If
need be we'll reconsider adding the option later.
 2023-07-21 13:15:00 -07:00
Andrey Lushnikov
d307c8e63a
fix(ssim-cie94): make sure a single off pixel yields diff in comparator (#24348) 
This patch brings in antialiasing tests from `looks-same` project for
our experimental `ssim-cie94` comparator.

One of the new tests found a bug in our implementation.

References https://github.com/microsoft/playwright/issues/24312
 2023-07-21 12:27:52 -07:00
Playwright Service
aa39f39bda
feat(webkit): roll to r1878 (#24340) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-21 09:55:30 +02:00
Pavel Feldman
f5df0940c9
chore: refactor timeout manager to use scopes (1) (#24315) 2023-07-20 17:21:21 -07:00
Dmitry Gozman
767addec8c
chore: make sure to call task's teardown if it has ever started (#24317) 
This way things like WebServerPlugin can cleanup after themselves even
if they failed to start or were interrupted mid-way.
 2023-07-20 17:16:22 -07:00
Yury Semikhatsky
59d5198d17
fix(fetch): handle negative max-age and expires attributes (#24311) 
Fixes #24221
 2023-07-20 15:42:52 -07:00
Playwright Service
57305e985e
feat(webkit): roll to r1877 (#24330) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-20 17:47:21 +02:00
Playwright Service
80daf47d44
feat(chromium): roll to r1073 (#24326) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-20 16:15:56 +02:00
Playwright Service
7ba60ca91d
feat(chromium-tip-of-tree): roll to r1134 (#24325) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-20 16:15:40 +02:00
Playwright Service
eac47ce913
feat(webkit): roll to r1876 (#24302) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-19 18:24:59 +02:00
Playwright Service
20fcd6b272
feat(webkit): roll to r1875 (#24299) 
Since
99ff08340f
search event is disabled in cocoa.

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-19 18:24:21 +02:00
Max Schmitt
1288519915
fix(ui-mode): run teardown handlers with Command + C (#24267) 
Fixes https://github.com/microsoft/playwright/issues/23907
 2023-07-19 17:50:25 +02:00
Andrey Lushnikov
1fdd7541e0
chore: add firefox-asan for stress tests (#24049) 2023-07-19 05:53:52 -07:00
Playwright Service
fbb384483b
feat(webkit): roll to r1874 (#24297) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-19 14:20:19 +02:00
Playwright Service
a136763118
feat(webkit): roll to r1873 (#24296) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-19 14:19:05 +02:00
Max Schmitt
9af0c6d822
chore: remove glob dependency from utils bundle (#24291) 2023-07-19 05:17:34 +02:00
Pavel Feldman
879ddb73b0
chore: show last poller error on test timeout (#24292) 2023-07-18 17:03:26 -07:00
Marcin Strzyz
d5e7b4f16f
chore: update rimraf package to version 4 to eliminate "promisify" (#24190) 
Migrate to version 4 which returns a promise rather than leverages a
callback. -> https://www.npmjs.com/package/rimraf?activeTab=readme

- contains its own types, eliminate "@types/rimraf"
- Parameter `maxBusyTries` changed to `maxRetries`
 2023-07-18 19:58:07 +02:00
Marcin Strzyz
0eb94aaa79
chore: refactored minimum Node Major version to variable (#24188) 2023-07-18 19:57:48 +02:00
Max Schmitt
d2f581a19c
fix(test-runner): don't double emit SIGINT in long running test (#24265) 
https://github.com/microsoft/playwright/issues/23907

This fixes the following scenario. You press Command + C during the
test-execution, then a global teardown will execute, which takes a long
time and before this on macOS did sometimes end up in an unwanted SIGINT
received inside the globalTeardown handler. After this change this won't
happen anymore.
 2023-07-18 18:46:18 +02:00
Yury Semikhatsky
d0280ec8c7
chore(blob): drop shard number from report name (#24270) 
We store shard number in the report metadata event and then sort shard
files by shard number. This guarantees that within each project sharded
events will always go in stable order.
 2023-07-18 09:29:25 -07:00
Playwright Service
b24ec33aa9
feat(chromium-tip-of-tree): roll to r1133 (#24280) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-18 15:11:01 +02:00
Playwright Service
57da4c200a
feat(chromium): roll to r1072 (#24279) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-18 15:10:30 +02:00
Pavel Feldman
5ff1fadd7b
chore: apply only filtration to deps (#24268) 2023-07-17 16:48:52 -07:00
Yury Semikhatsky
f6540f89ea
chore(markdown): do not print details for flaky tests (#24264) 2023-07-17 16:09:59 -07:00
Yury Semikhatsky
15b9e5afdb
fix: print fatal and no snippet errors in markdown report (#24263) 2023-07-17 13:50:00 -07:00
Pavel Feldman
49c1f9eb02
feat(ui): run deps in UI mode if dep projects are checked (#24245) 2023-07-15 15:11:31 -07:00
Yury Semikhatsky
3616023cf6
chore: markdown report details (#24237) 2023-07-14 12:32:25 -07:00
Dmitry Gozman
97d55e275d
fix(locator): locator(locator) method uses internal:chain instead of >> (#24235) 
Usually, we can just chain two locators with `>>` to implement
`Locator.locator(locator)`. However, this does not play nicely with more
advanced inner locators like `or` and `and`:

```ts
const child = page.locator('input').or(page.locator('button'));
page.locator('parent').locator(child);
```

One would expect the above to locate "input or button" inside a
"parent". However, currently it locates "input inside a parent" or
"button", because it's translated to `parent >> input >>
internal:or="button"`.

To fix this, we have to wrap inner locator into `internal:chain` and
query it separately from the parent.

Fixes #23724.
 2023-07-14 12:21:45 -07:00
Dmitry Gozman
98f3ca05b9
fix(tracing): only access tracing state on the API calls, not inside trace operations (#24212) 
References #23387.
 2023-07-14 06:19:54 -07:00
Pavel Feldman
5d799606c3
chore: resolve top-level vs dependency after cli filtering (#24216) 2023-07-13 17:54:08 -07:00
Pavel Feldman
33bab3652d
fix(ui): bump min sidebar size (#24193) 2023-07-13 15:14:49 -07:00
Max Schmitt
57cca1d96e
Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 
This reverts commit 4b1b4dc23b.

https://github.com/microsoft/playwright/issues/24184

Reopens https://github.com/microsoft/playwright/issues/23386
 2023-07-13 20:03:02 +02:00
Max Schmitt
b483bf9fcc
feat: add support for Debian 12 for Firefox/WebKit (#24206) 
https://github.com/microsoft/playwright/issues/23532

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
 2023-07-13 12:56:44 +02:00
Andrey Lushnikov
615f5afb2b
feat(firefox): roll Firefox to 1420 (#24205) 
Fixes https://github.com/microsoft/playwright/issues/22753
 2023-07-13 03:54:47 -07:00
Playwright Service
7787988043
feat(webkit): roll to r1872 (#24201) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-13 11:07:33 +02:00
Playwright Service
04be72213b
feat(chromium-tip-of-tree): roll to r1132 (#24204) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-13 10:58:13 +02:00
Dmitry Gozman
53feeaf270
fix(tracing): avoid trace file name collisions (#24191) 
We have been optionally adding `-<number>` in multiple places, and these
might collide in various circumstances, for example: two contexts at the
same time, one of them has the second trace chunk.

References #23387.
 2023-07-12 17:20:25 -07:00
Pavel Feldman
53bf1995db
chore: do not leak internal page handles after closing page (#24169) 
Partial fix for https://github.com/microsoft/playwright/issues/6319

After this fix, the following scenario won't leak and the context state
(cookies, storage, etc) can be reused by the new page sessions:

```js
  for (let i = 0; i < 1000; ++i) {
    const page = await context.newPage();
    await page.goto('...');
    await page.close('...');
  }
```
 2023-07-12 14:51:13 -07:00
Max Schmitt
a0b0752662
fix: encode launch options correctly when reusing browser (#24174) 
Fixes https://github.com/microsoft/playwright/issues/24157
 2023-07-12 16:40:55 +02:00
Playwright Service
6e02fda2a0
feat(firefox-beta): roll to r1419 (#24165) 
Fixes https://github.com/microsoft/playwright/issues/24081

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-12 03:28:20 -07:00
Dmitry Gozman
76d85c55cf
chore: remove unused code (#24167) 2023-07-11 15:08:05 -07:00
Pavel Feldman
067faa50d7
chore: migrate Promise.race to scopes to prevent leaks (#24160) 2023-07-11 10:38:08 -07:00