Commit Graph

590 Commits

Author SHA1 Message Date
Yury Semikhatsky
7d2293c6ed
browser(webkit): roll to 01-25 (#5141) 2021-01-25 11:27:08 -08:00
Yury Semikhatsky
680689d075
browser(webkit): try to fix Ubuntu 18 build (#5119) 2021-01-22 16:10:01 -08:00
Dmitry Gozman
05568f7420
browser(webkit): change scrollIntoView to only scroll if needed (#5079) 2021-01-20 21:06:29 -08:00
Yury Semikhatsky
449bcdcbf9
browser(webkit): roll to 01-19 (#5064) 2021-01-19 23:18:05 -08:00
Yury Semikhatsky
fdfea2b765
browser(webkit): add another missing include to fix mac after roll to 01-15 (#5037) 2021-01-15 18:56:24 -08:00
Yury Semikhatsky
940cf35d84
browser(webkit): add missing include on mac after roll to 01-15 (#5033) 2021-01-15 14:43:48 -08:00
Yury Semikhatsky
0ab6a53212
browser(webkit): roll to 01-15 (#5032) 2021-01-15 12:53:05 -08:00
Joel Einbinder
36650b1e19
browser(webkit): fix compile on mac (#4977) 2021-01-11 14:30:06 -08:00
Yury Semikhatsky
56f012043b
browser(webkit): fix mac compilation after roll to 01-11 (#4972) 2021-01-11 11:30:54 -08:00
Yury Semikhatsky
62c52e8628
browser(webkit): roll to 01-11 (#4971) 2021-01-11 11:00:07 -08:00
Yury Semikhatsky
5854cadd0b
browser(webkit): fix typo in macro name (#4970) 2021-01-11 10:03:45 -08:00
Joel Einbinder
cc1a79eceb
browser(webkit): drag and drop on windows (#4889) 2021-01-06 09:46:35 -08:00
Yury Semikhatsky
2908568f9a
browser(webkit): install new dependency required for openxr on linux (#4906) 2021-01-05 16:05:21 -08:00
Yury Semikhatsky
5df1c6e560
browser(webkit): roll to 01-05 to pick up upstream Win fix (#4894) 2021-01-05 13:08:52 -08:00
Yury Semikhatsky
849a5b3795
browser(webkit): roll to 01-04 (#4882) 2021-01-05 09:13:13 -08:00
Yury Semikhatsky
3ff81fe172
browser(webkit): do run win build again if first attempt failed (#4881) 2021-01-04 13:40:56 -08:00
Yury Semikhatsky
b0b1561c92
browser(webkit): kick off next build (#4878) 2021-01-04 11:01:43 -08:00
Yury Semikhatsky
736ef4e879
browser(webkit): call build.sh twice on Windows (#4875) 2021-01-04 10:49:46 -08:00
Dmitry Gozman
ded2bc2396
browser(webkit): postpone creation of the first page (#4769)
When we create the first page in the default context in headless mode on mac,
it gets NSWindow that is "not visible". Although we call [window setIsVisible:YES],
later on window.isVisible still returns NO.

We create our offscreen "headless" NSWindow directly from applicationDidFinishLaunching:.
Experiments show that delaying this by 100ms makes everything work. As a symptom,
we get applicationDidUnhide: notification that does not happen when we create the window
immediately.

Perhaps, we create the window too early, and there is some essential initialization
that happens after applicationDidFinishLaunching:. However, if we call
[NSApp activateIgnoringOtherApps:YES] like we do in headful mode, everything works.

The only solution that worked so far is creating the first page after a timeout.
2020-12-29 13:49:39 -08:00
Joel Einbinder
e7ee426202
yury comments (#4639) 2020-12-23 08:04:59 -08:00
Yury Semikhatsky
73edf13ad6
browser(webkit): roll to 12-21 (#4794) 2020-12-21 16:07:45 -08:00
Yury Semikhatsky
e4658ea9c0
browser(webkit): base64 encode request.postData (#4743) 2020-12-16 14:35:05 -08:00
Yury Semikhatsky
94f5002ae4
browser(webkit): install patchelf (required by generate-bundle) (#4741) 2020-12-16 12:53:28 -08:00
Yury Semikhatsky
b014fa1855
browser(webkit): roll to 12-16 (#4739) 2020-12-16 09:19:27 -08:00
Yury Semikhatsky
50b0b47993
browser(webkit): mac build fix after roll to 12-15 (#4733) 2020-12-15 23:07:34 -08:00
Yury Semikhatsky
eecb798356
browser(webkit): roll to 12-15 (#4727) 2020-12-15 13:00:49 -08:00
Andrey Lushnikov
dd9c312b77
devops: start producing WebKit builds for Apple Silicon (#4643)
\m/
2020-12-08 17:15:44 -08:00
Andrey Lushnikov
64a2940a0d
devops: fix webkit archiving (#4642)
Protocol concatenation script did not account for `WK_CHECKOUT_PATH`.
2020-12-08 16:32:45 -08:00
Andrey Lushnikov
17f1b20f39
devops: trigger all builds with new windows buildbot (#4638) 2020-12-08 11:03:11 -08:00
Andrey Lushnikov
c1dcef39a3
devops(windows): fix vswhere location (#4636)
%PROGRAMFILES% locations depends on shell bitness; we're migrating from
mingw32 to mingw64.
2020-12-08 10:27:05 -08:00
Dmitry Gozman
99b98d62a6
browser(webkit): do not spam stderr with screencast debug logs (#4635) 2020-12-08 09:59:57 -08:00
Andrey Lushnikov
73982834e7
devops: absolute paths for webkit libraries and output directory (#4627) 2020-12-07 14:30:06 -08:00
Yury Semikhatsky
4be41f2571
browser(webkit): build fix, switch to the new download API (#4621) 2020-12-07 10:10:32 -08:00
Andrey Lushnikov
d8520f0695
devops: fix webkit building on windows (#4618) 2020-12-07 09:21:36 -08:00
Andrey Lushnikov
13e2ef1d10
devops: suppport WK_CHECKOUT_PATH variable (#4617)
`WK_CHECKOUT_PATH` defines location of webkit checkout on the
file system. All browser-related scripts, like `prepare_checkout.sh` and
`export.sh` respect this environment variable on all platforms.
2020-12-07 08:42:20 -08:00
Yury Semikhatsky
b6eb8e0a90
browser(webkit): fix mac build (#4605) 2020-12-04 17:45:18 -08:00
Yury Semikhatsky
cdbc96ac3a
browser(webkit): roll to 12-04 (#4601) 2020-12-04 16:11:08 -08:00
Andrey Lushnikov
7dc386fa1a
browser(webkit): produce xcode 12.2 build on Mac 10.15 (#4599) 2020-12-04 11:49:07 -08:00
Yury Semikhatsky
512516c956
browser(webkit): retore changes from #4539 (#4544) 2020-11-30 10:49:27 -08:00
Yury Semikhatsky
8f70c95d6c
browser(webkit): roll to 11-30 (#4541) 2020-11-30 10:17:36 -08:00
Joel Einbinder
d96330bbec
browser(webkit): override availWidth with screen width (#4539) 2020-11-30 10:04:28 -08:00
Andrey Lushnikov
51865fe584
chore: bump WebKit build number to test self-hosted runners (#4525) 2020-11-25 08:38:23 -08:00
Dmitry Gozman
1169c5ab50
browser(webkit): close on pipe disconnect (#4484) 2020-11-18 19:34:33 -08:00
Yury Semikhatsky
a11be3e9ef
browser(webkit): roll to 11-18 (#4481) 2020-11-18 13:03:42 -08:00
Andrey Lushnikov
8860d6d11d
chore: try building webkit on github selfhosted runner (#4476) 2020-11-17 21:03:51 -08:00
Pavel Feldman
79c592ed7d
browser(webkit): do not create unique page groups for pages (#4456) 2020-11-16 14:31:50 -08:00
Yury Semikhatsky
5509e98ba5
browser(webkit): fix mac build after latest roll (#4455) 2020-11-16 14:25:58 -08:00
Yury Semikhatsky
bd76e9ddbf
browser(webkit): roll to 11-16 (#4451) 2020-11-16 13:02:55 -08:00
Dmitry Gozman
9e1b26f9f9
browser(webkit): close on pipe disconnect (#4421) 2020-11-13 10:02:37 -08:00
Yury Semikhatsky
8f7286175e
browser(webkit): roll to 11-12 (#4417) 2020-11-12 11:10:42 -08:00
Yury Semikhatsky
508be0d78f
browser(webkit): fix big sur crashes after latest roll (#4391) 2020-11-09 22:29:52 -08:00
Yury Semikhatsky
bd75fb1c55
browser(webkit): roll to 11-09 (#4384) 2020-11-09 11:30:12 -08:00
Joel Einbinder
d4fb159154
browser(webkit): fix webcontent startup crash on macos 11 (#4370)
reverts #4357 and provides the real fix. Apple accidentally landed some code that will crash the web process if it is not signed by them. I'm sure they will figure it out once they get test bots for macos 11. But until then, we can just revert.

https://bugs.webkit.org/show_bug.cgi?id=218342
2020-11-06 11:11:19 -08:00
Yury Semikhatsky
49e4d9a347
browser(webkit): force rebuild with new redistributable dlls (#4364) 2020-11-05 17:51:28 -08:00
Yury Semikhatsky
040f9b04ca
browser(webkit): copy MS VC++ redistributable libs from VS installation (#4360) 2020-11-05 16:51:42 -08:00
Andrey Lushnikov
bc20bfd4cc
browser(webkit): disable cache compiled sandbox (#4357)
This seems to be broken on BigSur.
2020-11-05 09:25:36 -08:00
Yury Semikhatsky
890add98fe
browser(webkit): do not hang on close when there is a dialog (#4332) 2020-11-03 18:58:57 -08:00
Yury Semikhatsky
031f0bf539
browser(webkit): fix mac build failure caused by touch events (#4330) 2020-11-03 16:21:42 -08:00
Yury Semikhatsky
c6b4263e54
browser(webkit): fix timezone overrides after last roll (#4329) 2020-11-03 14:54:28 -08:00
Pavel Feldman
eae3d93a20
browser(webkit): fix proxy ignore pattern set on context level (#4328) 2020-11-03 14:28:04 -08:00
Yury Semikhatsky
0a9fdc4751
browser(webkit): roll to 11-03 (#4325) 2020-11-03 13:17:03 -08:00
Yury Semikhatsky
7ef1533cae
browser(webkit): one more mac build fix after last roll (#4298) 2020-10-30 16:15:53 -07:00
Yury Semikhatsky
3577e637c7
browser(webkit): mac build fix after last roll (#4296) 2020-10-30 14:47:53 -07:00
Yury Semikhatsky
5e50fe3d40
browser(webkit): roll to 10-30 (#4294) 2020-10-30 12:42:33 -07:00
Yury Semikhatsky
41d514dfde
browser(webkit): disable gamepad on GTK (#4264) 2020-10-27 16:43:26 -07:00
Pavel Feldman
00d6313f6d
browser(webkit): report raw request headers from didReceiveResponse (#4250) 2020-10-26 22:05:43 -07:00
Andrey Lushnikov
b08d3dc9ff
devops: always ensure linux deps when building webkit (#4249) 2020-10-26 21:53:27 -07:00
Yury Semikhatsky
39637a4ab0
browser(webkit): build fix (#4247) 2020-10-26 18:52:25 -07:00
Yury Semikhatsky
1feb041086
browser(webkit): fix mac build after last roll (#4245) 2020-10-26 17:40:31 -07:00
Pavel Feldman
c1a64eee02
browser(webkit): serialize set-cookie \n-separated (#4243) 2020-10-26 16:58:40 -07:00
Yury Semikhatsky
4b2a29e23d
browser(webkit): roll to 10-26 (#4241) 2020-10-26 13:00:15 -07:00
Yury Semikhatsky
54e05ac83e
browser(webkit): fix screencast timescale precision (#4195) 2020-10-20 13:09:24 -07:00
Joel Einbinder
bf491f12cf
browser(webkit): fix pointer media query on windows (#4176) 2020-10-19 10:08:02 -07:00
Yury Semikhatsky
92cde6cd06
browser(webkit): roll to 10-19 (#4177)
This should fix current build failure on Mac.

5e1333ea77 is necessary to fix the following compilation error:

CMake Error at Source/cmake/WebKitFeatures.cmake:21 (message):
  ENABLE_LEGACY_CSS_VENDOR_PREFIXES is not a valid WebKit option
Call Stack (most recent call first):
  Source/cmake/WebKitFeatures.cmake:40 (_ENSURE_IS_WEBKIT_OPTION)
  Source/cmake/OptionsWPE.cmake:89 (WEBKIT_OPTION_DEFAULT_PORT_VALUE)
  Source/cmake/WebKitCommon.cmake:58 (include)
  CMakeLists.txt:173 (include)
2020-10-19 09:17:24 -07:00
Joel Einbinder
347dd2403b
browser(webkit): fix pointer media query on mac (#4155) 2020-10-19 02:34:47 -07:00
Pavel Feldman
26442c563c
browser(webkit): fix the datastore leak (#4163) 2020-10-16 08:14:59 -07:00
Yury Semikhatsky
97cb51f3e9
browser(webkit): fix windows compilation after last roll (#4162) 2020-10-15 14:27:02 -07:00
Yury Semikhatsky
6fb6929e36
browser(webkit): roll to 10-15 (#4161) 2020-10-15 13:48:58 -07:00
Joel Einbinder
a61d07a8e9
browser(webkit): report correct pointer type to css (#3936) 2020-10-15 03:28:45 -07:00
Joel Einbinder
a169cb63f8
browser(webkit): fix mac compilation errors (#4139) 2020-10-14 10:35:45 -07:00
Joel Einbinder
8c6a2e197a
browser(webkit): Input.dispatchTapEvent (#4102) 2020-10-14 05:53:07 -07:00
Yury Semikhatsky
71c444c59f
browser(webkit): revert changes to WebAutomationSession.h (#4128) 2020-10-13 11:43:42 -07:00
Yury Semikhatsky
b2f4fa914a
browser(webkit): pick process pool for service worker from correct context (#4116) 2020-10-12 15:39:49 -07:00
Yury Semikhatsky
5648eac063
browser(webkit): fix mac build after last roll (#4108) 2020-10-09 16:11:50 -07:00
Yury Semikhatsky
db744e28ee
browser(webkit): roll to 10/08 (#4106) 2020-10-09 14:43:36 -07:00
Yury Semikhatsky
b85ba62291
browser(webkit): actually fix mac compilation (#4105) 2020-10-09 13:06:25 -07:00
Yury Semikhatsky
d6a198a9bb
browser(webkit): speculative build fix for Mac (#4104) 2020-10-09 11:13:02 -07:00
Yury Semikhatsky
8252eb7413
browser(webkit): roll to 09-27 (#4103) 2020-10-09 09:32:36 -07:00
Yury Semikhatsky
c4a2732515
browser(webkit): another mac fix (#3948) 2020-09-21 19:03:44 -07:00
Yury Semikhatsky
ce51af0509
brower(webkit): add missing override markers (#3947) 2020-09-21 17:59:11 -07:00
Yury Semikhatsky
2fbe767142
browser(webkit): roll to 09/21 (#3945) 2020-09-21 16:04:38 -07:00
Yury Semikhatsky
b8e90a5582
browser(webkit): duplicate each frame duration times (#3856) 2020-09-11 13:48:39 -07:00
Yury Semikhatsky
a5a563659b
browser(webkit): fix basic screencast for accelerated compositing on win (#3803) 2020-09-08 16:00:51 -07:00
Yury Semikhatsky
1d4601b479
browser(webkit): fix screencast scale on Mac headful (#3797) 2020-09-08 14:22:33 -07:00
Pavel Feldman
b6557b9f92
browser(webkit): remove incognito emoji from title (#3765) 2020-09-03 23:33:43 -07:00
Yury Semikhatsky
fc7b065b1b
browser(webkit): revert #3360 as it broke many sites (#3764) 2020-09-03 22:09:20 -07:00
Yury Semikhatsky
d3c677792c
browser(webkit): force repaint on screencast start (#3757) 2020-09-03 09:56:21 -07:00
Yury Semikhatsky
6b085a349c
browser(webkit): do not clear existing contexts from map when exiting (#3750) 2020-09-02 18:13:03 -07:00
Pavel Feldman
76ab82faa7
browser(webkit): prepend http:// to the schema-less URLs (#3713) 2020-09-01 14:28:21 -07:00
Yury Semikhatsky
fad840d88d
browser(webkit): fit screencast to frame if no scale is specified (#3707) 2020-09-01 12:04:46 -07:00
Carlos Alberto Lopez Perez
19f21b1bde
browser(webkit): use webkit generate-bundle tool to generate the bundles (#3563)
* This changes the archive.sh script to use the webkit generate-bundle
 tool to generate the MiniBrowser bundles instead of using our custom
 logic.

 * pw_run.sh is simplified because the new bundles include a wrapper
 script that sets the needed LD_LIBRARY_PATH environment variables.
 pw_run.sh now calls this wrapper script (for GTK or WPE) instead of
 calling the MiniBrowser binary directly when running from a bundle.

Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
2020-08-28 10:48:57 -07:00
Yury Semikhatsky
80cf7e9fac
browser(webkit): do not crash when opening web inspector (#3631) 2020-08-26 08:55:18 -07:00
Yury Semikhatsky
1a37f8ba7a
browser(webkit): remove browserContextId from some events (#3628) 2020-08-25 17:15:21 -07:00
Yury Semikhatsky
14abee2b00
browser(webkit): fix compilation on mac (#3619) 2020-08-25 07:54:05 -07:00
Yury Semikhatsky
db7bec36c5
browser(webkit): introduce screencastFinished event on Context (#3611) 2020-08-24 19:59:35 -07:00
Yury Semikhatsky
1c6968269a
browser(webkit): avoid use after free on page close (#3599) 2020-08-24 10:38:39 -07:00
Yury Semikhatsky
4f1f972143
browser(webkit): fix mac compilation (#3598) 2020-08-24 08:56:33 -07:00
Yury Semikhatsky
93d8839947
browser(webkit): explicitly track pages reported for context (#3574) 2020-08-21 19:59:53 -07:00
Carlos Alberto Lopez Perez
de5ecc028f
browser(webkit): roll to r266002 08/21/2020 (#3561) 2020-08-21 09:56:10 -07:00
Yury Semikhatsky
ae5700b3f3
browser(webkit): do not crop video on Mac headless (#3457) 2020-08-13 16:50:22 -07:00
Yury Semikhatsky
f25449892c
browser(webkit): align GTK implementation with Win (#3377) 2020-08-10 17:11:24 -07:00
Yury Semikhatsky
89ae8e0fd1
browser(webkit): disable accelerated compositing on Windows (#3360) 2020-08-10 08:29:16 -07:00
Yury Semikhatsky
ddd483bdf0
browser(webkit): correctly record video in headless mode Windows (#3354) 2020-08-07 15:27:38 -07:00
Andrey Lushnikov
434b9e107e
devops: support EXPORT_COMPILE_COMMANDS env variable in webkit build.sh (#3334)
We'll use this variable to power kodsearch.
2020-08-06 16:33:34 -07:00
Yury Semikhatsky
8881a521c1
browser(webkit): roll to 8/4 (#3289) 2020-08-04 13:33:32 -07:00
Yury Semikhatsky
bad4005d7d
chore(devops): do not copy pw_run.sh to subfolders (#3271) 2020-08-03 12:01:57 -07:00
Yury Semikhatsky
f62e9b5dc0
browser(webkit): kick-off 1321 build to pick up new WebKitLibraries/win (#3263) 2020-07-31 16:36:39 -07:00
Yury Semikhatsky
c6180edbfe
browser(webkit): print missing dll error to the console (#3214) 2020-07-29 15:01:01 -07:00
Yury Semikhatsky
90ff66710b
browser(webkit): disable high DPI support in Web Process on Windows (#3160) 2020-07-24 16:19:14 -07:00
Yury Semikhatsky
3162c06f49
browser(webkit): outerWidth/Height on Windows (#3154) 2020-07-24 14:10:32 -07:00
Andrey Lushnikov
678d16454a
devops: normalize blob names on the CDN (#3136)
This establishes a single naming for all our blobs with browser
builds that we upload to CDN: `<browser-name>-<os-version>`

- `<browser-name>` is either `firefox` or `webkit`.
- `os-version` is the OS that was used to produce the build.

References #2745
2020-07-24 00:31:18 -07:00
Andrey Lushnikov
ae574b302f
devops: fix webkit build on ubuntu (#3134)
Sometimes we actually pass one empty argument.
2020-07-23 16:59:45 -07:00
Yury Semikhatsky
74941340be
browser(webkit): correctly report outerWidth/Height on Mac (#3131) 2020-07-23 16:16:31 -07:00
Andrey Lushnikov
c1032ae483
devops: simplify building webkit on linux bots (#3127)
Originally there was no way to build both webkit-gtk and webkit-wpe
in the same checkout. As a result, we were:
- building webkit-gtk & uploading it to CDN
- building webkit-wpe & uploading it to CDN
- downloading webkit-gtk & webkit-wpe from CDN and compiling a single
webkit-gtk-wpe folder that we uploaded to CDN

As of today, however, we can build WPE and GTK ports together. This
patch starts using this to drastically simplify build process:
- build webkit-gtk and webkit-wpe
- use `archive.sh` script that compiles a single folder with both ports
- upload archive to the cloud

This should also fix currently failing webkit build that fails to
assemble the `webkit-gtk-wpe` folder (I missed these codepaths while preparing
for Ubuntu-20.04 bot).

References #2745
2020-07-23 15:57:53 -07:00
Andrey Lushnikov
63689e36a6
devops: prepare buildbots to the introduction of Ubuntu 20.04 builder (#3116)
This patch:
- specializes "linux" scripts into "Ubuntu 18.04" scripts
- renames all future linux blobs on CDN:
    * `firefox-linux.zip => firefox-ubuntu-18.04.zip`
    * `minibrowser-gtk.zip => minibrowser-gtk-ubuntu-18.04.zip`
    * `minibrowser-wpe.zip => minibrowser-wpe-ubuntu-18.04.zip`
    * `minibrowser-gtk-wpe.zip => minibrowser-gtk-wpe-ubuntu-18.04.zip`
- updates downloader to deal with the new names

References #2745
2020-07-23 11:59:23 -07:00
Yury Semikhatsky
c895c972ae
browser(webkit): kick-off build for #3100 (#3113) 2020-07-23 09:32:22 -07:00
Yury Semikhatsky
1cfba7f582
browser(webkit): periodically capture frames on mac regardless of updates 2020-07-22 23:38:48 -07:00
Yury Semikhatsky
26c57846bb
Rebase (#3096) 2020-07-22 23:34:52 -07:00
Pavel Feldman
b271624fcb
browser(webkit): hardcode woff enabled on win (#3103) 2020-07-22 20:46:00 -07:00
Yury Semikhatsky
f751ab1791
browser(webkit): write screencast video to .webm instead of .ivf (#3081) 2020-07-21 18:49:52 -07:00
Pavel Feldman
de9570ee3a
browser(webkit): roll to ToT 07/21/2020 (#3066) 2020-07-21 12:26:21 -07:00
Yury Semikhatsky
eb14c4711f
browser(webkit): do not mask WebGL vendor/renderer info (#3050) 2020-07-20 15:01:40 -07:00
Yury Semikhatsky
1896e8edc0
browser(webkit): send Playwright.pageProxyDestroyed for crashed tabs when deleting context (#2986) 2020-07-16 15:42:07 -07:00
Yury Semikhatsky
31893036e8
browser(webkit): close crashed pages on exit (#2958) 2020-07-15 11:04:13 -07:00
Carlos Alberto Lopez Perez
cb8b1bca97
browser(webkit): Reduce binary size of WebKit Linux build bundles (GTK and WPE) (#2880)
This patch changes the build system to use the JHBuild minimal dependency
system introduced in WebKit r264092 <https://trac.webkit.org/r264092>

The build has been tested with Ubuntu-18.04

The binary size of the zip bundles is now: 37M (WPE) and 40M (GTK).
Previously it was 54M and 59M (respectively)
2020-07-09 11:37:13 -07:00
Yury Semikhatsky
f5911de93d
browser(webkit): release GTK app only if it has been referenced (#2885) 2020-07-08 16:13:58 -07:00
Yury Semikhatsky
83bba08cc4
browser(webkit): fix touch events on mac after last roll (#2884) 2020-07-08 14:32:39 -07:00
Yury Semikhatsky
64f57216e2
browser(webkit): roll to 07-07-2020 (#2863) 2020-07-07 13:03:07 -07:00
Yury Semikhatsky
ea9b82d225
browser(webkit): properly disconnect signal handlers when closing browser (#2849) 2020-07-06 13:59:13 -07:00
Andrey Lushnikov
3dd09f04ef
browser(webkit): close context menu on Windows when closing page (#2825)
Review URL: 358fd983a9
2020-07-02 15:21:12 -07:00
Andrey Lushnikov
b1b6d3f531
devops: add signature to BUILD_NUMBER to force rebaseline (#2810)
Currently, it might happen that two different patches clash for the
same build number for the browsers. In this case, authors might
not even know that they need to rebaseline.

This patch starts adding a second line to `BUILD_NUMBER` files - the
signature and date of the `BUILD_NUMBER` change. These are guaranteed
to clash, so it should not be possible to land patches without
re-baselining them.
2020-07-02 12:09:27 -07:00
Joel Einbinder
3d403cb2cd
browser(webkit): force wpe to use the complex text path (#2801) 2020-07-02 10:04:10 -07:00
Andrey Lushnikov
43cdb3ba72
browser(webkit): revert #2755 (#2809)
Review URL: 7d35d22798

This reverts https://github.com/microsoft/playwright/pull/2755/files
Reason:
- it doesn't compile on Windows

References #2699
2020-07-01 22:40:33 -07:00
Andrey Lushnikov
14162f8923
browser(webkit): let web page close when it has open context menu (#2802)
Review URL: 42f86e9d77

Currently, if web page has an open context menu, then it won't close.
This prevents browser from quitting.

In stock safari, this behavior can also be observed in a way that
context menu will stay opened even if related page got closed.

While investigating this behavior on Mac, a crucial observation was
that `[NSMenu popUpContextMenu]` is spawning a nested event loop,
keeping reference to `WebContextMenuProxyMac` instance, which in turn
keeps references on associated `NSView` with `WKWebView`.

To exit the loop, we need to explicitly cancel context menu. For this,
this patch adds a method `hide` on `WebContextMenuProxy` that uses
port-specific code to cancel context menu.

Windows part of this patch is somewhat speculative: I didn't check
it, but given the same symptomps, I applied the same solution.

Fixes #2700
2020-07-01 18:12:11 -07:00
Dmitry Gozman
c188118d3a
browser(webkit): do not show popup menu in mac headless (#2803) 2020-07-01 17:52:25 -07:00
Joel Einbinder
cd180474ee
browser(webkit): don't show context menus for headless windows (#2755) 2020-07-01 06:50:08 -07:00
Yury Semikhatsky
d6338b0cae
docs(webkit): update core dump analisys instructions (#2778) 2020-06-30 17:00:16 -07:00
Yury Semikhatsky
c6df8fd507
browser(webkit): abort interception if loader reached termial state (#2776) 2020-06-30 16:47:10 -07:00
Yury Semikhatsky
924a884102
docs: linux core dump instructions (#2690) 2020-06-24 10:04:11 -07:00
Yury Semikhatsky
40b1a14626
browser(webkit): support screencast scale on Mac (#2655) 2020-06-22 14:40:46 -07:00