Commit Graph

15 Commits

Author SHA1 Message Date
Patrick Shaw
6e78dcb7dc
fix: Allow portable bash paths for systems including NixOS (#23889)
Although very common, bash is not guaranteed to be located at
`/bin/bash`. NixOS is an example of this.

More commonly, `/bin/bash` can be quite out of date. An example of this
is MacOS's version of `bash`. This realistically won't affect Playwright
but it's worth noting. You can technically update MacOS's system version
of bash but you need elevated permissions to do so.

By using `/usr/bin/env bash` instead of `/bin/bash` we can execute
Playwright's bash scripts in like NixOS and generally improve the
selection behaviour for bash in other systems too.

Some discussion of why it's worth favouring `/usr/bin/env bash` over
`/bin/bash`:
- Discusses `/bin/bash` missing in NixOS:
https://discourse.nixos.org/t/add-bin-bash-to-avoid-unnecessary-pain/5673
- Some general commentary on why `/usr/bin/env bash` is favoured:
https://askubuntu.com/a/1402721
- Points out how old bash is in MacOS:
https://itnext.io/upgrading-bash-on-macos-7138bd1066ba

Improves situation at #5501
2023-07-03 06:27:06 -07:00
Andrey Lushnikov
ff3275eb3e
chore: add report UUID (#22785) 2023-05-03 05:58:16 -07:00
Max Schmitt
490513a017
devops: update repo for internal tests 2022-10-30 21:33:30 -07:00
Pavel Feldman
c81af6b2bd
chore: generalize branch name attr (#17898) 2022-10-06 21:58:30 -07:00
Pavel Feldman
854c783019
chore: project.id, configFile in reporter apis (#17346) 2022-09-14 14:56:28 -07:00
Andrey Lushnikov
462fa7d79d
devops: upload reports to a new container (#17298)
This patch:
- adds `gitBranchName` to the infra metadata to the report
- starts uploading persistent reports to a different container, prefixed
with utc year-month-date.
2022-09-13 10:55:39 -07:00
Andrey Lushnikov
b07636d5a7
devops: fix flakiness dashboard (#13997)
These fields are crucial for report processing.
2022-05-06 10:58:15 -07:00
Andrey Lushnikov
0dd8ab9c6d
devops: more compact commits for the flakiness dashboard (#13912)
- do not collect commit info since we don't use
- do not store CI plugin information
- do not store test timings
2022-05-04 09:43:07 -07:00
Max Schmitt
5ba7903ba0
devops: migrate from master to main branch (#10303) 2021-12-07 22:58:33 -08:00
Andrey Lushnikov
2c34eaeaf9
devops: better upload flakiness dashboard upload script (#6176)
This patch moves some duplicated logic from YAML workflows to
the dashboard uploading script.
2021-04-19 08:39:10 -07:00
Andrey Lushnikov
5358fed49a chore: fix typo 2021-01-27 20:56:46 +03:00
Andrey Lushnikov
a4f59dd57c
devops: upload host arch as part of test report (#5167) 2021-01-27 09:05:31 -08:00
Andrey Lushnikov
51f8f23c5d
devops(flakiness): collect more commit information (#4315)
Collect commit title and author details.
2020-11-02 18:28:03 -08:00
Andrey Lushnikov
86e1e3f3fe
devops: collect host os name and version (#4244)
Our test annotations don't provide (and don't require) a fine-grained
information regarding ubuntu version, so we collect it separately.
2020-10-26 16:44:32 -07:00
Andrey Lushnikov
d5fbe3a662
devops: start uploading test reports to flakiness dashboard (#4239) 2020-10-26 13:46:26 -07:00