Commit Graph

5 Commits

Author SHA1 Message Date
Andrey Lushnikov
32ff5a7e10 devops(circleci): properly run all tests 2020-04-13 19:18:54 -07:00
Andrey Lushnikov
f5ecbff16e
devops: remake downloading logic (#1419)
This patch:
- removes `browserType.downloadBrowserIfNeeded()` method. The method
  turned out to be ill-behaving and cannot not be used as we'd like to (see #1085)
- adds a `browserType.setExecutablePath` method to set a browser
  exectuable.

With this patch, we take the following approach towards managing browser downloads:
- `playwright-core` doesn't download any browsers. In `playwright-core`, `playwright.chromium.executablePath()` returns `null` (same for firefox and webkit).
- clients of `playwright-core` (e.g. `playwright` and others) download browsers one way or another.
They can then configure `playwright` with executable paths and re-export the `playwright` object to their clients.
- `playwright`, `playwright-firefox`, `playwright-chromium` and `playwright-webkit` download 
browsers. Once browsers are downloaded, their executable paths are saved to a `.downloaded-browsers.json` file. This file is read in `playwright/index.js` to configure browser executable paths and re-export the API.
- special case is `install-from-github.js` that also cleans up old browsers.
2020-03-19 11:43:35 -07:00
Andrey Lushnikov
a11e8f013f devops(circleci): run all tests on all browsers 2020-03-12 18:25:07 -07:00
Andrey Lushnikov
2711891e04 chore(ci): use bionic image on circle ci 2020-03-02 19:04:45 -08:00
Andrey Lushnikov
bccdaec8b4
chore(ci): add circle ci (#1188) 2020-03-02 18:34:24 -08:00