microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 05:37:20 +03:00
Code Issues Projects Releases Wiki Activity
11,856 Commits 32 Branches 139 Tags 213 MiB
edf369ea3c
Commit Graph

3769 Commits

Author SHA1 Message Date
Pavel Feldman
d242ff67ef
chore: follow up to the stylePath review (#28636) 2023-12-14 08:19:24 -08:00
Max Schmitt
e8c8852c00
chore: discourage methods on ElementHandle (#28637) 
Mirrors the deprecations from page.* over to ElementHandle.
 2023-12-13 20:06:01 -08:00
Yury Semikhatsky
e31e5b1b7c
fix: use blob fileName as is without adding shard suffix (#28634) 
Fixes https://github.com/microsoft/playwright/issues/27284
 2023-12-13 18:47:13 -08:00
Max Schmitt
9b2585cd4e
fix: 'should collect trace with resources, but no js' test in service mode (#28628) 2023-12-13 11:42:29 -08:00
Yury Semikhatsky
9d91b7caf5
fix(route): silently catch errors when handling route on server (#28612) 
This is a follow-up to 119afdf788 Since
continue/fulfill/abort now may throw on the server after page has been
closed, we need to catch the errors manually. On the client it's fixed
by the original change.

This fixes errors in the existing tests:
```
  1) [chromium] › library/browsercontext-route.spec.ts:172:3 › should support Set-Cookie header ────

    Error: 

       at ../packages/playwright-core/src/server/chromium/crConnection.ts:147

      145 |     const id = this._connection._rawSend(this._sessionId, method, params);
      146 |     return new Promise((resolve, reject) => {
    > 147 |       this._callbacks.set(id, { resolve, reject, error: new ProtocolError('error', method) });
          |                                                         ^
      148 |     });
      149 |   }
      150 |

        at /Users/yurys/playwright/packages/playwright-core/src/server/chromium/crConnection.ts:147:57
        at new Promise (<anonymous>)
        at CRSession.send (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crConnection.ts:146:12)
        at RouteImpl.continue (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crNetworkManager.ts:566:25)
        at FrameManager.requestStarted (/Users/yurys/playwright/packages/playwright-core/src/server/frames.ts:299:23)
        at CRNetworkManager._onRequest (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crNetworkManager.ts:314:57)
        at CRNetworkManager._onRequestPaused (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crNetworkManager.ts:202:12)
        at CRSession.emit (node:events:517:28)
        at /Users/yurys/playwright/packages/playwright-core/src/server/chromium/crConnection.ts:172:14
        at runNextTicks (node:internal/process/task_queues:60:5)
        at processImmediate (node:internal/timers:447:9)
```


![image](https://github.com/microsoft/playwright/assets/9798949/1c436dc2-f113-4ba6-952c-dca5a8c5fa62)

Reference https://github.com/microsoft/playwright/issues/28490
 2023-12-13 09:34:20 -08:00
Pavel Feldman
afe90d648e
fix: do not generate api call steps inside named expects (#28609) 
Fixes: https://github.com/microsoft/playwright/issues/28528
 2023-12-13 09:06:02 -08:00
Max Schmitt
297cfdfc5f
chore: use ReadonlyArray for input parameters (#28564) 2023-12-12 16:22:48 -08:00
Dmitry Gozman
d2dc8eb1e3
fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
Yury Semikhatsky
66e056c306
fix: disable PaintHolding to be able to click in oopifs (#28604) 
Fixes https://github.com/microsoft/playwright/issues/28023
 2023-12-12 12:20:44 -08:00
Playwright Service
af5a23e55f
feat(chromium-tip-of-tree): roll to r1175 (#28605) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-12-12 11:27:51 -08:00
Dmitry Gozman
10dda30c7f
fix(reporters): carefully handle empty lines (#28591) 
In some circumstances, like "No tests found" error, reporters produce a
lot of unnecessary empty lines:

```
$ npx playwright test
Error: No tests found




$ <next command>
```

Also, `line` reporter removes the `npx playwright test` command entirely
when `onError` happens before `onBegin`.
 2023-12-11 21:18:48 -08:00
Playwright Service
d20a20b9b6
feat(webkit): roll to r1954 (#28592) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-12-11 18:42:34 -08:00
Pavel Feldman
76ace0fc09
chore: workaround webkit screenshot animation issue (#28582) 2023-12-11 18:20:24 -08:00
Dmitry Gozman
ac3600ec96
feat: explain that argument is a regex (#28590) 
- in docs;
- in the error message.

Terminal output:

```
$ npx playwright test foobar
Error: No tests found.
Make sure that arguments are regular expressions matching test files.
You may need to escape symbols like "$" or "*" and quote the arguments.
```

References #28551.
 2023-12-11 17:35:39 -08:00
Dmitry Gozman
ee9a7dad12
docs: emphasize that has is a relative locator (#28588) 
References #28556.
 2023-12-11 17:35:29 -08:00
Playwright Service
23415da3db
feat(webkit): roll to r1953 (#28574) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-12-11 09:30:11 -08:00
Playwright Service
7827838d22
feat(chromium): roll to r1094 (#28560) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-12-08 14:59:38 -08:00
Playwright Service
a01ef0e9ce
feat(chromium-tip-of-tree): roll to r1174 (#28559) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-12-08 14:58:03 -08:00
Andrey Lushnikov
8d3a931377
feat(firefox): roll FF Stable & Beta to 1433 (#28543) 
Fixes #28495
 2023-12-08 10:48:44 -08:00
Max Schmitt
736c0efd43
chore: use more explicit awaits when returning in client (#28443) 2023-12-07 20:13:35 -08:00
Yury Semikhatsky
119afdf788
fix: throw if fuliflled with unsupported status code (#28539) 
If request gets cancelled by the page before we fulfill it, we receive
`loadingFailed` event. In that case we'll ignore interception error if
any, otherwise the error will be propagated to the caller.

Fixes https://github.com/microsoft/playwright/issues/28490
 2023-12-07 16:57:39 -08:00
Dmitry Gozman
d587435efa
feat(trace): show target point for raw mouse apis (#28459) 
Fixes #27931.
 2023-12-07 06:27:49 -08:00
Yury Semikhatsky
411abdb752
feat: add fileName option to blob reporter (#28525) 
Reference https://github.com/microsoft/playwright/issues/27284
 2023-12-06 20:44:06 -08:00
Max Schmitt
2d2c270388
chore: mark outofprocess connection not as remote (#28156) 2023-12-06 17:58:19 -08:00
Yury Semikhatsky
f88288d71d
feat: config.botName for describing environment in the reports (#28507) 
Reference https://github.com/microsoft/playwright/issues/27284
 2023-12-06 13:34:16 -08:00
Playwright Service
29a0ea35d0
feat(firefox-beta): roll to r1430 (#28509) 2023-12-05 22:30:37 -08:00
dependabot[bot]
6838484ab5
chore(deps): bump vite from 4.4.10 to 4.4.12 (#28505) 2023-12-05 16:52:41 -08:00
Playwright Service
4b968412c9
feat(firefox): roll to r1430 (#28489) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-12-05 13:00:30 -08:00
Max Schmitt
524ed3e269
fix(electron): after v28.0 (#28499) 
Fixes https://github.com/microsoft/playwright/issues/28048
Relates https://github.com/electron/electron/issues/40501
 2023-12-05 12:46:28 -08:00
Playwright Service
aadc9345fa
feat(webkit): roll to r1951 (#28498) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-12-05 12:28:24 -08:00
Yury Semikhatsky
8f056fbbce
chore: do not wait for route on close if route.continue() threw an error (#28487) 
Reference https://github.com/microsoft/playwright/issues/23781
 2023-12-05 10:26:17 -08:00
Dmitry Gozman
c7018951e5
fix(trace): title should not wrap over to the timeline (#28496) 2023-12-05 09:21:51 -08:00
Yury Semikhatsky
74e51d334e
feat: wait for active route handlers on page/context close (#28414) 
Reference https://github.com/microsoft/playwright/issues/23781
 2023-12-04 16:19:05 -08:00
Yury Semikhatsky
ab68d7b9de
fix(webkit): delay request event until requestIntercepted is received (#28484) 
Previously we were wrongly firing `route` event for the request which
are not in fact intercepted (e.g. requests from service worker).

Related https://github.com/microsoft/playwright/pull/28414
Reference https://github.com/microsoft/playwright/issues/23781
 2023-12-04 13:02:00 -08:00
Yury Semikhatsky
9a95d9a60c
chore: remove unused request._redirectedFrom (#28485) 2023-12-04 12:38:07 -08:00
Pavel Feldman
facec88c99
fix: speed up caret hiding while screenshotting (#28460) 
Fixes #28375
 2023-12-03 21:06:40 -08:00
Playwright Service
ea7fe340c1
feat(webkit): roll to r1950 (#28469) 2023-12-03 04:54:45 -08:00
Yury Semikhatsky
607a243380
chore: remove unused fields from wk network (#28455) 2023-12-01 14:51:41 -08:00
Yury Semikhatsky
b166189247
fix: disable memory cache when intercepting in webkit (#28458) 2023-12-01 14:49:27 -08:00
Max Schmitt
f44ef81af7
fix(snapshot): broken snapshot after use of setInputFiles (#28444) 2023-12-01 09:38:50 -08:00
Pavel Feldman
0a7a10d0f6
feat(vrt): allow providing screenshot style (#28229) 2023-11-30 17:42:45 -08:00
Max Schmitt
8efa8dbc1d
fix(ui-mode): make UI Mode projects scrollable (#28438) 
Fixes https://github.com/microsoft/playwright/issues/28393



https://github.com/microsoft/playwright/assets/17984549/5791e422-f4e6-4202-b66c-b77bbb476c04
 2023-11-30 13:26:03 -08:00
Playwright Service
f21455017e
feat(chromium-tip-of-tree): roll to r1173 (#28422) 2023-11-30 05:41:58 -08:00
Playwright Service
b06f9ab055
feat(chromium): roll to r1093 (#28421) 2023-11-30 05:41:23 -08:00
Pavel Feldman
92a0d24069
fix: restore timeout error name (#28408) 
Fixes https://github.com/microsoft/playwright/issues/28404
 2023-11-29 17:28:17 -08:00
Max Schmitt
c137b23a6c
fix(trace-viewer): scroll over multiple pages (#28316) 
Fixes https://github.com/microsoft/playwright/issues/28208
 2023-11-29 11:27:19 -08:00
Playwright Service
1901a1a155
feat(chromium-tip-of-tree): roll to r1172 (#28374) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-28 19:45:12 -08:00
Yury Semikhatsky
15a8ba5158
fix(route): correctly remove expired handlers (#28385) 
* Check if handler is still in the route list before calling it
* Check if the handler is still in the list before removing it after
`times` expiration
 2023-11-28 17:52:16 -08:00
Yury Semikhatsky
2e762fd3d2
fix: parse report.jsonl without creating large string (#28366) 
Reference https://github.com/microsoft/playwright/issues/28362
 2023-11-28 08:47:44 -08:00
Pavel Feldman
022b36332d
chore: do not add to the internal action logs (#28365) 
Fixes https://github.com/microsoft/playwright/issues/28319
 2023-11-27 16:43:47 -08:00
Yury Semikhatsky
cea28b2df9
docs: clarify beforeAll execution on exception (#28361) 
Reference https://github.com/microsoft/playwright/issues/28285
 2023-11-27 16:37:30 -08:00
Dmitry Gozman
f61e445f2b
Revert "chore(test runner): remove fake skipped test results (#27762)" (#28360) 
This reverts commit 210168e36d.

Fixes #28321.
 2023-11-27 16:08:20 -08:00
Sander
f58c1f37eb
fix(ct): empty slots or children (#28225) 
closes: https://github.com/microsoft/playwright/issues/28212
 2023-11-27 15:53:50 -08:00
Playwright Service
96ce1a8f88
feat(webkit): roll to r1949 (#28358) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-27 21:51:30 +01:00
Alexander Kachkaev
41728e7098
chore(install): Improve ECONNRESET handling in downloadFile (#28344) 
See
https://github.com/microsoft/playwright/issues/28329#issuecomment-1826753106
for context
 2023-11-27 21:44:24 +01:00
Yury Semikhatsky
dc8ecc3ca4
fix(merge): normalize path separators when merging across platforms (#28227) 2023-11-27 12:43:56 -08:00
Playwright Service
888f4965bf
feat(webkit): roll to r1948 (#28323) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-24 09:33:53 +01:00
Playwright Service
7dd121c784
feat(chromium): roll to r1092 (#28312) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-23 16:04:35 +01:00
Playwright Service
4faa0bcbb8
feat(chromium-tip-of-tree): roll to r1171 (#28313) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-23 16:04:04 +01:00
Yury Semikhatsky
82f970e5c1
chore: print more accurate MiB instead of Mb when downloading browsers (#28304) 
Fixes https://github.com/microsoft/playwright/issues/28283
 2023-11-23 11:09:38 +01:00
Max Schmitt
2f1b0d6ff7
fix(install): hang on server side connection close (#28278) 2023-11-22 20:26:21 +01:00
Playwright Service
91c5bac52b
feat(chromium-tip-of-tree): roll to r1170 (#28277) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-22 10:15:24 +01:00
Playwright Service
7caa212a1f
feat(webkit): roll to r1947 (#28270) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-21 21:47:26 +01:00
itchyny
440f5e5d2b
fix: collect all errors in removeFolders (#28239) 
This PR fixes
https://github.com/microsoft/playwright/pull/27790#pullrequestreview-1738958803.
Previously this function returns only the first error when some of the
promises fail. But the type annotation suggests that the original
intention was to collect all the errors. This commit fixes the error
values, and unexpected `TypeError: object is not iterable`.
 2023-11-20 10:58:10 +01:00
Pavel Feldman
3f55587dd8
feat(vrt): bring back wait for font loading (#28226) 2023-11-17 17:16:32 -08:00
Yury Semikhatsky
34c8516d09
fix: correctly print number of interrupted tests in markdown (#28228) 2023-11-17 16:53:36 -08:00
Dmitry Gozman
62d4c3fe02
fix(defineConfig): do not add an empty project list to project-less configs (#28224) 
Otherwise, merging two configs without `projects` property will create a
config with an empty project list, which is semantically different and
always leads to "No tests found".
 2023-11-17 13:36:50 -08:00
Dmitry Gozman
5488c03d7f
chore: make asLocator() always safe (#28207) 2023-11-16 16:31:34 -08:00
Dmitry Gozman
738155d85d
fix(dispatcher): only remove stale dispatcher after sending "create" (#28176) 
Otherwise, we might dispose objects referenced in the initializer of the
new object being created, which triggers an exception on the client.
 2023-11-16 15:07:43 -08:00
Dmitry Gozman
61c089fcbd
feat(recorder): UX updates for assertion tools (#28198) 
- No locator editor.
- No value editor for `toHaveValue`.
- Visual feedback for `toBeVisible`/`toHaveValue`.
- UI tweaks.
 2023-11-16 13:19:36 -08:00
Dmitry Gozman
da6707f785
fix(chromium): properly detect session closed errors for oopifs (#28197) 
Exposed by the flaky test `should not throw on exposeFunction when oopif
detaches`.
 2023-11-16 11:44:10 -08:00
Pavel Feldman
2bd7d67adc
chore: render testInfo errors in the Errors tab (#28179) 
Fixes https://github.com/microsoft/playwright/issues/28056
 2023-11-16 11:37:57 -08:00
Playwright Service
3cc1dacd5c
feat(chromium-tip-of-tree): roll to r1169 (#28184) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-16 13:48:03 +01:00
Dmitry Gozman
8150b27413
chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
Pavel Feldman
25b9c4eb4a
chore: do not lose error name for js errors (#28177) 2023-11-15 18:27:32 -08:00
Siddharth Singha Roy
4575c9a182
chore(logs): Add new log level to capture client-server message's metadata information (#28141) 
Goal - Capture minimal diagnostic information for each message being
sent between the playwright client and server.

---------

Co-authored-by: Siddharth Singha Roy <ssingharoy@microsoft.com>
 2023-11-15 15:37:14 -08:00
Max Schmitt
80bab8afae
fix(electron/android): re-add Element.prototype.checkVisibility check (#28173) 
Regressed in https://github.com/microsoft/playwright/pull/28148.
 2023-11-15 15:10:13 -08:00
Playwright Service
0867c3ce5b
feat(chromium): roll to r1091 (#28171) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-15 21:31:01 +01:00
Daniel
1c8ceb0a02
fix(html-reporter): Include specified host and port in the logged instructions to launch the HTML report (#28144) 
Signed-off-by: Daniel <3473356+D4N14L@users.noreply.github.com>
 2023-11-15 21:25:03 +01:00
Max Schmitt
611badcf74
fix: setInputFiles test in driver mode (#28166) 
https://github.com/microsoft/playwright/pull/28156
 2023-11-15 20:09:36 +01:00
Max Schmitt
84d1260d1a
fix(recorder): inspect element when starting typing in locator editor (#28134) 2023-11-15 19:40:10 +01:00
Playwright Service
bb241abaff
feat(webkit): roll to r1944 (#28148) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-11-15 19:34:53 +01:00
Max Schmitt
b66839b039
fix(exposeFunction): exposeFunction should not leak client side BindingCalls (#28163) 
This should already make it a bit better. There is more going on tho.

https://github.com/microsoft/playwright/issues/28146
 2023-11-15 17:15:25 +01:00
Dmitry Gozman
557f3afd74
feat(recorder): assert value as a separate tool (#28145) 2023-11-14 15:17:42 -08:00
Dmitry Gozman
0a052cb4d6
feat(recorder): assert visibility tool (#28142) 2023-11-14 12:55:34 -08:00
Yury Semikhatsky
ec2c7024b6
docs: fix ignoreCase description (#28121) 2023-11-14 10:18:04 -08:00
Max Schmitt
2ac1cde879
fix(recorder): resize of assert overlay textarea (#28137) 2023-11-14 18:07:27 +01:00
Pavel Feldman
60a37f37ef
chore: allow tabbing from codemirror locator editor (#28116) 2023-11-14 08:13:29 -08:00
Playwright Service
78293053b4
feat(chromium-tip-of-tree): roll to r1168 (#28128) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-11-14 14:18:05 +01:00
Dmitry Gozman
bf4c315b09
fix(types): explicit ExpectMatcherState type, optional Expect arg (#28119) 
Fixes #28035.
 2023-11-13 18:37:50 -08:00
Dmitry Gozman
16aee8b5d0
fix(codegen): comment-out generated expects for library scripts (#28118) 
- reverts "fix(codegen): generate expect import for library
(https://github.com/microsoft/playwright/pull/28107)";
- comments-out generated expects.
 2023-11-13 16:56:27 -08:00
Dmitry Gozman
36b99c3437
chore(recorder): standby mode, expose setModeRequested in DebugController (#28117) 2023-11-13 16:39:14 -08:00
Dmitry Gozman
2c3955a28c
chore: remove fake error from expect calls (#28112) 
We used to have a fake `error` property, so that trace viewer shows
failed expectes as such. Today, we have a step for each expect that
contains a proper error. Sending the fake error to the client confuses
language ports.
 2023-11-13 16:39:05 -08:00
Dmitry Gozman
ec4893d235
docs: update phrasing for 1.40 features (#28113) 2023-11-13 15:56:50 -08:00
Pavel Feldman
b0f75a6a3a
chore: allow editing locator while matching text (#28115) 2023-11-13 15:42:46 -08:00
Pavel Feldman
ae5cdf16f0
chore: allow asserting substring (#28111) 2023-11-13 14:38:04 -08:00
Max Schmitt
8b1c637c16
fix(codegen): generate expect import for library (#28107) 2023-11-13 21:54:30 +01:00
Yury Semikhatsky
35aeace476
docs(assertions): note on whitespace normalization (#28110) 
Fixes https://github.com/microsoft/playwright-java/issues/1419
 2023-11-13 12:28:50 -08:00
Pavel Feldman
cd70d51aa8
chore: remove redundant check for highlight liveness (#28108) 
Closes https://github.com/microsoft/playwright/issues/28002
 2023-11-13 11:44:25 -08:00
Pavel Feldman
db38f0d2df
chore: flag text mismatch when editing (#28106) 2023-11-13 11:44:06 -08:00