Commit Graph

993 Commits

Author SHA1 Message Date
Yury Semikhatsky
df4b98464f
browser(webkit): fix mac compilation (#5564) 2021-02-23 14:49:28 -08:00
Yury Semikhatsky
4ae4c3cb01
browser(webkit): fix response.requestHeaders instrumentation in libsoup after latest roll (#5549) 2021-02-22 14:26:08 -08:00
Yury Semikhatsky
8316f41030
browser(webkit): roll to 02-22 (#5547) 2021-02-22 12:47:55 -08:00
Andrey Lushnikov
a891becfba
chore: remove //browser_patches/buildbots folder (#5535)
Since we migrated all our builders/testers to the GitHub self-hosted
runners, we no longer need scripts to operate our own bots.
2021-02-22 09:09:19 -08:00
Andrey Lushnikov
eb3efb3089
fix: do not ship broken symlinks in webkit for mac (#5512)
Since we don't ship things like WebKitPluginAgent, we can
safely remove all the symlinks that point to the missing targets.

Fixes #5472
2021-02-19 21:31:33 -08:00
Andrey Lushnikov
496aeeba79
browser(firefox): follow-up with crash reporter disabling (#5534)
Since we now disable crash reporter compilation and don't ship it
with Firefox anymore, we should not attempt to disable it
with preferences.
2021-02-19 21:30:50 -08:00
Andrey Lushnikov
f10d0a8a58
devops: do not create non-removable folders on windows (#5533)
This fixes a bug where the script was creating a folder with a new line
symbol in its name. As a result, Windows was failing to remove  this
folder, and Chromium Windows BuildBot was failing to even initialize
checkout.
2021-02-19 20:18:23 -08:00
Dmitry Gozman
d6ac3e6883
browser(webkit): honor Set-Cookie header from intercepted requests (mac) (#5529) 2021-02-19 16:28:54 -08:00
Andrey Lushnikov
e2a935b3d6
devops: fix nits in browser compilation infrastructure (#5526)
This patch:
- makes sure that failed runs actually show as failed in GHA
- attempts to use MINGW's `du` and `awk` to get upload size
2021-02-19 14:43:27 -08:00
Andrey Lushnikov
c57f1fc390
devops(chromium): missing depot tools in prepare_checkout.sh script (#5525)
Make sure `prepare_checkout.sh` has depot_tools in its PATH.

Drive-by: enable goma compiler proxy auto-restart.
2021-02-19 14:23:09 -08:00
Andrey Lushnikov
bba9fabfe3
browser(firefox): roll Firefox to beta @ Feb 19, 2021 (#5521) 2021-02-19 13:11:05 -08:00
Andrey Lushnikov
7ed1d88567
browser(chromium): build Chromium Dev revision (#5522) 2021-02-19 13:10:50 -08:00
Andrey Lushnikov
18ce95632f
devops: fix firefox build (#5516) 2021-02-19 10:52:12 -08:00
Andrey Lushnikov
b2d9af5e15
browser(firefox): properly initialize debugging pipe on windows (#5514)
browser(firefox): properly initialize debugging pipe on windows

Firefox on Windows has 2 launch modes:
- default: a special "launcher process" is used to start browser as a
  sub-process
- non-default: browser process starts right away

Firefox has a logic to detect how successful was the use of the
launcher process to do self-recovery when things go wrong. Namely:
- when attempting to use launcher process, firefox records a timestamp
  of the attempt beginning
- once the launcher process successfully launches browser sub-process,
  firefox records another timestamp of the completion

On a new launch, firefox checks what timestamps are present. If there's
a timestamp that signifies start of launcher process, but no successful
timestamp, it decides that last "launcher process" use was not
successful and falls back to launching browser right away.

When launching 2 firefox processes right away, the first process
uses attempts to use launcher process and records the first timestamp.

At the same time, the second instance sees the first timestamp and
doesn't see the second timestamp, and falls back to launching browser
right away. Our debugging pipe code, however, does not support
non-launcher-process code path.

This patch adds support for remote debugging pipe in case of
non-launcher-process startup.

Drive-by:
- disable crashreporter altogether
- remove stray dcheck that breaks firefox debug compilation
- disable compilation of firefox update agent
- do not use WIN32_DISTRIB flag unless doing full builds since
  it kills incremental compilation


References #4660
2021-02-19 10:32:47 -08:00
Joel Einbinder
846fd71121
browser(webkit): fix scrolling in mobile viewports (#5497) 2021-02-18 13:29:17 -08:00
Andrey Lushnikov
8c18b90038
devops: refactor chromium automation scripts (#5486)
Split preparing checkout, archiving and compiling into separate
scripts similarly how we do it with other browsers.
2021-02-17 14:43:19 -08:00
Andrey Lushnikov
4f1d84d6b9
browser(webkit): respect download attribute (#5474)
References #5396
2021-02-16 10:22:19 -08:00
Andrey Lushnikov
027f2ba9e1 devops: enable goma.sh debugging info 2021-02-16 09:34:26 -07:00
Dmitry Gozman
822f7cb1eb
browser(firefox): respect Set-Cookie header from fulfilled request (#5456) 2021-02-15 22:49:57 -08:00
Andrey Lushnikov
2a40d8ec8e
devops: fix goma startup and shutdown (#5447)
Turns out goma scripts have to be called from goma directory.
2021-02-12 11:01:49 -08:00
Andrey Lushnikov
8500592326
devops: fix post-checkout cleanup on windows (#5438)
Turns out empty trailing space in array in bash results in a file
in windows that it fails to remove while during cleanup.
2021-02-12 01:48:11 -08:00
Andrey Lushnikov
539942c803 devops: empty commit to test internal tests 2021-02-12 02:21:39 -07:00
Andrey Lushnikov
2ac93f0a8b devops: another attempt to trigger internal tests (empty commit) 2021-02-12 02:07:22 -07:00
Andrey Lushnikov
17b792bcf5 devops: attempt to trigger internal tests (empty commit) 2021-02-12 02:05:45 -07:00
Andrey Lushnikov
f2a31ad8c5
browser(chromium): build Chromium Dev revision as of Feb 12 (#5435) 2021-02-12 00:32:57 -08:00
Andrey Lushnikov
a42c46b986
browser(firefox): roll Firefox to beta @ Feb 11, 2021 (#5421) 2021-02-11 14:15:26 -08:00
Andrey Lushnikov
44ff8b518b
devops: fix win archiving logic (#5420)
One can't use "for-of" iteration over bash arrays if values
contain strings :(
2021-02-11 08:18:05 -08:00
Andrey Lushnikov
206432cefd devops: fix goma startup on windows 2021-02-09 11:00:53 -07:00
Andrey Lushnikov
db633c4491 devops: fix args.gn syntax with goma 2021-02-09 10:11:03 -07:00
Andrey Lushnikov
32d62a5c2d
devops: fix goma path on windows (#5381)
Convert unix path to win path when running GOMA on windows.
2021-02-09 09:06:50 -08:00
Andrey Lushnikov
909544907c
devops: rename env variable (#5379)
goma searches for all `GOMA_*` env variables and fails if it doesn't
understand any.

To avoid this, rename our `GOMA_LOGIN_COOKIE` env variable into a
`PLAYWRIGHT_GOMA_LOGIN_COOKIE`.
2021-02-09 08:56:29 -08:00
Andrey Lushnikov
d5a51a25b0
devops: fix chromium-win build (#5378)
- add missing build targets
- do not copy *.pdb files in folders
2021-02-09 08:49:59 -08:00
Andrey Lushnikov
ad557dc6da
devops: introduce goma infrastructure for Chromium builds (#5377)
This patch adds `//browser_patches/chromium/goma.sh` script that
manages goma to build chromium.
2021-02-09 08:33:39 -08:00
Andrey Lushnikov
21c24c2357
devops: do not check for logs existance when building browsers (#5367)
In our *old world*, browser buildbots were polling repo and were
trying to rebuild browsers every 5 minutes. They relied on the presence
of either build or build log on the CDN to avoid continiously
re-building.

In the new world, we trigger builds only when we change the
`BUILD_NUMBER` files, so there's no polling any more.

This patch removes the check for log presence so that those builds that
were failing due to misconfiguration (e.g. Visual Studio license
required updated) could be restarted just from the GitHub UI.
2021-02-08 16:19:37 -08:00
Yury Semikhatsky
551338e953
browser(webkit): roll to 02-08 (#5356) 2021-02-08 11:00:05 -08:00
Andrey Lushnikov
3c657cbae6
browser(chromium): roll to r851527 (#5348) 2021-02-08 01:03:30 -08:00
Andrey Lushnikov
f3a5bba2c4
devops: infra to automate chromium builds (#5347) 2021-02-07 23:54:10 -08:00
Joel Einbinder
d1aad632ee
browser(webkit): fix scrolling a second time on linux (#5173) 2021-02-04 12:12:04 -08:00
Andrey Lushnikov
d851bcead7
devops: bundle ffmpeg license file with our archives (#5301)
References #5278
2021-02-03 19:36:10 -08:00
Yury Semikhatsky
509c3e91b4
browser(webkit): fix ubuntu 18 compilation (#5294) 2021-02-03 15:54:54 -08:00
Andrey Lushnikov
bbfbb1b2f7
browser(firefox): fix build on Windows (#5275) 2021-02-03 09:50:35 -08:00
Yury Semikhatsky
9d72d6b625
browser(webkit): roll to 02-03-21 (#5277) 2021-02-03 09:17:21 -08:00
Andrey Lushnikov
985dd5666f devops(chromium): fix chromium linux build 2021-02-03 07:35:29 -07:00
Andrey Lushnikov
8d4dc600f8 devops(firefox): properly cleanup old node.js artifact 2021-02-02 23:59:33 -07:00
Andrey Lushnikov
986bddaecc devops(firefox): fix arm build dependency management 2021-02-02 23:03:54 -07:00
Andrey Lushnikov
11f570be61
devops(firefox): fix Firefox on Apple Silicon (#5272)
As per guide at https://docs.google.com/document/d/1N5yfEVEISofMmjAxfj3xXONGwyQYBSilsfXqux_M6TM/edit
2021-02-02 21:53:23 -08:00
Andrey Lushnikov
b392c57a53
devops: attempt to install Firefox build deps on buildbots (#5271) 2021-02-02 21:35:12 -08:00
Yury Semikhatsky
1ffd654d63
browser(webkit): roll to 02-02-21 (#5263) 2021-02-02 15:20:35 -08:00
Andrey Lushnikov
e53c9c35db
browser(firefox): roll Firefox to beta @ Feb, 1 2021 (#5248) 2021-02-01 15:50:11 -08:00
Andrey Lushnikov
7b5363198b
devops: fix chromium build on Intel MacBook (#5242) 2021-02-01 09:30:04 -08:00
Joel Einbinder
fc405ee8b2
browser(webkit): mac drag and drop (#4994) 2021-02-01 03:30:31 -08:00
Andrey Lushnikov
01bddcd171 devops(chromium): account for terminated / interrupted jobs 2021-01-28 13:15:23 +03:00
Andrey Lushnikov
c9fae65400 devops: fix chromium checkout 2021-01-28 12:56:45 +03:00
Andrey Lushnikov
75a0d7a76b
devops(chromium): install depot_tools if missing (#5204) 2021-01-28 01:43:54 -08:00
Andrey Lushnikov
a7eea9ffdc
browser(chromium): roll Chromium to r846621 (#5203)
This roll should test Chromium compilation for Mac x86_64 and Linux.
2021-01-28 01:19:00 -08:00
Andrey Lushnikov
51d90c593b
devops: support Chromium mac compilation (#5202) 2021-01-28 01:14:44 -08:00
Andrey Lushnikov
b323018881
devops: fetch chromium checkout if it has not been before (#5169)
Checkouts should reside outside of gihtub action working directory
so will be reused between builds.
2021-01-28 00:20:19 -08:00
Andrey Lushnikov
90bc837e55
devops: start compiling Chromium on Linux (#5166) 2021-01-27 08:42:35 -08:00
Dmitry Gozman
77b5f05ef7
browser(webkit): fix scrollIntoViewIfNeeded (#5146)
Last change mistakenly used alignCenterIfNotVisible,
while we should use alignCenterIfNeeded to ensure scrolling
into view when partially visible.
2021-01-25 14:02:16 -08:00
Yury Semikhatsky
7d2293c6ed
browser(webkit): roll to 01-25 (#5141) 2021-01-25 11:27:08 -08:00
Yury Semikhatsky
680689d075
browser(webkit): try to fix Ubuntu 18 build (#5119) 2021-01-22 16:10:01 -08:00
Andrey Lushnikov
b88afe5877
devops: fix chromium for arm build (#5117) 2021-01-23 02:23:59 +03:00
Andrey Lushnikov
546454095e
devops: attempt to fix chromium-mac-arm64 build (#5107)
It looks like gn generation should use correct xcode version as well.
2021-01-22 15:47:24 +03:00
Andrey Lushnikov
2f29c6b066
browser(firefox): roll Firefox to beta Jan, 18 2021 (#5106) 2021-01-22 12:41:12 +03:00
Andrey Lushnikov
2096f4248a
devops: fix chromium compilation step (#5102) 2021-01-22 11:31:26 +03:00
Andrey Lushnikov
ff75073cc8
devops: automation to compile chromium for mac arm64 (#5101)
References #5067
2021-01-22 11:27:40 +03:00
Dmitry Gozman
a7d33b2fec
browser(chromium): roll to 845618 (#5094) 2021-01-21 17:23:19 -08:00
Dmitry Gozman
05568f7420
browser(webkit): change scrollIntoView to only scroll if needed (#5079) 2021-01-20 21:06:29 -08:00
Yury Semikhatsky
449bcdcbf9
browser(webkit): roll to 01-19 (#5064) 2021-01-19 23:18:05 -08:00
Dmitry Gozman
d05c091768
chore: roll chromium to 844399 (#5043) 2021-01-17 12:25:39 -08:00
Yury Semikhatsky
fdfea2b765
browser(webkit): add another missing include to fix mac after roll to 01-15 (#5037) 2021-01-15 18:56:24 -08:00
Yury Semikhatsky
940cf35d84
browser(webkit): add missing include on mac after roll to 01-15 (#5033) 2021-01-15 14:43:48 -08:00
Yury Semikhatsky
0ab6a53212
browser(webkit): roll to 01-15 (#5032) 2021-01-15 12:53:05 -08:00
Pavel Feldman
19b58d47b1
chore: bump chromium to r843427 (#5022) 2021-01-14 15:37:09 -08:00
Andrey Lushnikov
7665a6ec7f
devops: support apple silicon builds of Firefox (#4979) 2021-01-12 03:57:59 +03:00
Joel Einbinder
36650b1e19
browser(webkit): fix compile on mac (#4977) 2021-01-11 14:30:06 -08:00
Yury Semikhatsky
56f012043b
browser(webkit): fix mac compilation after roll to 01-11 (#4972) 2021-01-11 11:30:54 -08:00
Yury Semikhatsky
62c52e8628
browser(webkit): roll to 01-11 (#4971) 2021-01-11 11:00:07 -08:00
Yury Semikhatsky
5854cadd0b
browser(webkit): fix typo in macro name (#4970) 2021-01-11 10:03:45 -08:00
Joel Einbinder
cc1a79eceb
browser(webkit): drag and drop on windows (#4889) 2021-01-06 09:46:35 -08:00
Yury Semikhatsky
2908568f9a
browser(webkit): install new dependency required for openxr on linux (#4906) 2021-01-05 16:05:21 -08:00
Andrey Lushnikov
6b94f5f1b9
browser(firefox): roll Firefox to beta @ Jan 5, 2021 (#4904) 2021-01-06 02:49:28 +03:00
Yury Semikhatsky
5df1c6e560
browser(webkit): roll to 01-05 to pick up upstream Win fix (#4894) 2021-01-05 13:08:52 -08:00
Yury Semikhatsky
849a5b3795
browser(webkit): roll to 01-04 (#4882) 2021-01-05 09:13:13 -08:00
Yury Semikhatsky
3ff81fe172
browser(webkit): do run win build again if first attempt failed (#4881) 2021-01-04 13:40:56 -08:00
Yury Semikhatsky
b0b1561c92
browser(webkit): kick off next build (#4878) 2021-01-04 11:01:43 -08:00
Yury Semikhatsky
736ef4e879
browser(webkit): call build.sh twice on Windows (#4875) 2021-01-04 10:49:46 -08:00
Joel Einbinder
75198f044d
browser(chromium): bump to r839741 (#4857)
References #4851
2020-12-30 09:36:14 -08:00
Dmitry Gozman
ded2bc2396
browser(webkit): postpone creation of the first page (#4769)
When we create the first page in the default context in headless mode on mac,
it gets NSWindow that is "not visible". Although we call [window setIsVisible:YES],
later on window.isVisible still returns NO.

We create our offscreen "headless" NSWindow directly from applicationDidFinishLaunching:.
Experiments show that delaying this by 100ms makes everything work. As a symptom,
we get applicationDidUnhide: notification that does not happen when we create the window
immediately.

Perhaps, we create the window too early, and there is some essential initialization
that happens after applicationDidFinishLaunching:. However, if we call
[NSApp activateIgnoringOtherApps:YES] like we do in headful mode, everything works.

The only solution that worked so far is creating the first page after a timeout.
2020-12-29 13:49:39 -08:00
Joel Einbinder
e7ee426202
yury comments (#4639) 2020-12-23 08:04:59 -08:00
Yury Semikhatsky
73edf13ad6
browser(webkit): roll to 12-21 (#4794) 2020-12-21 16:07:45 -08:00
Yury Semikhatsky
b3e7838582
browser(firefox): clear AuthCache when setting context proxy (#4793) 2020-12-21 15:54:15 -08:00
Andrey Lushnikov
761bd78879
browser(firefox): fix build on MacOS (#4758) 2020-12-17 21:02:01 -08:00
Andrey Lushnikov
b56dd7deb1
devops: kick ffmpeg build (#4757)
Try building ffmpeg on github self-hosted runner
2020-12-17 18:30:04 -08:00
Yury Semikhatsky
e4658ea9c0
browser(webkit): base64 encode request.postData (#4743) 2020-12-16 14:35:05 -08:00
Yury Semikhatsky
94f5002ae4
browser(webkit): install patchelf (required by generate-bundle) (#4741) 2020-12-16 12:53:28 -08:00
Yury Semikhatsky
b014fa1855
browser(webkit): roll to 12-16 (#4739) 2020-12-16 09:19:27 -08:00
Yury Semikhatsky
50b0b47993
browser(webkit): mac build fix after roll to 12-15 (#4733) 2020-12-15 23:07:34 -08:00
Andrey Lushnikov
0af34a4f0b
devops: firefox build now requires newer MacOS SDK to build against (#4732) 2020-12-15 16:27:34 -08:00
Yury Semikhatsky
eecb798356
browser(webkit): roll to 12-15 (#4727) 2020-12-15 13:00:49 -08:00