Commit Graph

4116 Commits

Author SHA1 Message Date
Yury Semikhatsky
1e327d4cb2
fix(bindings): unflake TestBrowserContextExposeFunction.shouldWork in java (#5532) 2021-02-19 18:58:32 -08:00
Pavel Feldman
600f731a67
feat(inspector): render api names from metainfo (#5530) 2021-02-19 18:12:33 -08:00
Dmitry Gozman
d6ac3e6883
browser(webkit): honor Set-Cookie header from intercepted requests (mac) (#5529) 2021-02-19 16:28:54 -08:00
Dmitry Gozman
058ce60511
docs: combine text sections in selectors doc (#5528) 2021-02-19 16:28:35 -08:00
Pavel Feldman
f154a827c5
feat(inspector): send api names along with metainfo (#5518) 2021-02-19 16:21:39 -08:00
Dmitry Gozman
46c8c29f7a
fix(logs): restore pw:browser logs after launch has finished (#5527) 2021-02-19 16:09:38 -08:00
Andrey Lushnikov
e2a935b3d6
devops: fix nits in browser compilation infrastructure (#5526)
This patch:
- makes sure that failed runs actually show as failed in GHA
- attempts to use MINGW's `du` and `awk` to get upload size
2021-02-19 14:43:27 -08:00
Andrey Lushnikov
c57f1fc390
devops(chromium): missing depot tools in prepare_checkout.sh script (#5525)
Make sure `prepare_checkout.sh` has depot_tools in its PATH.

Drive-by: enable goma compiler proxy auto-restart.
2021-02-19 14:23:09 -08:00
Andrey Lushnikov
57c7a703ca
test: mark test as "fixme" on chromium (#5524)
References #5523
2021-02-19 13:50:34 -08:00
Yury Semikhatsky
5f9acfaccb
feat(webkit): bump to 1436 (#5513) 2021-02-19 13:47:47 -08:00
Andrey Lushnikov
bba9fabfe3
browser(firefox): roll Firefox to beta @ Feb 19, 2021 (#5521) 2021-02-19 13:11:05 -08:00
Andrey Lushnikov
7ed1d88567
browser(chromium): build Chromium Dev revision (#5522) 2021-02-19 13:10:50 -08:00
Yury Semikhatsky
6841da1487
docs: always use number for polling option in java (#5519) 2021-02-19 12:19:34 -08:00
Zev Isert
cbcc609fa1
fix: return non-secure cookies with HTTPS URLs (#5507)
Cookies have a "Secure" attribute which tells the browsers
that a given cookie should only be sent via HTTPS. In it's
absense "Secure" is falsy and these cookies should be sent
with both HTTP and HTTPS requests. Playwright now returns
only the "Non-Secure" cookies for HTTP URLs, and both
"Secure" and "Non-Secure" cookies for HTTPS URLs.

Fixes #5504
2021-02-19 11:50:59 -08:00
Andrey Lushnikov
a9c91b0703
test: fix test sanitization (#5515)
This was regressed in https://github.com/microsoft/playwright/pull/5502

Three pause tests are broken: https://devops.aslushnikov.com/flakiness2.html#timestamp=1613756319661
2021-02-19 10:54:05 -08:00
Andrey Lushnikov
18ce95632f
devops: fix firefox build (#5516) 2021-02-19 10:52:12 -08:00
Andrey Lushnikov
b2d9af5e15
browser(firefox): properly initialize debugging pipe on windows (#5514)
browser(firefox): properly initialize debugging pipe on windows

Firefox on Windows has 2 launch modes:
- default: a special "launcher process" is used to start browser as a
  sub-process
- non-default: browser process starts right away

Firefox has a logic to detect how successful was the use of the
launcher process to do self-recovery when things go wrong. Namely:
- when attempting to use launcher process, firefox records a timestamp
  of the attempt beginning
- once the launcher process successfully launches browser sub-process,
  firefox records another timestamp of the completion

On a new launch, firefox checks what timestamps are present. If there's
a timestamp that signifies start of launcher process, but no successful
timestamp, it decides that last "launcher process" use was not
successful and falls back to launching browser right away.

When launching 2 firefox processes right away, the first process
uses attempts to use launcher process and records the first timestamp.

At the same time, the second instance sees the first timestamp and
doesn't see the second timestamp, and falls back to launching browser
right away. Our debugging pipe code, however, does not support
non-launcher-process code path.

This patch adds support for remote debugging pipe in case of
non-launcher-process startup.

Drive-by:
- disable crashreporter altogether
- remove stray dcheck that breaks firefox debug compilation
- disable compilation of firefox update agent
- do not use WIN32_DISTRIB flag unless doing full builds since
  it kills incremental compilation


References #4660
2021-02-19 10:32:47 -08:00
Anže Vodovnik
48f7a37259
docs(csharp): trimming to avoid broken refs (#5330) 2021-02-19 09:37:03 -08:00
Pavel Feldman
bb2b29631a
feat(inspector): pause on page/context close (#5319) 2021-02-19 09:33:24 -08:00
Dmitry Gozman
8a9048c2b5
feat(inspector): selector input (#5502) 2021-02-19 07:25:08 -08:00
Joel Einbinder
a9faa9c941
test(webkit): add new scrolling tests to ensure correct webkit behavior (#5496) 2021-02-18 13:29:56 -08:00
Joel Einbinder
846fd71121
browser(webkit): fix scrolling in mobile viewports (#5497) 2021-02-18 13:29:17 -08:00
Anže Vodovnik
9b73edfa19
chore(docs): fix invalid markdown reference (#5479) 2021-02-18 11:12:08 -08:00
Pavel Feldman
15833ee039
feat(inspector): render params and durations in log (#5489) 2021-02-17 22:10:13 -08:00
Dmitry Gozman
da135c2abb
fix(trace viewer): follow up with recent instrumentation changes (#5488)
- List all actions we are interested in
- Fix timeline hover flicker
- Extract tabbed pane component
- Preview snapshots without clicking on the action
2021-02-17 17:51:57 -08:00
Pavel Feldman
3248c2449c
feat(inspector): collapse completed items (#5484) 2021-02-17 17:28:02 -08:00
Dmitry Gozman
dc51536bca
feat(waitForResponse): print regex pattern when waiting for request/response (#5485) 2021-02-17 15:11:23 -08:00
Andrey Lushnikov
8c18b90038
devops: refactor chromium automation scripts (#5486)
Split preparing checkout, archiving and compiling into separate
scripts similarly how we do it with other browsers.
2021-02-17 14:43:19 -08:00
Pavel Feldman
b2227c1bcf
feat(inspector): allow selecting file (#5483) 2021-02-17 14:05:41 -08:00
Anže Vodovnik
8f3a6c6b45
chore(docs): improve xmldoc inline code parsing (#5480) 2021-02-17 10:45:15 -08:00
Naresh
cc749fe679
fix(android): added recent apps button (#5331) 2021-02-16 19:37:46 -08:00
Pavel Feldman
30e68f6d1f
chore: simplify code generation (#5466) 2021-02-16 18:13:26 -08:00
Andrey Lushnikov
b6bd7c0d6a
feat(chromium): roll Chromium to r851527 (#5434)
Fixes #5197
2021-02-16 14:21:47 -08:00
Max Schmitt
7971bb0335
devops: verify clean tree on bots after build (#5354) 2021-02-16 13:38:09 -08:00
Andrey Lushnikov
f2b25fe6bd
fix: do not rely on $PATH when resolving executables (#5475)
Since CRON jobs reset $PATH to a very basic one, we should
use only direct paths to system executables.

Fixes #5469
2021-02-16 10:23:38 -08:00
Andrey Lushnikov
6b40d75d03
fix: allow setting input files for detached <input> elements (#5467)
Fixes #5403
2021-02-16 10:22:46 -08:00
Andrey Lushnikov
4f1d84d6b9
browser(webkit): respect download attribute (#5474)
References #5396
2021-02-16 10:22:19 -08:00
Andrey Lushnikov
d0352cfb71
feat(firefox): roll Firefox to r1230 (#5473)
References #4987
2021-02-16 09:23:02 -08:00
Andrey Lushnikov
027f2ba9e1 devops: enable goma.sh debugging info 2021-02-16 09:34:26 -07:00
Dmitry Gozman
822f7cb1eb
browser(firefox): respect Set-Cookie header from fulfilled request (#5456) 2021-02-15 22:49:57 -08:00
Anže Vodovnik
9dd443e1aa
chore(docs): add ability to generate xmldocs (#5164)
Introduces a naive XmlDocs renderer for Markdown nodes. It needs to be called separately for now.
2021-02-15 19:41:40 +01:00
Pavel Feldman
0c7da44465
test(inspector): add some tests (#5461) 2021-02-15 08:32:13 -08:00
Dmitry Gozman
1f3449c7da
fix(download): do not stall BrowserContext.close waiting for downloads (#5424)
We might not ever get the "download finished" event when closing the context:
- in Chromium, for any ongoing download;
- in all browsers, for failed downloads.

This should not prevent closing the context. Instead of waiting for the
download and then deleting it, we force delete it immediately and reject
any promises waiting for the download completion.
2021-02-14 16:46:26 -08:00
Pavel Feldman
8b9a2afd3d
feat(inspector): render errors (#5459) 2021-02-13 22:13:51 -08:00
Pavel Feldman
ae2ffb3fb9
feat(inspector): instrument wait for event (#5457) 2021-02-13 20:31:06 -08:00
Andrey Lushnikov
e7b431d2f7
devops: fix test triggering (#5458) 2021-02-13 15:17:53 -08:00
Pavel Feldman
ecd15e6175
fix(inspector): restore point highlight (#5455) 2021-02-12 22:06:45 -08:00
Pavel Feldman
0782b25272
test: fix recorder downloads test (#5454) 2021-02-12 20:26:22 -08:00
Pavel Feldman
3c877374c7
feat: add replay log (#5452) 2021-02-12 18:53:46 -08:00
Andrey Lushnikov
6326d6f3ac
devops: properly trigger tests on internal test runners (#5453) 2021-02-12 15:52:48 -08:00