playwright/utils/draft_release_notes.sh
Patrick Shaw 6e78dcb7dc
fix: Allow portable bash paths for systems including NixOS (#23889)
Although very common, bash is not guaranteed to be located at
`/bin/bash`. NixOS is an example of this.

More commonly, `/bin/bash` can be quite out of date. An example of this
is MacOS's version of `bash`. This realistically won't affect Playwright
but it's worth noting. You can technically update MacOS's system version
of bash but you need elevated permissions to do so.

By using `/usr/bin/env bash` instead of `/bin/bash` we can execute
Playwright's bash scripts in like NixOS and generally improve the
selection behaviour for bash in other systems too.

Some discussion of why it's worth favouring `/usr/bin/env bash` over
`/bin/bash`:
- Discusses `/bin/bash` missing in NixOS:
https://discourse.nixos.org/t/add-bin-bash-to-avoid-unnecessary-pain/5673
- Some general commentary on why `/usr/bin/env bash` is favoured:
https://askubuntu.com/a/1402721
- Points out how old bash is in MacOS:
https://itnext.io/upgrading-bash-on-macos-7138bd1066ba

Improves situation at #5501
2023-07-03 06:27:06 -07:00

40 lines
956 B
Bash
Executable File

#!/usr/bin/env bash
set -e
set +x
trap "cd $(pwd -P)" EXIT
cd "$(dirname $0)"
git fetch --tags git@github.com:microsoft/playwright.git >/dev/null 2>/dev/null
LAST_RELEASE=$(git describe --tags $(git rev-list --tags --max-count=1))
echo "## Highlights"
echo
echo "TODO: asked teammates for the highlights"
echo
echo "## Browser Versions"
echo
node ./print_versions.js
echo
echo "## New APIs"
echo
echo "TODO: \`git diff -w ${LAST_RELEASE}..HEAD src/client\`"
echo
CLOSED_ISSUES=$(./list_closed_issues.sh "${LAST_RELEASE}")
ISSUES_COUNT=$(echo "${CLOSED_ISSUES}" | wc -l | xargs)
echo "<details>"
echo " <summary><b>Issues Closed (${ISSUES_COUNT})</b></summary>"
echo
echo "${CLOSED_ISSUES}"
echo
echo "</details>"
COMMITS=$(git log --pretty="%h - %s" "${LAST_RELEASE}"..HEAD)
COMMITS_COUNT=$(echo "${COMMITS}" | wc -l | xargs)
echo "<details>"
echo " <summary><b>Commits (${COMMITS_COUNT})</b></summary>"
echo
echo "${COMMITS}"
echo
echo "</details>"