playwright/browser_patches
Andrey Lushnikov 6ec4f3e398
browser(firefox-beta): fix compilation on win32 (#9517)
I accidentally moved the API declaration under ifdef; reverting the
move.

Pretty diff:
7c7430b53f
2021-10-14 12:08:38 -07:00
..
chromium browser(chromium): roll to r930007 (#9425) 2021-10-11 12:10:50 +02:00
ffmpeg devops: build FFMPEG using MacOS 11 (#9402) 2021-10-08 13:52:02 -07:00
firefox devops: move Firefox and WebKit checkouts to $HOME (#9485) 2021-10-14 10:20:06 -07:00
firefox-beta browser(firefox-beta): fix compilation on win32 (#9517) 2021-10-14 12:08:38 -07:00
webkit browser(webkit): roll to 10/14/21 (#9510) 2021-10-14 10:29:38 -07:00
winldd Revert "browser(winldd): attempt to fix dependency loading on windows (#7790)" (#7948) 2021-08-02 16:28:16 +02:00
build.sh devops: fix //browser_patches/{build.sh,clean.sh} scripts (#9515) 2021-10-14 11:48:01 -07:00
checkout_build_archive_upload.sh devops: fix expected ffmpeg os host 2021-10-08 14:11:49 -07:00
clean.sh devops: fix //browser_patches/{build.sh,clean.sh} scripts (#9515) 2021-10-14 11:48:01 -07:00
export.sh devops: move Firefox and WebKit checkouts to $HOME (#9485) 2021-10-14 10:20:06 -07:00
prepare_checkout.sh devops: move Firefox and WebKit checkouts to $HOME (#9485) 2021-10-14 10:20:06 -07:00
README.md chore: use bash instead of sh in code blocks (#6847) 2021-06-02 18:23:06 +02:00
repack-juggler.mjs chore: enhance repack-juggler (#8586) 2021-08-31 04:04:30 -07:00
sanitize_and_compress_log.js devops: use node.js to gzip logs 2020-04-20 02:52:26 -07:00
send_telegram_message.sh chore: quote all bash variables when used (#8066) 2021-08-07 05:32:18 -07:00
upload.sh chore: quote all bash variables when used (#8066) 2021-08-07 05:32:18 -07:00
utils.sh devops: enforce hard xcode version match for browser builds (#7591) 2021-07-13 18:12:53 -07:00

Contributing Browser Patches

Firefox and WebKit have additional patches atop to expose necessary capabilities.

Ideally, all these changes should be upstreamed. For the time being, it is possible to setup a browser checkout and develop from there.

WebKit upstream status

1. Setting up local browser checkout

From the playwright repo, run the following command:

$ ./browser_patches/prepare_checkout.sh firefox <path to checkout>

(you can optionally pass "webkit" for a webkit checkout)

If you don't have a checkout, don't pass a path and one will be created for you in ./browser_patches/firefox/checkout

NOTE: this command downloads GBs of data.

This command will:

  • create a browser_upstream remote in the checkout
  • create a playwright-build branch and apply all playwright-required patches to it.

2. Developing a new change

You want to create a new branch off the playwright-build branch.

Assuming that you're under ./browser_patches/firefox/checkout:

$ git checkout -b my-new-feature playwright-build
$ # develop my feature on the my-new-feature branch ....

3. Exporting your change to playwright repo

Once you're happy with the work you did in the browser-land, you want to export it to the playwright repo.

Assuming that you're in the root of the playwright repo and that your browser checkout has your feature branch checked out:

$ ./browser_patches/export.sh firefox <path to checkout>

This script will:

  • create a new patch and put it to the ./browser_patches/firefox/patches/
  • update the ./browser_patches/firefox/UPSTREAM_CONFIG.sh if necessary
  • bump the ./browser_patches/firefox/BUILD_NUMBER number.

If you omit the path to your checkout, the script will assume one is located at ./browser_patches/firefox/checkout

Send a PR to the Playwright repo to be reviewed.

4. Rolling Playwright to the new browser build

Once the patch has been committed, the build bots will kick in, compile and upload a new browser version to all the platforms. Then you can roll the browser:

$ node utils/roll_browser.js chromium 123456

Cheatsheet

See browser stdout/stderr

Set the DEBUG=pw:browser environment variable to see it.

Firefox

Stack trace

In //mozglue/misc/StackWalk.cpp add

#define MOZ_DEMANGLE_SYMBOLS 1

In native code use

nsTraceRefcnt::WalkTheStack(stderr);

If the stack trace is still mangled cat it to tools/rb/fix_linux_stack.py

Logging

Upstream documentation: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Gecko_Logging

MOZ_LOG=nsHttp:5

Module name is a string passed to the mozilla::LazyLogModule of the corresponding component, e.g.:

LazyLogModule gHttpLog("nsHttp");

Inside Juggler, you can use dump('foo\n').

WebKit

Logging

Inside Objective-C you can use NSLog.

NSLog(@"Foobar value: %@", value);

Debugging windows

In Source\WTF\wtf\win\DbgHelperWin.cpp replace

#if !defined(NDEBUG) with #if 1

Then regular WTFReportBacktrace() works.

Enable core dumps on Linux

mkdir -p /tmp/coredumps
sudo bash -c 'echo "/tmp/coredumps/core-pid_%p.dump" > /proc/sys/kernel/core_pattern'
ulimit -c unlimited

Then to read stack traces run the following command:

# To find out crashing process name
file core-pid_29652.dump
# Point gdb to the local binary of the crashed process and the core file
gdb $HOME/.cache/ms-playwright/webkit-1292/minibrowser-gtk/WebKitWebProcess core-pid_29652
# Inside gdb update .so library search path to the local one
set solib-search-path /home/yurys/.cache/ms-playwright/webkit-1292/minibrowser-gtk
# Finally print backtrace
bt