mirror of
https://github.com/microsoft/playwright.git
synced 2024-12-13 17:14:02 +03:00
61ff52704c
This replaces previous `checkHitTarget` heuristic that took place before the action
with a new `setupHitTargetInterceptor` that works during the action:
- Before the action we set up capturing listeners on the window.
- During the action we ensure that event target is the element we expect to interact with.
- After the action we clear the listeners.
This should catch the "layout shift" issues where things move
between action point calculation and the actual action.
Possible issues:
- **Risk:** `{ trial: true }` might dispatch move events like `mousemove` or `pointerout`,
because we do actually move the mouse but prevent all other events.
- **Timing**: The timing of "hit target check" has moved, so this may affect different web pages
in different ways, for example expose more races. In this case, we should retry the click as before.
- **No risk**: There is still a possibility of mis-targeting with iframes shifting around,
because we only intercept in the target frame. This behavior does not change.
There is an opt-out environment variable PLAYWRIGHT_NO_LAYOUT_SHIFT_CHECK that reverts to previous behavior.
106 lines
4.2 KiB
TypeScript
106 lines
4.2 KiB
TypeScript
/**
|
|
* Copyright 2018 Google Inc. All rights reserved.
|
|
* Modifications copyright (c) Microsoft Corporation.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { test as it, expect } from './pageTest';
|
|
|
|
it('should fail when element jumps during hit testing', async ({ page, mode }) => {
|
|
it.skip(mode !== 'default');
|
|
|
|
await page.setContent('<button>Click me</button>');
|
|
let clicked = false;
|
|
const handle = await page.$('button');
|
|
const __testHookBeforeHitTarget = () => page.evaluate(() => {
|
|
const margin = parseInt(document.querySelector('button').style.marginLeft || '0', 10) + 100;
|
|
document.querySelector('button').style.marginLeft = margin + 'px';
|
|
});
|
|
const promise = handle.click({ timeout: 5000, __testHookBeforeHitTarget } as any).then(() => clicked = true).catch(e => e);
|
|
const error = await promise;
|
|
expect(clicked).toBe(false);
|
|
expect(await page.evaluate('window.clicked')).toBe(undefined);
|
|
expect(error.message).toContain('elementHandle.click: Timeout 5000ms exceeded.');
|
|
expect(error.message).toContain('<body>…</body> intercepts pointer events');
|
|
expect(error.message).toContain('retrying click action');
|
|
});
|
|
|
|
it('should timeout waiting for hit target', async ({ page, server }) => {
|
|
await page.goto(server.PREFIX + '/input/button.html');
|
|
const button = await page.$('button');
|
|
await page.evaluate(() => {
|
|
document.body.style.position = 'relative';
|
|
const blocker = document.createElement('div');
|
|
blocker.id = 'blocker';
|
|
blocker.style.position = 'absolute';
|
|
blocker.style.width = '400px';
|
|
blocker.style.height = '20px';
|
|
blocker.style.left = '0';
|
|
blocker.style.top = '0';
|
|
document.body.appendChild(blocker);
|
|
});
|
|
const error = await button.click({ timeout: 5000 }).catch(e => e);
|
|
expect(error.message).toContain('elementHandle.click: Timeout 5000ms exceeded.');
|
|
expect(error.message).toContain('<div id="blocker"></div> intercepts pointer events');
|
|
expect(error.message).toContain('retrying click action');
|
|
expect(error.message).toContain('waiting 500ms');
|
|
});
|
|
|
|
it('should still click when force but hit target is obscured', async ({ page, server }) => {
|
|
await page.goto(server.PREFIX + '/input/button.html');
|
|
const button = await page.$('button');
|
|
await page.evaluate(() => {
|
|
document.body.style.position = 'relative';
|
|
const blocker = document.createElement('div');
|
|
blocker.id = 'blocker';
|
|
blocker.style.position = 'absolute';
|
|
blocker.style.width = '400px';
|
|
blocker.style.height = '200px';
|
|
blocker.style.left = '0';
|
|
blocker.style.top = '0';
|
|
document.body.appendChild(blocker);
|
|
});
|
|
await button.click({ force: true });
|
|
});
|
|
|
|
it('should report wrong hit target subtree', async ({ page, server }) => {
|
|
await page.goto(server.PREFIX + '/input/button.html');
|
|
const button = await page.$('button');
|
|
await page.evaluate(() => {
|
|
document.body.style.position = 'relative';
|
|
|
|
const blocker = document.createElement('div');
|
|
blocker.id = 'blocker';
|
|
blocker.style.position = 'absolute';
|
|
blocker.style.width = '400px';
|
|
blocker.style.height = '20px';
|
|
blocker.style.left = '0';
|
|
blocker.style.top = '0';
|
|
document.body.appendChild(blocker);
|
|
|
|
const inner = document.createElement('div');
|
|
inner.id = 'inner';
|
|
inner.style.position = 'absolute';
|
|
inner.style.left = '0';
|
|
inner.style.top = '0';
|
|
inner.style.right = '0';
|
|
inner.style.bottom = '0';
|
|
blocker.appendChild(inner);
|
|
});
|
|
const error = await button.click({ timeout: 5000 }).catch(e => e);
|
|
expect(error.message).toContain('elementHandle.click: Timeout 5000ms exceeded.');
|
|
expect(error.message).toContain('<div id="inner"></div> from <div id="blocker">…</div> subtree intercepts pointer events');
|
|
expect(error.message).toContain('retrying click action');
|
|
});
|