microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 21:53:35 +03:00
Code Issues Projects Releases Wiki Activity
8bc26a2b44
playwright/packages
History
Max Schmitt 8bc26a2b44
chore: wait for downloads getting removed on context.close() (#23500) 
Before there was a race, that we ran into this code:


9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L236-L237)

and then into this code:


9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L429-L431)

which had the side effect, that the first call did not wait. Then
immediately clears the downloads Set and then the second call is a NOOP.
This ends up that the the removal of the downloads can happen after the
context is closed, hence the test is flaky.

Relates to https://github.com/microsoft/playwright/pull/6151 where it
got introduced. So something for @yury-s.

Fixes https://github.com/microsoft/playwright/issues/22525
2023-06-06 20:38:36 +02:00
..
html-reporter fix(html): fix the filter to respect status (#23208) 2023-05-22 15:35:19 -07:00
playwright chore: upgrade @types/node to 16.x (#23429) 2023-06-02 10:04:41 +02:00
playwright-chromium chore: upgrade @types/node to 16.x (#23429) 2023-06-02 10:04:41 +02:00
playwright-core chore: wait for downloads getting removed on context.close() (#23500) 2023-06-06 20:38:36 +02:00
playwright-ct-core chore(deps): bump vite from 4.3.3 to 4.3.9 (#23537) 2023-06-06 11:12:07 +02:00
playwright-ct-react chore(ct): internal types (#23332) 2023-06-02 14:11:03 -07:00
playwright-ct-react17 chore(ct): internal types (#23332) 2023-06-02 14:11:03 -07:00
playwright-ct-solid chore(ct): internal types (#23332) 2023-06-02 14:11:03 -07:00
playwright-ct-svelte chore: upgrade @types/node to 16.x (#23429) 2023-06-02 10:04:41 +02:00
playwright-ct-vue chore(ct): internal types (#23332) 2023-06-02 14:11:03 -07:00
playwright-ct-vue2 chore(ct): internal types (#23332) 2023-06-02 14:11:03 -07:00
playwright-firefox chore: upgrade @types/node to 16.x (#23429) 2023-06-02 10:04:41 +02:00
playwright-test chore: do not show the open error (#23547) 2023-06-06 11:09:08 -07:00
playwright-webkit chore: upgrade @types/node to 16.x (#23429) 2023-06-02 10:04:41 +02:00
protocol/src feat(screenshot): Add customizable color option for masked elements (#23185) 2023-05-22 18:44:44 -07:00
recorder chore(internal): generate code in jsonl (#23124) 2023-05-20 10:15:33 -07:00
trace/src chore: render route markers in the trace network panel (#23476) 2023-06-02 13:00:27 -07:00
trace-viewer chore: fix UI Mode on Codespaces (#23549) 2023-06-06 20:09:39 +02:00
web chore: hide 'Open in VSCode' for folders in UI Mode (#23499) 2023-06-05 22:09:45 +02:00
.eslintrc-with-ts-config.js lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00
.eslintrc.js lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00