playwright/packages
Andrey Lushnikov 9105a20ac4
fix: remove window.stop() from page.setContent() implementation (#26886)
The call was added back in 2019 to stop network loading. See commit:
56a48559c2

However, there's no evidence that this call is needed any more:
- all the tests pass without it
- `window.stop()` behavior is poorly defined, so relying on it is
unfortunate.

The `window.stop()` call, however, causes trouble while rolling firefox:
under certain condititions, the call prevents document from firing the
`load` event in the `document.open().write(..).close()` sequence that
comes immediately after the call. While this does look like a bug in
Firefox itself, we failed to reproduce it in isolation.

For the reference, the following tests fail with the Firefox 116 (using
`PWTEST_TRACE=1` triggers the race condition somewhere):

```bash
PWTEST_TRACE=1 npm run ftest cli-codegen
```
2023-09-06 11:02:38 -07:00
..
html-reporter chore: fix html-reporter/trace-viewer TSC errors (#26813) 2023-08-31 18:08:38 +02:00
playwright feat: make playwright package not install browsers automatically (#26672) 2023-08-27 07:24:35 -07:00
playwright-browser-chromium feat: make playwright package not install browsers automatically (#26672) 2023-08-27 07:24:35 -07:00
playwright-browser-firefox feat: make playwright package not install browsers automatically (#26672) 2023-08-27 07:24:35 -07:00
playwright-browser-webkit feat: make playwright package not install browsers automatically (#26672) 2023-08-27 07:24:35 -07:00
playwright-chromium chore: cut 1.37.0 branch (#26357) 2023-08-09 01:46:29 -07:00
playwright-core fix: remove window.stop() from page.setContent() implementation (#26886) 2023-09-06 11:02:38 -07:00
playwright-ct-core chore: do not add plugins to config twice (#26670) 2023-08-24 16:19:57 -07:00
playwright-ct-react chore: do not add plugins to config twice (#26670) 2023-08-24 16:19:57 -07:00
playwright-ct-react17 chore: do not add plugins to config twice (#26670) 2023-08-24 16:19:57 -07:00
playwright-ct-solid chore: cut 1.37.0 branch (#26357) 2023-08-09 01:46:29 -07:00
playwright-ct-svelte feat(ct): svelte vite context (#26554) 2023-08-19 16:26:06 -07:00
playwright-ct-vue fix(ct): vue jsx mount options type (#26566) 2023-08-21 08:48:03 -07:00
playwright-ct-vue2 fix(ct): vue jsx mount options type (#26566) 2023-08-21 08:48:03 -07:00
playwright-firefox chore: cut 1.37.0 branch (#26357) 2023-08-09 01:46:29 -07:00
playwright-test fix: implement atomic append for compilation cache (#26830) 2023-08-31 17:55:13 -07:00
playwright-webkit chore: cut 1.37.0 branch (#26357) 2023-08-09 01:46:29 -07:00
protocol/src feat(evaluate): serialize map and set (#26730) 2023-08-28 14:32:41 -07:00
recorder chore: use SVG icons for web apps (#26564) 2023-08-21 18:33:02 +02:00
trace/src chore: fix har date types (#26783) 2023-08-30 12:40:46 -07:00
trace-viewer fix(trace): make locator picker work for iframes (#26883) 2023-09-06 09:44:47 -07:00
web chore: add log/error tabs and counters (#26843) 2023-09-01 20:12:05 -07:00
.eslintrc-with-ts-config.js lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00
.eslintrc.js chore: replace process.exit with graceful closure (#24242) 2023-07-24 08:29:29 -07:00