playwright/packages
Yury Semikhatsky 9d91b7caf5
fix(route): silently catch errors when handling route on server (#28612)
This is a follow-up to 119afdf788 Since
continue/fulfill/abort now may throw on the server after page has been
closed, we need to catch the errors manually. On the client it's fixed
by the original change.

This fixes errors in the existing tests:
```
  1) [chromium] › library/browsercontext-route.spec.ts:172:3 › should support Set-Cookie header ────

    Error: 

       at ../packages/playwright-core/src/server/chromium/crConnection.ts:147

      145 |     const id = this._connection._rawSend(this._sessionId, method, params);
      146 |     return new Promise((resolve, reject) => {
    > 147 |       this._callbacks.set(id, { resolve, reject, error: new ProtocolError('error', method) });
          |                                                         ^
      148 |     });
      149 |   }
      150 |

        at /Users/yurys/playwright/packages/playwright-core/src/server/chromium/crConnection.ts:147:57
        at new Promise (<anonymous>)
        at CRSession.send (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crConnection.ts:146:12)
        at RouteImpl.continue (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crNetworkManager.ts:566:25)
        at FrameManager.requestStarted (/Users/yurys/playwright/packages/playwright-core/src/server/frames.ts:299:23)
        at CRNetworkManager._onRequest (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crNetworkManager.ts:314:57)
        at CRNetworkManager._onRequestPaused (/Users/yurys/playwright/packages/playwright-core/src/server/chromium/crNetworkManager.ts:202:12)
        at CRSession.emit (node:events:517:28)
        at /Users/yurys/playwright/packages/playwright-core/src/server/chromium/crConnection.ts:172:14
        at runNextTicks (node:internal/process/task_queues:60:5)
        at processImmediate (node:internal/timers:447:9)
```


![image](https://github.com/microsoft/playwright/assets/9798949/1c436dc2-f113-4ba6-952c-dca5a8c5fa62)

Reference https://github.com/microsoft/playwright/issues/28490
2023-12-13 09:34:20 -08:00
..
html-reporter feat: config.botName for describing environment in the reports (#28507) 2023-12-06 13:34:16 -08:00
playwright fix: do not generate api call steps inside named expects (#28609) 2023-12-13 09:06:02 -08:00
playwright-browser-chromium chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
playwright-browser-firefox chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
playwright-browser-webkit chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
playwright-chromium chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
playwright-core fix(route): silently catch errors when handling route on server (#28612) 2023-12-13 09:34:20 -08:00
playwright-ct-core fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
playwright-ct-react fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
playwright-ct-react17 fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
playwright-ct-solid fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
playwright-ct-svelte fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
playwright-ct-vue fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
playwright-ct-vue2 fix(components): make sure defineConfig(c1, c2) works (#28608) 2023-12-12 14:01:01 -08:00
playwright-firefox chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
playwright-test chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
playwright-webkit chore: mark version 1.41.0-next (#28180) 2023-11-15 20:05:36 -08:00
protocol/src feat(vrt): allow providing screenshot style (#28229) 2023-11-30 17:42:45 -08:00
recorder chore: make asLocator() always safe (#28207) 2023-11-16 16:31:34 -08:00
trace/src feat(trace): show target point for raw mouse apis (#28459) 2023-12-07 06:27:49 -08:00
trace-viewer feat(trace): show target point for raw mouse apis (#28459) 2023-12-07 06:27:49 -08:00
web chore: use codemirror in the on-hover locator editor (#28090) 2023-11-10 22:00:28 -08:00
.eslintrc-with-ts-config.js lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00
.eslintrc.js chore: replace process.exit with graceful closure (#24242) 2023-07-24 08:29:29 -07:00