playwright/utils/linux-browser-dependencies/run.sh
Patrick Shaw 6e78dcb7dc
fix: Allow portable bash paths for systems including NixOS (#23889)
Although very common, bash is not guaranteed to be located at
`/bin/bash`. NixOS is an example of this.

More commonly, `/bin/bash` can be quite out of date. An example of this
is MacOS's version of `bash`. This realistically won't affect Playwright
but it's worth noting. You can technically update MacOS's system version
of bash but you need elevated permissions to do so.

By using `/usr/bin/env bash` instead of `/bin/bash` we can execute
Playwright's bash scripts in like NixOS and generally improve the
selection behaviour for bash in other systems too.

Some discussion of why it's worth favouring `/usr/bin/env bash` over
`/bin/bash`:
- Discusses `/bin/bash` missing in NixOS:
https://discourse.nixos.org/t/add-bin-bash-to-avoid-unnecessary-pain/5673
- Some general commentary on why `/usr/bin/env bash` is favoured:
https://askubuntu.com/a/1402721
- Points out how old bash is in MacOS:
https://itnext.io/upgrading-bash-on-macos-7138bd1066ba

Improves situation at #5501
2023-07-03 06:27:06 -07:00

37 lines
1.0 KiB
Bash
Executable File

#!/usr/bin/env bash
set -e
set +x
if [[ ($1 == '--help') || ($1 == '-h') ]]; then
echo "usage: $(basename $0) <image-name> [<optional output filename>]"
echo
echo "List mapping between browser dependencies to package names and save results in RUN_RESULT file or a custom file name."
echo "Example:"
echo ""
echo " $(basename $0) ubuntu:bionic ubuntu-bionic-run-log"
echo ""
echo "NOTE: this requires Playwright dependencies to be installed with 'npm install'"
echo " and Playwright itself being built with 'npm run build'"
echo ""
exit 0
fi
if [[ $# == 0 ]]; then
echo "ERROR: please provide base image name, e.g. 'ubuntu:bionic'"
exit 1
fi
function cleanup() {
rm -f "playwright.tar.gz"
}
trap "cleanup; cd $(pwd -P)" EXIT
cd "$(dirname "$0")"
# We rely on `./playwright-core.tar.gz` to download browsers into the docker
# image.
node ../../utils/pack_package.js playwright-core ./playwright-core.tar.gz
docker run --platform linux/amd64 -v $PWD:/root/hostfolder --rm -it "$1" /root/hostfolder/inside_docker/process.sh "$2"