playwright/browser_patches/webkit
Dmitry Gozman d627376147
browser(webkit): use correct request when navigation turns into download (#6516)
Currently, WebPageProxy uses `m_decidePolicyForResponseRequest` to create
the DownloadProxy form the navigation. However, this field is not properly
set for the following callstack:

```log
1 WebKit::WebProcessPool::createDownloadProxy(WebKit::WebsiteDataStore&, WebCore::ResourceRequest const&, WebKit::WebPageProxy*, WebKit::FrameInfoData const&)
2 WebKit::WebPageProxy::receivedPolicyDecision(WebCore::PolicyAction, API::Navigation*, WTF::RefPtr<API::WebsitePolicies, WTF::RawPtrTraits<API::WebsitePolicies>, WTF::DefaultRefDerefTraits<API::WebsitePolicies> >&&, WTF::Variant<WTF::Ref<API::NavigationResponse, WTF::RawPtrTraits<API::NavigationResponse> >, WTF::Ref<API::NavigationAction, WTF::RawPtrTraits<API::NavigationAction> > >&&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::RawPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&, WTF::Optional<WebKit::SandboxExtension::Handle>, WebKit::WebPageProxy::WillContinueLoadInNewProcess) +1ms
3 WebKit::WebPageProxy::receivedNavigationPolicyDecision(WebCore::PolicyAction, API::Navigation*, WTF::Ref<API::NavigationAction, WTF::RawPtrTraits<API::NavigationAction> >&&, WebKit::ProcessSwapRequestedByClient, WebKit::WebFrameProxy&, WTF::RefPtr<API::WebsitePolicies, WTF::RawPtrTraits<API::WebsitePolicies>, WTF::DefaultRefDerefTraits<API::WebsitePolicies> >&&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::RawPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&) +1ms
4 WebKit::WebPageProxy::decidePolicyForNavigationAction(WTF::Ref<WebKit::WebProcessProxy, WTF::RawPtrTraits<WebKit::WebProcessProxy> >&&, WebKit::WebFrameProxy&, WebKit::FrameInfoData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, WTF::Optional<WTF::ObjectIdentifier<WebKit::WebPageProxyIdentifierType> >, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::RawPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&)::$_6::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::RawPtrTraits<WebKit::SafeBrowsingWarning>, WTF::DefaultRefDerefTraits<WebKit::SafeBrowsingWarning> >&&, WTF::Optional<WebKit::NavigatingToAppBoundDomain>)::'lambda'(WebCore::PolicyAction)::operator()(WebCore::PolicyAction) +0ms
```

This patch updates `m_decidePolicyForResponseRequest` on the above codepath,
and it is reset immediately in `WebPageProxy::receivedPolicyDecision`.
2021-05-12 12:38:59 -07:00
..
embedder/Playwright browser(webkit): keep browser process running when all windows closed (#6131) 2021-04-07 19:13:20 -07:00
patches browser(webkit): use correct request when navigation turns into download (#6516) 2021-05-12 12:38:59 -07:00
.gitignore Initial commit 2019-11-19 10:58:15 -08:00
archive.sh fix(devops): include libANGLE-shared.dylib into mac archive (#6004) 2021-03-30 11:29:03 -07:00
BUILD_NUMBER browser(webkit): use correct request when navigation turns into download (#6516) 2021-05-12 12:38:59 -07:00
build.sh browser(webkit): roll to 01-05 to pick up upstream Win fix (#4894) 2021-01-05 13:08:52 -08:00
buildwin.bat devops: absolute paths for webkit libraries and output directory (#4627) 2020-12-07 14:30:06 -08:00
clean.sh fix(devops): cleanup now removes entire webkit build dir on mac (#5996) 2021-03-29 23:48:34 -07:00
concat_protocol.js devops: fix webkit archiving (#4642) 2020-12-08 16:32:45 -08:00
EXPECTED_BUILDS devops: refactor check_cdn.sh script (#5835) 2021-03-16 01:14:45 -07:00
pw_run_debug.sh chore(webkit): build wpe and gtk to different folders (#616) 2020-01-24 11:54:50 -08:00
pw_run.sh browser(webkit): use webkit generate-bundle tool to generate the bundles (#3563) 2020-08-28 10:48:57 -07:00
UPSTREAM_CONFIG.sh browser(webkit): roll to safari-612.1.14-branch (#6517) 2021-05-11 15:34:28 -07:00
upstream_status.md Update upstream_status.md 2020-06-17 23:23:51 -07:00