playwright/tests/playwright-test
Dmitry Gozman ed99ac7395
fix(sigint): make sure we do not add handler twice (#24413)
In the following scenario, we were adding SIGINT handler twice, but
removing it just once:
- Task runner starts testing, creates SigIntWatcher, installs SIGINT
handler.
- Press Ctrl+C, task runner interrupts, disarms SigIntWatcher, SIGINT
handler is not removed due to 1000ms cooldown.
- Task runner starts cleanup, creates SigIntWatcher, installs another
SIGINT handler.
- Cleanup finishes, SigIntWatcher disarms, could remove or not remove
SIGINT handler based on timing (same 1000ms cooldown). In any case, we
have one or two SIGINT handlers still on.
- HTML reporter hangs in onExit, while we still have SIGINT handler up,
so Ctrl+C does not exit.

Regressed in #24265.
2023-07-25 18:35:38 -07:00
..
__screenshots__/playwright.artifacts.spec.ts feat: allow options in automatic screenshots (#19143) 2022-12-07 08:45:33 -08:00
assets chore: move TestServer under test/ (#23287) 2023-05-25 15:11:16 -07:00
stable-test-runner chore: roll stable test runner to July 19 (#24314) 2023-07-20 15:40:57 -07:00
access-data.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
babel.spec.ts chore: allow marking scripts as external for transform (#23449) 2023-06-01 20:28:49 -07:00
basic.spec.ts test: unflake basic timeout test (#22745) 2023-05-02 09:14:57 -07:00
command-line-filter.spec.ts chore: remove unnecessary args in ttest (#21012) 2023-02-18 13:08:17 -08:00
config.spec.ts fix: exclude tracesDir option from launchOptions fixture (#24086) 2023-07-06 13:31:44 -07:00
decorators.spec.ts chore: allow ts decorators (#22080) 2023-03-29 20:43:08 -07:00
deps.spec.ts chore: apply only filtration to deps (#24268) 2023-07-17 16:48:52 -07:00
esm.spec.ts fix(typescript): allow directory imports (#23254) 2023-06-05 08:58:25 -07:00
exit-code.spec.ts chore(ui): do not print global setup epilogue (#21976) 2023-03-24 20:56:45 -07:00
expect-configure.spec.ts chore: remove expect.configure({poll}) (#23060) 2023-05-16 18:45:03 -07:00
expect-poll.spec.ts chore: show last poller error on test timeout (#24292) 2023-07-18 17:03:26 -07:00
expect-soft.spec.ts chore: introduce expect.configure (#22533) 2023-04-25 10:29:56 -07:00
expect-to-pass.spec.ts chore: show last poller error on test timeout (#24292) 2023-07-18 17:03:26 -07:00
expect.spec.ts test: replace sendSIGINTAfter with interactWithTestRunner (#24411) 2023-07-25 15:46:39 -07:00
fixture-errors.spec.ts Revert "chore: refactor timeout manager to use scopes (1) (#24315)" (#24382) 2023-07-24 14:09:20 -07:00
fixtures.spec.ts fix(test runner): separate test fixture scope for beforeAll/afterAll hooks (#22746) 2023-05-02 11:04:51 -07:00
gitignore.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
global-setup.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
golden.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
hooks.spec.ts test: unflake "beforeAll and afterAll should have a separate timeout" (#23263) 2023-05-24 13:46:28 -07:00
list-files.spec.ts chore: remove output dir before each test (#23380) 2023-05-30 16:03:50 -07:00
list-mode.spec.ts chore: ensure error location is present (#22804) 2023-05-03 18:45:33 -07:00
loader.spec.ts fix(typescript): allow directory imports (#23254) 2023-06-05 08:58:25 -07:00
match-grep.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
max-failures.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
override-timeout.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
playwright-test-fixtures.ts test: replace sendSIGINTAfter with interactWithTestRunner (#24411) 2023-07-25 15:46:39 -07:00
playwright.artifacts.spec.ts Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 2023-07-13 20:03:02 +02:00
playwright.config.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
playwright.config.ts devops: always create blob report on CI, write PR number within action (#24241) 2023-07-14 15:10:29 -07:00
playwright.connect.spec.ts fix: encode launch options correctly when reusing browser (#24174) 2023-07-12 16:40:55 +02:00
playwright.ct-build.spec.ts chore: include plugin list into the cache digest (#22946) 2023-05-11 21:09:15 -07:00
playwright.ct-react.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
playwright.fetch.spec.ts test: unflake "should stop tracing on requestContext.dispose()" (#23489) 2023-06-02 16:37:50 -07:00
playwright.reuse.browser.spec.ts fix: encode launch options correctly when reusing browser (#24174) 2023-07-12 16:40:55 +02:00
playwright.reuse.spec.ts fix(trace): render items under expect.toPass (#24016) 2023-07-05 11:20:28 -07:00
playwright.spec.ts test: replace sendSIGINTAfter with interactWithTestRunner (#24411) 2023-07-25 15:46:39 -07:00
playwright.trace.spec.ts fix(tracing): do not throw on missing attachments (#24409) 2023-07-25 14:32:56 -07:00
playwright.unhandled.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
repeat-each.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
reporter-attachment.spec.ts Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 2023-07-13 20:03:02 +02:00
reporter-base.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-blob.spec.ts chore: delete --attachments option from merge-reports command (#24350) 2023-07-21 13:15:00 -07:00
reporter-dot.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-github.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-html.spec.ts fix(error): create a step for raw runtime error (#24057) 2023-07-06 10:48:12 -07:00
reporter-json.spec.ts chore: remove usesCustomOutputDir from tests (#21011) 2023-02-18 11:41:41 -08:00
reporter-junit.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-line.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-list.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-markdown.spec.ts fix: print fatal and no snippet errors in markdown report (#24263) 2023-07-17 13:50:00 -07:00
reporter-raw.spec.ts Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 2023-07-13 20:03:02 +02:00
reporter.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
resolver.spec.ts feat(test runner): support tsconfig.extends array (#22975) 2023-05-11 19:18:13 -07:00
retry.spec.ts chore: remove unnecessary args in ttest (#21012) 2023-02-18 13:08:17 -08:00
runner.spec.ts fix(sigint): make sure we do not add handler twice (#24413) 2023-07-25 18:35:38 -07:00
shard.spec.ts feat(shard): introduce mode: 'default' (#23023) 2023-05-18 13:07:22 -07:00
snapshot-path-template.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
stdio.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
store.spec.ts chore: hide store from public (#21763) 2023-03-17 11:50:44 -07:00
test-extend.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-grep.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-ignore.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-info.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-modifiers.spec.ts chore: nest test steps based on zones (#22108) 2023-03-30 21:05:07 -07:00
test-output-dir.spec.ts Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 2023-07-13 20:03:02 +02:00
test-parallel.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-serial.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-step.spec.ts fix(steps): only propagate soft errors up the hierarchy (#24054) 2023-07-05 15:30:53 -07:00
test-use.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
timeout.spec.ts test: unflake some tests (#23984) 2023-06-30 13:08:18 -07:00
to-have-screenshot.spec.ts fix: do not create empty directories for successful snapshot tests (#24127) 2023-07-10 09:45:24 -07:00
types-2.spec.ts tet: unflake some test runner tests (#23240) 2023-05-23 13:31:23 -07:00
types.spec.ts chore: update typescript to 5.1.3 (#23461) 2023-06-02 18:57:09 +02:00
ui-mode-fixtures.ts fix(ui-mode): run teardown handlers with Command + C (#24267) 2023-07-19 17:50:25 +02:00
ui-mode-test-attachments.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-test-filters.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-test-output.spec.ts feat(trace): render Node console messages in trace (#24139) 2023-07-10 18:36:28 -07:00
ui-mode-test-progress.spec.ts chore: bring back per test artifacts (#23153) 2023-05-23 09:36:35 -07:00
ui-mode-test-run.spec.ts chore: remove output dir before each test (#23380) 2023-05-30 16:03:50 -07:00
ui-mode-test-setup.spec.ts fix(ui-mode): run teardown handlers with Command + C (#24267) 2023-07-19 17:50:25 +02:00
ui-mode-test-source.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-test-tree.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
ui-mode-test-update.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-test-watch.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-trace.spec.ts chore: miscellaneous trace viewer fixes (#23695) 2023-06-14 09:37:19 -07:00
watch.spec.ts chore: call onEnd(result) on InternalReporter (#23972) 2023-06-29 17:03:10 -07:00
web-server.spec.ts test: replace sendSIGINTAfter with interactWithTestRunner (#24411) 2023-07-25 15:46:39 -07:00
worker-index.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00