From 1001904ff5faed6981c2c9001249fd15465fc29d Mon Sep 17 00:00:00 2001 From: Eric Traut Date: Tue, 26 Mar 2024 08:28:44 -0600 Subject: [PATCH] Fixed a bug that results in a false positive `reportImplicitOverride` diagnostic if the class derives from an Unknown or Any class. This addresses #7560. --- packages/pyright-internal/src/analyzer/checker.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/pyright-internal/src/analyzer/checker.ts b/packages/pyright-internal/src/analyzer/checker.ts index eb742c7bb..7556757b0 100644 --- a/packages/pyright-internal/src/analyzer/checker.ts +++ b/packages/pyright-internal/src/analyzer/checker.ts @@ -6220,6 +6220,11 @@ export class Checker extends ParseTreeWalker { return; } + // If the base class is unknown, don't report a missing decorator. + if (isAnyOrUnknown(baseMember.classType)) { + return; + } + const funcNode = overrideFunction.details.declaration.node; this._evaluator.addDiagnostic( DiagnosticRule.reportImplicitOverride,