microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-11-09 13:35:59 +03:00
Code Issues Projects Releases Wiki Activity

Fixed "NoReturn" inference logic for async functions. This logic was previously flagging the code after a call to such a function as unreachable.

Browse Source
This commit is contained in:
Eric Traut 2020-09-04 18:50:49 -07:00
parent 09d6ea7ee0
commit 1eba08bbe5
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/pyright-internal/src/analyzer/typeEvaluator.ts
View File

@ -9729,6 +9729,11 @@ export function createTypeEvaluator(importLookup: ImportLookup, printTypeFlags:
// Wrap in a Coroutine, which is a subclass of Awaitable.
const coroutineType = getTypingType(node, 'Coroutine');
if (coroutineType && isClass(coroutineType)) {
// Don't wrap a NoReturn in a Coroutine. Treat it as an Any.
if (isNoReturnType(returnType)) {
returnType = AnyType.create();
}
awaitableReturnType = ObjectType.create(
ClassType.cloneForSpecialization(
coroutineType,
@ -10641,7 +10646,7 @@ export function createTypeEvaluator(importLookup: ImportLookup, printTypeFlags:
functionType = overloadedFunction.overloads[overloadedFunction.overloads.length - 1];
}
if (functionType) {
if (functionType && !FunctionType.isAsync(functionType)) {
if (functionType.details.declaredReturnType) {
callIsNoReturn = isNoReturnType(functionType.details.declaredReturnType);
} else if (functionType.inferredReturnType) {