microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-10-06 04:47:52 +03:00
Code Issues Projects Releases Wiki Activity

Added "unknown" check for return type declarations and return expressions.

Browse Source
This commit is contained in:
Eric Traut 2020-01-04 05:10:48 -07:00
parent d39200ce6e
commit 30eba9b67d
1 changed files with 34 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
server/src/analyzer/checker.ts
View File

@ -284,6 +284,19 @@ export class Checker extends ParseTreeWalker {
}
}
}
if (returnType.category === TypeCategory.Unknown) {
this._evaluator.addDiagnostic(
this._fileInfo.diagnosticSettings.reportUnknownVariableType,
DiagnosticRule.reportUnknownVariableType,
`Return type is unknown`, node.returnExpression!);
} else if (containsUnknown(returnType)) {
this._evaluator.addDiagnostic(
this._fileInfo.diagnosticSettings.reportUnknownVariableType,
DiagnosticRule.reportUnknownVariableType,
`Return type, '${ this._evaluator.printType(returnType) }', is partially unknown`,
node.returnExpression!);
}
}
return true;
@ -1164,9 +1177,27 @@ export class Checker extends ParseTreeWalker {
const functionNeverReturns = !this._evaluator.isAfterNodeReachable(node);
const implicitlyReturnsNone = this._evaluator.isAfterNodeReachable(node.suite);
const declaredReturnType = FunctionType.isGenerator(functionType) ?
getDeclaredGeneratorReturnType(functionType) :
functionType.details.declaredReturnType;
let declaredReturnType = functionType.details.declaredReturnType;
if (declaredReturnType) {
if (declaredReturnType.category === TypeCategory.Unknown) {
this._evaluator.addDiagnostic(
this._fileInfo.diagnosticSettings.reportUnknownVariableType,
DiagnosticRule.reportUnknownVariableType,
`Declared return type is unknown`, node.returnTypeAnnotation);
} else if (containsUnknown(declaredReturnType)) {
this._evaluator.addDiagnostic(
this._fileInfo.diagnosticSettings.reportUnknownVariableType,
DiagnosticRule.reportUnknownVariableType,
`Declared return type, '${ this._evaluator.printType(declaredReturnType) }', is partially unknown`,
node.returnTypeAnnotation);
}
}
// Wrap the declared type in a generator type if the function is a generator.
if (FunctionType.isGenerator(functionType)) {
declaredReturnType = getDeclaredGeneratorReturnType(functionType);
}
// The types of all return statement expressions were already checked
// against the declared type, but we need to verify the implicit None