From 3c8176542aa6e7644676d2be137e90824d3e9b3d Mon Sep 17 00:00:00 2001 From: Eric Traut Date: Mon, 17 Feb 2020 16:31:10 -0700 Subject: [PATCH] Reverted default value of 'reportMissingTypeStubs' setting from 'warning' to 'none'. --- docs/configuration.md | 2 +- server/src/common/configOptions.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/configuration.md b/docs/configuration.md index 3f356b28e..300264046 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -44,7 +44,7 @@ The following settings control pyright’s diagnostic output (warnings or errors **reportMissingImports** [boolean or string, optional]: Generate or suppress diagnostics for imports that have no corresponding imported python file or type stub file. The default value for this setting is 'none', although pyright can do a much better job of static type checking if type stub files are provided for all imports. -**reportMissingTypeStubs** [boolean or string, optional]: Generate or suppress diagnostics for imports that have no corresponding type stub file (either a typeshed file or a custom type stub). The type checker requires type stubs to do its best job at analysis. The default value for this setting is 'warning'. Note that there is a corresponding quick fix for this diagnostics that let you generate custom type stub to improve editing experiences. +**reportMissingTypeStubs** [boolean or string, optional]: Generate or suppress diagnostics for imports that have no corresponding type stub file (either a typeshed file or a custom type stub). The type checker requires type stubs to do its best job at analysis. The default value for this setting is 'none'. Note that there is a corresponding quick fix for this diagnostics that let you generate custom type stub to improve editing experiences. **reportImportCycles** [boolean or string, optional]: Generate or suppress diagnostics for cyclical import chains. These are not errors in Python, but they do slow down type analysis and often hint at architectural layering issues. Generally, they should be avoided. The default value for this setting is 'none'. Note that there are import cycles in the typeshed stdlib typestub files that are ignored by this setting. diff --git a/server/src/common/configOptions.ts b/server/src/common/configOptions.ts index 8d7e23246..887b5ac7f 100644 --- a/server/src/common/configOptions.ts +++ b/server/src/common/configOptions.ts @@ -275,7 +275,7 @@ export function getDefaultDiagnosticSettings(): DiagnosticSettings { enableTypeIgnoreComments: true, reportTypeshedErrors: 'none', reportMissingImports: 'error', - reportMissingTypeStubs: 'warning', + reportMissingTypeStubs: 'none', reportImportCycles: 'none', reportUnusedImport: 'none', reportUnusedClass: 'none',