microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-10-06 12:57:14 +03:00
Code Issues Projects Releases Wiki Activity

Fixed bug that results in a false positive error when an unpack operator is used in an unparenthesized tuple expression on the RHS of an augmented assignment operator on Python 3.9 and newer. This addresses #8310.

Browse Source
This commit is contained in:
Eric Traut 2024-07-05 09:27:25 -07:00
parent 8a23d8f596
commit 598119b90f
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/pyright-internal/src/parser/parser.ts
View File

@ -4391,9 +4391,13 @@ export class Parser {
const rightExpr =
this._tryParseYieldExpression() ??
this._parseTestListAsExpression(ErrorExpressionCategory.MissingExpression, () =>
LocMessage.expectedBinaryRightHandExpr()
this._parseTestOrStarListAsExpression(
/* allowAssignmentExpression */ false,
/* allowMultipleUnpack */ true,
ErrorExpressionCategory.MissingExpression,
() => LocMessage.expectedBinaryRightHandExpr()
);
this._reportConditionalErrorForStarTupleElement(rightExpr, pythonVersion3_9);
// Make a shallow copy of the dest expression but give it a new ID.
const destExpr = Object.assign({}, leftExpr);
@ -4954,7 +4958,10 @@ export class Parser {
// Python 3.8 added support for star (unpack) expressions in tuples
// following a return or yield statement in cases where the tuple
// wasn't surrounded in parentheses.
private _reportConditionalErrorForStarTupleElement(possibleTupleExpr: ExpressionNode) {
private _reportConditionalErrorForStarTupleElement(
possibleTupleExpr: ExpressionNode,
pythonVersion = pythonVersion3_8
) {
if (possibleTupleExpr.nodeType !== ParseNodeType.Tuple) {
return;
}
@ -4963,7 +4970,7 @@ export class Parser {
return;
}
if (this._parseOptions.pythonVersion.isGreaterOrEqualTo(pythonVersion3_8)) {
if (this._parseOptions.pythonVersion.isGreaterOrEqualTo(pythonVersion)) {
return;
}