microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-09-17 19:27:24 +03:00
Code Issues Projects Releases Wiki Activity

Fixed a bug in the handling of dataclass where an existing __eq__ method was being overwritten by a synthesized variant. The same was true for other comparison operators.

Browse Source
This commit is contained in:
Eric Traut 2022-06-27 08:27:26 -07:00
parent 9bad0897c6
commit 6ed0571adf
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/pyright-internal/src/analyzer/dataClasses.ts
View File

@ -534,7 +534,10 @@ export function synthesizeDataClassMethods(
hasDeclaredType: true,
});
operatorMethod.details.declaredReturnType = evaluator.getBuiltInObject(node, 'bool');
symbolTable.set(operator, Symbol.createWithType(SymbolFlags.ClassMember, operatorMethod));
// If a method of this name already exists, don't override it.
if (!symbolTable.get(operator)) {
symbolTable.set(operator, Symbol.createWithType(SymbolFlags.ClassMember, operatorMethod));
}
};
// Synthesize comparison operators.