microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-09-11 16:06:39 +03:00
Code Issues Projects Releases Wiki Activity

Re-enabled file system watcher for VS Code extension but only in cases where "checkOnlyOpenFiles" is set to false.

Browse Source
This commit is contained in:
Eric Traut 2019-12-16 01:31:45 -08:00
parent 05436ce03a
commit 6f139ce932
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
server/src/server.ts
View File

@ -616,19 +616,17 @@ function updateOptionsAndRestartService(workspace: WorkspaceServiceInstance,
typeStubTargetImportName?: string) {
const commandLineOptions = new CommandLineOptions(workspace.rootPath, true);
// Disable watching of source files in the VS Code extension. This
// was previously enabled, but the file system watcher code caused
// lots of problems across multiple platforms. The benefit it provides
// (being able to catch changes made to files outside of VS Code) are
// not worth the problems it causes.
commandLineOptions.watch = false;
commandLineOptions.checkOnlyOpenFiles = pyrightSettings ?
!!pyrightSettings.openFilesOnly : true;
commandLineOptions.useLibraryCodeForTypes = pyrightSettings ?
!!pyrightSettings.useLibraryCodeForTypes : false;
// Disable watching of source files in the VS Code extension if we're
// analyzing only open files. The file system watcher code has caused
// lots of problems across multiple platforms. It provides little or
// no benefit when we're in "openFilesOnly" mode.
commandLineOptions.watch = !commandLineOptions.checkOnlyOpenFiles;
if (pythonSettings.venvPath) {
commandLineOptions.venvPath = combinePaths(workspace.rootPath || _rootPath,
normalizePath(_expandPathVariables(pythonSettings.venvPath)));