microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-08-15 10:50:44 +03:00
Code Issues Projects Releases Wiki Activity

Fixed bug that results in unions consisting of different specialized forms of a generic TypedDict to "lose" all but one of these subtypes. This addresses #8169.

Browse Source
This commit is contained in:
Eric Traut 2024-06-18 23:31:13 +02:00
parent 918bc4c745
commit 86715ec758
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/pyright-internal/src/analyzer/types.ts
View File

@ -3498,11 +3498,14 @@ function _addTypeIfUnique(unionType: UnionType, typeToAdd: UnionableType) {
// If the typeToAdd is a TypedDict that is the same class as the
// existing type, see if one of them is a proper subset of the other.
if (ClassType.isTypedDictClass(type) && ClassType.isSameGenericClass(type, typeToAdd)) {
if (ClassType.isTypedDictNarrower(typeToAdd, type)) {
return;
} else if (ClassType.isTypedDictNarrower(type, typeToAdd)) {
unionType.subtypes[i] = typeToAdd;
return;
// Do not proceed if the TypedDicts are generic and have different type arguments.
if (!type.typeArguments && !typeToAdd.typeArguments) {
if (ClassType.isTypedDictNarrower(typeToAdd, type)) {
return;
} else if (ClassType.isTypedDictNarrower(type, typeToAdd)) {
unionType.subtypes[i] = typeToAdd;
return;
}
}
}
}