microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-09-11 07:55:56 +03:00
Code Issues Projects Releases Wiki Activity

Fixed recent regression that caused a crash in the signature help provider.

Browse Source
This commit is contained in:
Eric Traut 2023-03-22 12:56:11 -06:00
parent 56c6eddc47
commit 8d9ad7958d
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
packages/pyright-internal/src/languageService/signatureHelpProvider.ts
View File

@ -147,15 +147,17 @@ export class SignatureHelpProvider {
// If we have a typedKwargs, the param name will be wrong.
const kwargsIndex = paramIndex >= params.length ? params.length - 1 : paramIndex;
const kwargsParam = params[kwargsIndex];
if (
isTypedKwargs(kwargsParam) &&
isClassInstance(kwargsParam.type) &&
kwargsParam.type.details.typedDictEntries
) {
// Use the relative position in typed dict entries.
const dictIndex = paramIndex - kwargsIndex;
paramName = [...kwargsParam.type.details.typedDictEntries.keys()][dictIndex];
if (kwargsIndex >= 0) {
const kwargsParam = params[kwargsIndex];
if (
isTypedKwargs(kwargsParam) &&
isClassInstance(kwargsParam.type) &&
kwargsParam.type.details.typedDictEntries
) {
// Use the relative position in typed dict entries.
const dictIndex = paramIndex - kwargsIndex;
paramName = [...kwargsParam.type.details.typedDictEntries.keys()][dictIndex];
}
}
parameters.push({