microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-10-26 10:55:06 +03:00
Code Issues Projects Releases Wiki Activity

Fixed regression that prevented module-level code complexity diagnostic from being skipped.

Browse Source
This commit is contained in:
Eric Traut 2022-11-08 21:20:20 -08:00
parent db994ba9ba
commit 95cb1d4a70
1 changed files with 17 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
packages/pyright-internal/src/analyzer/checker.ts
View File

@ -259,6 +259,23 @@ export class Checker extends ParseTreeWalker {
this._conditionallyReportShadowedModule();
// Report code complexity issues for the module.
const codeComplexity = AnalyzerNodeInfo.getCodeFlowComplexity(this._moduleNode);
if (isPrintCodeComplexityEnabled) {
console.log(`Code complexity of module ${this._fileInfo.filePath} is ${codeComplexity.toString()}`);
}
if (codeComplexity > maxCodeComplexity) {
this._evaluator.addDiagnosticForTextRange(
this._fileInfo,
this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues,
DiagnosticRule.reportGeneralTypeIssues,
Localizer.Diagnostic.codeTooComplexToAnalyze(),
{ start: 0, length: 0 }
);
}
this._walkStatementsAndReportUnreachable(this._moduleNode.statements);
// Mark symbols accessed by __all__ as accessed.
@ -306,26 +323,6 @@ export class Checker extends ParseTreeWalker {
return true;
}
override visitModule(node: ModuleNode): boolean {
const codeComplexity = AnalyzerNodeInfo.getCodeFlowComplexity(node);
if (isPrintCodeComplexityEnabled) {
console.log(`Code complexity of module ${this._fileInfo.filePath} is ${codeComplexity.toString()}`);
}
if (codeComplexity > maxCodeComplexity) {
this._evaluator.addDiagnosticForTextRange(
this._fileInfo,
this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues,
DiagnosticRule.reportGeneralTypeIssues,
Localizer.Diagnostic.codeTooComplexToAnalyze(),
{ start: 0, length: 0 }
);
}
return true;
}
override visitClass(node: ClassNode): boolean {
const classTypeResult = this._evaluator.getTypeOfClass(node);