microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-09-11 16:06:39 +03:00
Code Issues Projects Releases Wiki Activity

Added support for early-termination expression type constraints for "or" operator.

Browse Source
This commit is contained in:
Eric Traut 2019-04-27 23:39:36 -07:00
parent 68696e189e
commit a442c60c95
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/analyzer/expressionEvaluator.ts
View File

@ -1903,12 +1903,14 @@ export class ExpressionEvaluator {
// rightExpression won't be evaluated at runtime unless the
// leftExpression evaluates to true.
let typeConstraints: ConditionalTypeConstraintResults | undefined;
if (node.operator === OperatorType.And) {
let useIfConstraint = true;
if (node.operator === OperatorType.And || node.operator === OperatorType.Or) {
typeConstraints = this._buildTypeConstraints(node.leftExpression);
useIfConstraint = node.operator === OperatorType.And;
}
let rightType: Type = UnknownType.create();
this._useExpressionTypeConstraint(typeConstraints, true, () => {
this._useExpressionTypeConstraint(typeConstraints, useIfConstraint, () => {
rightType = this.getType(node.rightExpression);
});