microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-08-16 11:20:22 +03:00
Code Issues Projects Releases Wiki Activity

Fixed bug that results in duplicate and (contradictory) diagnostic outputs in certain cases where reveal_type is used in a loop.

Browse Source
This commit is contained in:
Eric Traut 2024-06-07 14:36:54 -07:00
parent a0af8c5c8c
commit aad860332e
1 changed files with 27 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
packages/pyright-internal/src/analyzer/typeEvaluator.ts
View File

@ -8321,32 +8321,37 @@ export function createTypeEvaluator(
const exprString = ParseTreeUtils.printExpression(arg0Value);
const typeString = printType(type, { expandTypeAlias: true });
if (expectedText !== undefined) {
if (expectedText !== typeString) {
addError(
LocMessage.revealTypeExpectedTextMismatch().format({
expected: expectedText,
received: typeString,
}),
expectedTextNode ?? arg0Value
);
if (!typeResult.isIncomplete) {
if (expectedText !== undefined) {
if (expectedText !== typeString) {
addError(
LocMessage.revealTypeExpectedTextMismatch().format({
expected: expectedText,
received: typeString,
}),
expectedTextNode ?? arg0Value
);
}
}
}
if (expectedRevealType) {
if (!isTypeSame(expectedRevealType, type, { ignorePseudoGeneric: true })) {
const expectedRevealTypeText = printType(expectedRevealType);
addError(
LocMessage.revealTypeExpectedTypeMismatch().format({
expected: expectedRevealTypeText,
received: typeString,
}),
expectedRevealTypeNode ?? arg0Value
);
if (expectedRevealType) {
if (!isTypeSame(expectedRevealType, type, { ignorePseudoGeneric: true })) {
const expectedRevealTypeText = printType(expectedRevealType);
addError(
LocMessage.revealTypeExpectedTypeMismatch().format({
expected: expectedRevealTypeText,
received: typeString,
}),
expectedRevealTypeNode ?? arg0Value
);
}
}
}
addInformation(LocAddendum.typeOfSymbol().format({ name: exprString, type: typeString }), node.arguments[0]);
addInformation(
LocAddendum.typeOfSymbol().format({ name: exprString, type: typeString }),
node.arguments[0]
);
}
return { type, isIncomplete: typeResult.isIncomplete };
}