microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-10-06 12:57:14 +03:00
Code Issues Projects Releases Wiki Activity

Made support for "converter" parameter in dataclass_transform fields non-experimental. This functionality has been approved by the typing council.

Browse Source
This commit is contained in:
Eric Traut 2024-07-19 22:37:48 -07:00
parent bf4c521c67
commit c2a1d6a99a
2 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/pyright-internal/src/analyzer/dataClasses.ts
View File

@ -297,10 +297,7 @@ export function synthesizeDataClassMethods(
(arg) => arg.d.name?.d.value === 'converter'
);
if (converterArg && converterArg.d.valueExpr) {
// Converter support is dependent on PEP 712, which has not yet been approved.
if (AnalyzerNodeInfo.getFileInfo(node).diagnosticRuleSet.enableExperimentalFeatures) {
converter = converterArg;
}
converter = converterArg;
}
}
}

8
packages/pyright-internal/src/tests/typeEvaluator4.test.ts
View File

@ -406,17 +406,13 @@ test('DataClassDescriptors2', () => {
});
test('DataClassConverter1', () => {
const configOptions = new ConfigOptions(Uri.empty());
configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
const analysisResults = TestUtils.typeAnalyzeSampleFiles(['dataclassConverter1.py'], configOptions);
const analysisResults = TestUtils.typeAnalyzeSampleFiles(['dataclassConverter1.py']);
TestUtils.validateResults(analysisResults, 3);
});
test('DataClassConverter2', () => {
const configOptions = new ConfigOptions(Uri.empty());
configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
const analysisResults = TestUtils.typeAnalyzeSampleFiles(['dataclassConverter2.py'], configOptions);
const analysisResults = TestUtils.typeAnalyzeSampleFiles(['dataclassConverter2.py']);
TestUtils.validateResults(analysisResults, 4);
});