microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-09-11 16:06:39 +03:00
Code Issues Projects Releases Wiki Activity

Reverted recent change in for/else statement logic because it introduced a regression.

Browse Source
This commit is contained in:
Eric Traut 2021-02-05 21:56:34 -08:00
parent b7373a2e92
commit df5bf6551b
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/pyright-internal/src/analyzer/binder.ts
View File

@ -882,7 +882,6 @@ export class Binder extends ParseTreeWalker {
this._currentFlowNode = preForLabel;
this._addAntecedent(preElseLabel, this._currentFlowNode);
this._createAssignmentTargetFlowNodes(node.targetExpression, /* walkTargets */ true, /* unbound */ false);
this._addAntecedent(postForLabel, this._currentFlowNode!);
this._bindLoopStatement(preForLabel, postForLabel, () => {
this.walk(node.forSuite);
@ -892,17 +891,8 @@ export class Binder extends ParseTreeWalker {
this._currentFlowNode = this._finishFlowLabel(preElseLabel);
if (node.elseSuite) {
this.walk(node.elseSuite);
// This antecedent should properly be added regardless
// of whether an "else" suite is present because a for
// loop can execute 0 times, in which case the target
// expression will not receive any values, leaving symbols
// potentially unbound after the for statement. However,
// we received many complains from users about false
// positive errors about unbound variables. So we'll add
// this antecedent only if an else suite is present.
this._addAntecedent(postForLabel, this._currentFlowNode);
}
this._addAntecedent(postForLabel, this._currentFlowNode);
this._currentFlowNode = this._finishFlowLabel(postForLabel);