microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-09-11 07:55:56 +03:00
Code Issues Projects Releases Wiki Activity

Fixed bug that resulted in diagnostics associated with the reportUnnecessaryTypeIgnoreComment check to not include the error code. This addresses #7883.

Browse Source
This commit is contained in:
Eric Traut 2024-05-10 16:32:17 -07:00
parent 496e50f65c
commit e654729d96
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
packages/pyright-internal/src/analyzer/sourceFile.ts
View File

@ -1072,9 +1072,9 @@ export class SourceFile {
const range = convertOffsetsToRange(rangeStart, rangeEnd, this._writableData.tokenizerLines!);
if (!isUnreachableCodeRange(range) && this._diagnosticRuleSet.enableTypeIgnoreComments) {
unnecessaryTypeIgnoreDiags.push(
new Diagnostic(diagCategory, LocMessage.unnecessaryTypeIgnore(), range)
);
const diag = new Diagnostic(diagCategory, LocMessage.unnecessaryTypeIgnore(), range);
diag.setRule(DiagnosticRule.reportUnnecessaryTypeIgnoreComment);
unnecessaryTypeIgnoreDiags.push(diag);
}
}
@ -1085,9 +1085,9 @@ export class SourceFile {
const range = convertOffsetsToRange(rangeStart, rangeEnd, this._writableData.tokenizerLines!);
if (!isUnreachableCodeRange(range) && this._diagnosticRuleSet.enableTypeIgnoreComments) {
unnecessaryTypeIgnoreDiags.push(
new Diagnostic(diagCategory, LocMessage.unnecessaryTypeIgnore(), range)
);
const diag = new Diagnostic(diagCategory, LocMessage.unnecessaryTypeIgnore(), range);
diag.setRule(DiagnosticRule.reportUnnecessaryTypeIgnoreComment);
unnecessaryTypeIgnoreDiags.push(diag);
}
}
});
@ -1100,9 +1100,9 @@ export class SourceFile {
const range = convertOffsetsToRange(rangeStart, rangeEnd, this._writableData.tokenizerLines!);
if (!isUnreachableCodeRange(range)) {
unnecessaryTypeIgnoreDiags.push(
new Diagnostic(diagCategory, LocMessage.unnecessaryPyrightIgnore(), range)
);
const diag = new Diagnostic(diagCategory, LocMessage.unnecessaryTypeIgnore(), range);
diag.setRule(DiagnosticRule.reportUnnecessaryTypeIgnoreComment);
unnecessaryTypeIgnoreDiags.push(diag);
}
} else {
ignoreComment.rulesList.forEach((unusedRule) => {
@ -1115,15 +1115,15 @@ export class SourceFile {
);
if (!isUnreachableCodeRange(range)) {
unnecessaryTypeIgnoreDiags.push(
new Diagnostic(
diagCategory,
LocMessage.unnecessaryPyrightIgnoreRule().format({
name: unusedRule.text,
}),
range
)
const diag = new Diagnostic(
diagCategory,
LocMessage.unnecessaryPyrightIgnoreRule().format({
name: unusedRule.text,
}),
range
);
diag.setRule(DiagnosticRule.reportUnnecessaryTypeIgnoreComment);
unnecessaryTypeIgnoreDiags.push(diag);
}
});
}