microsoft/pyright
1
1
Fork 0
mirror of https://github.com/microsoft/pyright.git synced 2024-09-11 16:06:39 +03:00
Code Issues Projects Releases Wiki Activity

Changed reportUnknownParameter to also flag inferred Any return types, not just Unknown.

Browse Source
This commit is contained in:
Eric Traut 2019-04-28 21:17:28 -07:00
parent 1c877e4248
commit f8e9dacccb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/analyzer/typeAnalyzer.ts
View File

@ -358,9 +358,11 @@ export class TypeAnalyzer extends ParseTreeWalker {
inferredReturnType = functionType.getInferredReturnType().getType();
}
if (inferredReturnType instanceof UnknownType) {
// Include Any in this check. If "Any" really is desired, it should
// be made explicit through a type annotation.
if (inferredReturnType.isAny()) {
this._addDiagnostic(this._fileInfo.configOptions.reportUnknownParameter,
`Return type is unknown`, node.name);
`Inferred return type is unknown`, node.name);
} else if (TypeUtils.containsUnknown(inferredReturnType)) {
this._addDiagnostic(this._fileInfo.configOptions.reportUnknownParameter,
`Return type '${ inferredReturnType.asString() }' is partially unknown`,