From ccfe8ba018f57169d4f4c9af8fcbd418eed79cf9 Mon Sep 17 00:00:00 2001 From: Barry Haddow Date: Tue, 10 Nov 2015 21:35:08 +0000 Subject: [PATCH] remove unused method, and misleading comment --- moses/ThreadPool.cpp | 3 --- moses/ThreadPool.h | 3 --- scripts/ems/experiment.meta | 2 +- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/moses/ThreadPool.cpp b/moses/ThreadPool.cpp index cba459697..deb6acb67 100644 --- a/moses/ThreadPool.cpp +++ b/moses/ThreadPool.cpp @@ -55,9 +55,6 @@ void ThreadPool::Execute() } //Execute job if (task) { - // must read from task before run. otherwise task may be deleted by main thread - // race condition - task->DeleteAfterExecution(); task->Run(); } m_threadAvailable.notify_all(); diff --git a/moses/ThreadPool.h b/moses/ThreadPool.h index b7d459bb2..f5be5e52b 100644 --- a/moses/ThreadPool.h +++ b/moses/ThreadPool.h @@ -53,9 +53,6 @@ class Task { public: virtual void Run() = 0; - virtual bool DeleteAfterExecution() { - return true; - } virtual ~Task() {} }; diff --git a/scripts/ems/experiment.meta b/scripts/ems/experiment.meta index 562cf8ec2..29719d878 100644 --- a/scripts/ems/experiment.meta +++ b/scripts/ems/experiment.meta @@ -741,7 +741,7 @@ build-reordering build-ttable in: extracted-phrases lexical-translation-table corpus-mml-prefilter=OR=corpus-mml-postfilter=OR=domains out: phrase-translation-table - rerun-on-change: translation-factors hierarchical-rule-set score-settings training-options script EVALUATION:report-precision-by-coverage include-word-alignment-in-rules domain-features + rerun-on-change: translation-factors hierarchical-rule-set score-settings training-options script include-word-alignment-in-rules domain-features default-name: model/phrase-table ignore-if: suffix-array mmsapt final-model: yes