Commit Graph

68 Commits

Author SHA1 Message Date
MosesAdmin
10531d5f02 daily automatic beautifier 2015-12-12 00:00:41 +00:00
Ulrich Germann
29694af6e4 Code cleanup and refactoring. 2015-12-11 01:09:22 +00:00
Ulrich Germann
fdb5d9b282 Code refactoring: All FF now get access to AllOptions at load time, so they don't have to rely on StaticData. 2015-12-08 12:56:55 +00:00
Ulrich Germann
bcb0212b5b FF registration is now in FeatureFactory::DefaultSetup, ...
... not in the FF constructor any more.

This is related to a bug fix in Base.cpp, related to moving the
LM OOV feature specification from the global space into the setup
of individual LMs (to eliminate the dependence on StaticData in the
LM constructors).
2015-11-24 18:28:38 +00:00
David Madl
0dd6c31f63 FeatureFunction: enable construction without registering 2015-11-17 16:15:13 +00:00
Hieu Hoang
4078c30a42 estimatedScore -> estimatedScores 2015-11-04 15:10:45 +00:00
Hieu Hoang
6be932c1f7 consistent naming of future scores, estimated scores 2015-11-03 09:41:59 +00:00
Hieu Hoang
97b2aa5663 WordsRange -> Range 2015-10-25 13:37:59 +00:00
Hieu Hoang
84b1c4b4c0 WordsBitmap -> Bitmap 2015-10-25 13:07:25 +00:00
Hieu Hoang
efdb8566b1 delete ChangeSource(). Not used 2015-06-02 21:00:32 +04:00
Ulrich Germann
dcb8e5d3e0 Preparation for allowing context-aware decoding. 2015-05-19 02:35:39 +01:00
Hieu Hoang
cc8c6b7b10 beautify 2015-05-02 11:45:24 +01:00
Jeroen Vermeulen
eca5824100 Remove trailing whitespace in C++ files. 2015-04-30 12:05:11 +07:00
Ulrich Germann
e4f5c69109 One step closer to eliminating the requirement to provide num-features=... in the config file.
Some FF (Mmsapt, LexicalReordering, Many single-value FF) provide this number during "registration";
when missing, a default weight vector of uniform 1.0 is automatically generated. This eliminates the
need for the user to figure out what the exact number of features is for each FF, which can get complicated,
e.g. in the case of Mmsapt/PhraseDictionaryBitextSampling.
2015-04-29 20:16:52 +01:00
Ulrich Germann
fbf8b1f8b8 Code design debizarrification: Indexes of feature functions into the dense vector of all feature
values are now stored on the feature function instead of in a global map that is a static
member of ScoreComponentCollection.
2015-04-26 16:46:36 +01:00
Ulrich Germann
e827896027 Harmonized spelling of CleanUpAfterSentenceProcessing(...). 2015-03-26 23:37:29 +00:00
Ulrich Germann
9dc75bfd8a Managers and feature functions now have access to the entire TranslationTask, not just the InputType. 2015-03-26 18:25:54 +00:00
Ulrich Germann
ddf7bc3e23 1. Added FeatureFunction::Setup(TranslationTask const&) const to allow FFs to set themselves up for specific input.
2. FeatureFunction::ChangeSource should not be allow to change the pointer to the source.
2015-03-21 17:09:41 +00:00
Matthias Huck
53ce063214 tuneable-components config parameter for feature functions 2015-02-09 13:52:05 +00:00
Hieu Hoang
ad6f3a8026 option to sort translation options after EvaluateAfterSourceContext 2015-01-22 12:25:02 +01:00
Hieu Hoang
05ead45e71 beautify 2015-01-14 11:07:42 +00:00
Marcin Junczys-Dowmunt
18691c19a3 second attempt at new feature hook, needs review of constness etc. 2015-01-06 13:56:13 +01:00
Marcin Junczys-Dowmunt
f932058af4 Added new feature function hook: EvaluateWithSourceContextCollecton(...) 2015-01-06 10:46:31 +01:00
Hieu Hoang
10d41d025e move collection of DistortionScoreProducer to it own class 2014-12-13 23:19:09 +00:00
Hieu Hoang
31375afa62 Merge pull request #86 from marxin/distortion-scorer-no-dyncast
DistortionFunctionScorer dyn_cast removed in FF.
2014-12-12 12:38:26 +00:00
Matthias Huck
24a8a6a511 PhraseOrientationFeature 2014-12-03 20:04:26 +00:00
mliska
0a264bf5e3 DistortionFunctionScorer dyn_cast removed in FF. 2014-11-29 17:02:10 +01:00
Hieu Hoang
fbbc756117 add virtual void ChangeSource(InputType *&input) const
to FeatureFunction
2014-08-01 22:41:24 +01:00
Barry Haddow
52a1056f9e Cache FNames to make sparse lex reorder faster 2014-07-24 21:23:08 +01:00
Hieu Hoang
587b5fd716 rename Evaluate() to EvaluateWithSourceContext() 2014-07-09 23:06:54 +01:00
Hieu Hoang
c9bd98fb0f rename Evaluate() to EvaluateInIsolation() 2014-07-09 22:35:59 +01:00
Hieu Hoang
31a583b0bc update comments for Evaluate() to say something about stackVec 2014-06-02 18:17:39 +01:00
Hieu Hoang
15566f7fc5 extend FF framework by add StackVec* argument to 2nd Evaluate(). NULL if phrase-based 2014-05-08 17:51:45 +01:00
Hieu Hoang
18aaf4750a destroy feature functions at end. Otherwise it shows up on valgrind as memory leak 2013-12-31 20:15:43 +00:00
Ales Tamchyna
cd63f30f15 modified FF interface: Evaluate() with input has access to future-cost estimation 2013-12-03 16:50:41 +01:00
Hieu Hoang
79fb8a1df4 provide mira program with BLEU Feature. Delete assert statement. 2013-11-15 16:43:39 +00:00
Hieu Hoang
a5f391e3f3 remove description argument from feature function constructor. Redundant 2013-10-29 18:59:53 +00:00
Hieu Hoang
d21e99e444 remove description argument from feature function constructor. Redundant 2013-10-29 17:46:03 +00:00
Hieu Hoang
5625d30a26 add target phrase to arguments for Evaluate() during application to sentence 2013-09-18 12:35:31 +02:00
Hieu Hoang
01b7f8a1e8 add skeleton feature functions 2013-09-01 16:58:23 +01:00
Hieu Hoang
03fd06b38b convert Evaluate() methods into abstract, rather than empty functions. Every FF must implement them all 2013-08-30 15:49:00 +01:00
Hieu Hoang
5625f37eb1 delete ChartBasedFeatureContext 2013-08-23 15:00:47 +01:00
Hieu Hoang
1d653c87aa delete PhraseBasedFeatureContext 2013-08-23 14:25:25 +01:00
Hieu Hoang
073b60db35 implement Evaluate(inputpath, input) for chart translation options. Plumbing for lattice input 2013-08-13 20:47:03 +01:00
Hieu Hoang
8756ad8ffd beautify 2013-08-09 18:17:18 +01:00
Hieu Hoang
15132a04aa comment 2013-08-08 17:58:38 +01:00
Hieu Hoang
9341f28d75 Evaluate(InputType) --> Evaluate(InputType, Phrase source) 2013-08-08 17:35:42 +01:00
Hieu Hoang
9062194f46 comments 2013-08-08 12:26:25 +01:00
Hieu Hoang
8a28178339 add default weights for feature functions that aren't tuneable, eg. OOV feature 2013-07-19 11:35:50 +01:00
Hieu Hoang
d68277d369 redo parsing of feature function parameters 2013-06-20 13:25:02 +01:00