Commit Graph

5352 Commits

Author SHA1 Message Date
Hieu Hoang
ff8caa1226 Merge ../mosesdecoder into perf_moses2 2016-03-28 23:58:20 +01:00
Hieu Hoang
b8bc4a9fb6 use max_partial_trans_opt, not m_max_phrase_length 2016-03-28 23:58:06 +01:00
Lane Schwartz
923532982d Merge branch 'master' of github.com:moses-smt/mosesdecoder 2016-03-24 10:34:27 -05:00
Hieu Hoang
9a560a3d0f recreate lex ro framework from Moses 2016-03-24 13:46:52 +00:00
Kenneth Heafield
31698d5eca Remove deprecated lazyken=0 settings. Should be load instead, but don't specify if it's the default. 2016-03-24 12:58:10 +00:00
MosesAdmin
ab2be02eef daily automatic beautifier 2016-03-24 00:00:47 +00:00
Kenneth Heafield
8a083bc921 Missing #include <set> (which BTW probably shouldn't be used) 2016-03-23 22:46:54 +00:00
Kenneth Heafield
49165a370b Pull out my config structure, still need it to go outside the ConstructOSMLM function 2016-03-23 22:15:14 +00:00
Lane Schwartz
d45b357e11 Merge branch 'master' of github.com:moses-smt/mosesdecoder 2016-03-23 17:03:31 -05:00
Kenneth Heafield
0665cb46e5 Chart decoding is supported by UTIL_THROW2, but not by OpSequenceModel 2016-03-23 21:31:47 +00:00
Kenneth Heafield
90b772734c Delete unnecessary virtual 2016-03-23 21:28:55 +00:00
Lane Schwartz
167def1d52 Merge branch 'master' of github.com:moses-smt/mosesdecoder 2016-03-23 10:26:07 -05:00
Lane Schwartz
8893524339 Fixed bug 2016-03-23 10:25:57 -05:00
Hieu Hoang
356de67a6d Merge ../mosesdecoder into perf_moses2 2016-03-23 15:18:39 +00:00
Hieu Hoang
51300fd897 merge 2016-03-23 15:18:37 +00:00
Hieu Hoang
4c07496eb2 compile error with suffix array 2016-03-23 15:18:20 +00:00
Hieu Hoang
dccaa63b31 rename LexicalReorderingState.h -> LRState.h 2016-03-23 14:37:26 +00:00
Hieu Hoang
fa02a99f13 separate LRModel into its own file 2016-03-23 14:29:32 +00:00
Hieu Hoang
105faa5673 separate BidirectionalReorderingState into its own file 2016-03-23 13:57:25 +00:00
Hieu Hoang
ba9a9b3ef9 separate PhraseBasedReorderingState into its own file 2016-03-23 10:48:16 +00:00
Hieu Hoang
be20f2c149 separate HReorderingBackwardState into its own file 2016-03-23 10:43:55 +00:00
Hieu Hoang
46a94f2258 separate HReorderingForwardState into its own file 2016-03-23 10:38:42 +00:00
Hieu Hoang
3fe5574a95 compiles 2016-03-22 17:51:39 +00:00
Hieu Hoang
95f252aa37 Merge ../mosesdecoder into perf_moses2 2016-03-22 10:20:21 +00:00
David Madl
b760ad8a7e BUGFIX: fix ScoreComponentCollection::ZeroAll(), affecting MIRA
I observed a bug that ScoreComponentCollection core entries would retain their score even after ZeroAll().  This may have affected the Moses implementation of MIRA.

* std::valarray::resize(0) means "resize to 0" [1]
* subsequent accesses using operator[] result in undefined behavior [2]

FeatureVector::clear() is used by ScoreComponentCollection::ZeroAll(), which in turn was used in these places:

./contrib/mira/Main.cpp:665:      cumulativeWeights.ZeroAll();
./contrib/mira/Main.cpp:666:      cumulativeWeightsBinary.ZeroAll();
./moses/Incremental.cpp:580:  features.ZeroAll();

It seems to me that the Moses implementation of MIRA may have been affected?

[1] http://www.cplusplus.com/reference/valarray/valarray/resize/
[2] http://www.cplusplus.com/reference/valarray/valarray/operator%5B%5D/
2016-03-22 10:37:30 +01:00
Michael Denkowski
fa15d60afd Revert "Query member phrase tables in batch mode for forward compatibility"
This reverts commit 2462c81f7a.

Looks like legacy is still the least-breaking way to query phrase tables
2016-03-21 16:44:23 -04:00
Michael Denkowski
2a9034eaec Revert "daily automatic beautifier"
This reverts commit 578d667ca2.
2016-03-21 16:41:49 -04:00
MosesAdmin
578d667ca2 daily automatic beautifier 2016-03-19 00:00:38 +00:00
Michael Denkowski
2462c81f7a Query member phrase tables in batch mode for forward compatibility
Use GetTargetPhraseCollectionBatch instead of GetTargetPhraseCollectionLEGACY
2016-03-18 14:37:46 -04:00
MosesAdmin
e7627e04ed daily automatic beautifier 2016-03-18 00:00:58 +00:00
Matthias Huck
bbf8a615f2 Sparse distortion features
in the manner of:

Spence Green, Michel Galley, Christopher D. Manning. 2010.  Improved
Models of Distortion Cost for Statistical Machine Translation. In NAACL
2010.
2016-03-17 16:10:49 +00:00
Hieu Hoang
f96b48a041 Merge ../mosesdecoder into perf_moses2 2016-03-11 16:38:38 +00:00
Jeroen
ae5ad8a49e Detect write errors in LVoc.
Write failures in LVoc::Write() were going unnoticed.  If disk space
runs out, the output file might get truncated without any indication
of failure.
2016-03-07 18:55:18 +01:00
Hieu Hoang
b9217cec1d Merge ../mosesdecoder into perf_moses2 2016-03-01 11:08:39 +00:00
Matthias Huck
2d6f616480 Merge branch 'master' of https://github.com/moses-smt/mosesdecoder
Conflicts:
	moses/FF/Model1Feature.cpp
2016-02-22 18:30:11 +00:00
Matthias Huck
5c8c15d345 Model1Feature: skip-target-punctuation parameter 2016-02-22 18:28:23 +00:00
MosesAdmin
6da1343f88 daily automatic beautifier 2016-02-22 00:00:40 +00:00
Hieu Hoang
e6bc481ee2 Merge ../mosesdecoder into perf_moses2 2016-02-21 23:09:46 +00:00
Matthias Huck
71a0fcbc27 Model1Feature: skip over target-side punctuation 2016-02-21 20:44:09 +00:00
Matthias Huck
e284503018 Merge branch 'master' of https://github.com/moses-smt/mosesdecoder 2016-02-20 00:40:23 +00:00
Matthias Huck
ebb18b2dc2 WordTranslationFeature: fix loading of word lists 2016-02-20 00:39:02 +00:00
Kenneth Heafield
7a1baeecda load= option to KenLM exposing more load_method options 2016-02-20 00:07:48 +00:00
Hieu Hoang
6a363d893c Merge ../mosesdecoder into perf_moses2 2016-02-17 17:39:51 +00:00
Hieu Hoang
0a1856d510 Merge ../mosesdecoder into perf_moses2 2016-02-17 17:38:07 +00:00
Ales Tamchyna
ca6dba9108 update VW compatibility 2016-02-17 11:27:44 +01:00
Hieu Hoang
0d0f75b6e0 gets right score 2016-02-16 16:03:37 +00:00
MosesAdmin
ca5178b684 daily automatic beautifier 2016-02-13 00:02:04 +00:00
Hieu Hoang
938ef79404 Merge ../mosesdecoder into perf_moses2 2016-02-12 19:40:04 +00:00
Matthias Huck
1659d6b4c8 Option for target constituent constrained phrase extraction. TargetConstituentAdjacencyFeature. 2016-02-12 17:46:57 +00:00
Hieu Hoang
06769e648d Merge ../mosesdecoder into perf_moses2 2016-02-04 13:05:36 +00:00