Commit Graph

328 Commits

Author SHA1 Message Date
Matous Machacek
a77cca4f86 Fixed CderScorer name bug 2012-05-15 00:35:08 +02:00
Matous Machacek
3943112eb3 Fixed bug in SemposScorer.cpp 2012-05-13 11:11:13 +02:00
Matous Machacek
97f82a3e4d Fixed interpolated scorer 2012-05-12 16:11:33 +02:00
Christian Federmann
c360b5a329 Merge remote-tracking branch 'upstream/master' 2012-05-10 09:49:57 +02:00
Tetsuo Kiso
9c9d88a78a Avoid "using namespace std" in headers. 2012-05-10 07:51:05 +09:00
Tetsuo Kiso
aa269bdb4d Merge branch 'master' of github.com:moses-smt/mosesdecoder 2012-05-10 07:31:47 +09:00
Tetsuo Kiso
5f7967402a Reduce compilation dependencies. 2012-05-10 07:16:38 +09:00
Matous Machacek
31edaec4c2 Bigger buffer 2012-05-10 00:08:54 +02:00
Tetsuo Kiso
afa356aec4 Small changes to just improve the quality.
- Use forward declaration to reduce dependencies.
- Add "virtual" to the destructor of _fdstream class.
- Avoid using namespace std in header.
  - We have already used in mert a lot, though. It should be fixed.
- Fix warnings "-Wreorder".
- Fix the usage of enum.
2012-05-10 06:57:44 +09:00
Christian Federmann
c1cf0faf14 GzFileBuf.h got lost in the last merge ;) 2012-05-09 21:52:59 +02:00
Christian Federmann
25f43d13b8 Merged in upstream. 2012-05-09 21:10:52 +02:00
Matous Machacek
440650bd6e Added support for external unix filters to preprocess sentences in mert and evaluator 2012-05-09 19:21:41 +02:00
Tetsuo Kiso
dbfe766f2c Fix using directive refers to implicitly-defined namespace 'std'. 2012-05-06 05:27:04 +09:00
Tetsuo Kiso
b6f55f6bec Fix using namespace "std" before including headers in *.h. 2012-05-06 01:31:04 +09:00
Tetsuo Kiso
1b634488fe Prefix a private member of mert/CderScorer with "m_". 2012-05-03 05:38:35 +09:00
Matous Machacek
933f25b3b2 CderScorer compute both CDER and WER metric 2012-05-02 22:03:58 +02:00
Tetsuo Kiso
7d457f5049 Add TODO to mert/Reference.h. 2012-04-26 05:44:05 +09:00
Tetsuo Kiso
91a6725081 Add a test case for setting up BLEU's reference length.
To make sure the type of effective reference length is
set to the specified arguments.
2012-04-22 20:11:05 +09:00
Tetsuo Kiso
fe79b96328 Use std::stringstream instead of using snprintf() for Windows.
This commit fixes compilation problems related to
snprintf() for Windows users.

Thanks to Raka Prasetya for reporting the errors.
Thanks also to Kenneth Heafield and Barry Haddow for suggestions.
2012-04-18 23:47:48 +09:00
Tetsuo Kiso
408dd72f9d Pass by reference instead of returning objects.
In the previous implementation, copy-constructor got called, which
was not necessary. This commit prevents it, making code more efficient.
2012-04-12 09:40:52 +09:00
Tetsuo Kiso
0e9b5fd9d0 Add const to return values of overloaded operators.
* This commit prevents developers from doing mistakes like:

  Point p1, p2, p4;
  if (p1 + p2 = p4) { // Bang! We actually wanted to compare
                      // the result of two points: (p1 + p2 == p4).
    // do something.
  }

See, e.g., http://www.gotw.ca/gotw/006.htm for details.

* Add more test cases according to this change.
* Move a helper function to compare floating point numbers
  to Util.h.
2012-04-12 09:16:27 +09:00
Tetsuo Kiso
49a4be2899 Reduce the number of calling the numeric_limits constructor.
- Create a test module for Point.
- Add test cases.
2012-04-12 05:19:11 +09:00
Tetsuo Kiso
65dc5a391f Update mert/TODO 2012-04-08 22:47:20 +09:00
Tetsuo Kiso
4c38bbb434 Add things to TODO. 2012-04-08 22:45:04 +09:00
Tetsuo Kiso
d034eeb703 Add test cases for BLEU and sentence-level BLEU+1.
- Move a definition of sentenceLevelBleuPlusOne() from pro.cpp
  to BleuScorer.cpp.
- Add check for the length of an input vector.
2012-04-07 01:02:32 +09:00
Tetsuo Kiso
bcc1958d94 Fix a warning; remove duplicate function calls. 2012-04-05 12:49:49 +09:00
Tetsuo Kiso
fecee1c4fc Fix a grammar error; add more test case.
- Fix a warning, too.
2012-04-05 10:10:16 +09:00
Tetsuo Kiso
e2a92c0f91 Use EndsWith(). 2012-04-05 00:03:13 +09:00
Tetsuo Kiso
20b99ed9e9 Add a test case for EndsWith(). 2012-04-04 22:43:51 +09:00
Tetsuo Kiso
a6cec240c0 Fix typo. 2012-04-04 22:36:22 +09:00
Tetsuo Kiso
eaa0ab486a Add a test case for BLEU's clipped counts.
- Make BleuScorer::setReferenceFiles() more testable by
  adding OpenReference() and OpenReferenceStream().
2012-04-04 22:33:30 +09:00
Tetsuo Kiso
6c69a97cbb Fix a compilation error. 2012-04-04 22:11:43 +09:00
Tetsuo Kiso
27515f5de1 Add a function to check whether a string ends with a suffix.
- Use the function in Data::InitFeatureMap().
- Add an unit test for InitFeatureMap().
- Move helper functions for Data::loadnbest() to public for unit testing.
2012-04-04 22:04:51 +09:00
Tetsuo Kiso
9686e86c70 Fix a warning: comparison between signed and unsigned integers. 2012-03-31 10:47:28 +09:00
Tetsuo Kiso
24b1314d90 Fix indentation. 2012-03-31 10:43:54 +09:00
Tetsuo Kiso
59f755587a Prefix a private member of Optimizer with "m_". 2012-03-31 10:39:59 +09:00
Hieu Hoang
fba75a885e typedef error on mac 2012-03-30 18:33:50 +07:00
tosch
fab03f5a6e added an (optional) positivity constraint to MERT 2012-03-30 11:50:23 +02:00
Matous Machacek
9e5e502687 Merge branch 'master' of github.com:moses-smt/mosesdecoder 2012-03-25 15:51:22 +02:00
Tetsuo Kiso
377d971c5d Use assertions in the test case. 2012-03-25 21:31:44 +09:00
Matous Machacek
1665a23fe1 Added posibility to weight words in sempos 2012-03-24 16:07:47 +01:00
Matous Machacek
ac5ba83ec8 Changed maximum scores constant to be able to experiment with more sempos classes 2012-03-23 23:42:00 +01:00
Tetsuo Kiso
184b24b456 Remove unecessary headers; fix indentation. 2012-03-24 04:12:33 +09:00
Matous Machacek
fbc726dd49 Fixed compilation error 2012-03-23 19:09:04 +01:00
Tetsuo Kiso
5e5f500254 Remove unnecessary headers; prefix private members with "m_".
- Add const.
- Add a virtual destructor to abstract class.
- Add some TODOs to some constant values.

Create files for "overlapping" classes.
2012-03-24 02:39:04 +09:00
Matous Machacek
3319805102 Added SemposScorer to mert and evaluator 2012-03-23 14:39:24 +01:00
Tetsuo Kiso
2f899c9adb Fix a compile error I missed when developing on OS X. 2012-03-21 00:18:44 +09:00
Tetsuo Kiso
0a852b60d1 Move the GzFileBuf implementation into .cpp file.
Add error check when gzopen() fails.
2012-03-21 00:11:54 +09:00
Tetsuo Kiso
91df03e2ed Rename gzfilebuf.h; apply coding style. 2012-03-20 23:48:52 +09:00
Tetsuo Kiso
8e79cd5692 Use assertions in the test case.
It gets easier to detect the point of failure in the test.
2012-03-20 16:57:57 +09:00