From 11a3572144f44d47f254d6a84e91aa26c7900b1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 26 Apr 2024 15:30:51 +0200 Subject: [PATCH] fix(editor): Fix and report `settings` being `null` in workflow payloads (no-changelog) (#9227) --- packages/editor-ui/src/stores/workflows.store.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/editor-ui/src/stores/workflows.store.ts b/packages/editor-ui/src/stores/workflows.store.ts index 2a6efb1894..03876b37c1 100644 --- a/packages/editor-ui/src/stores/workflows.store.ts +++ b/packages/editor-ui/src/stores/workflows.store.ts @@ -82,6 +82,7 @@ import { useUsersStore } from '@/stores/users.store'; import { useSettingsStore } from '@/stores/settings.store'; import { getCredentialOnlyNodeTypeName } from '@/utils/credentialOnlyNodes'; import { i18n } from '@/plugins/i18n'; +import { ErrorReporterProxy as EventReporter } from 'n8n-workflow'; const defaults: Omit & { settings: NonNullable } = { name: '', @@ -1312,6 +1313,12 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, { forceSave = false, ): Promise { const rootStore = useRootStore(); + + if (data.settings === null) { + EventReporter.info('Detected workflow payload with settings as null'); + data.settings = undefined; + } + return await makeRestApiRequest( rootStore.getRestApiContext, 'PATCH', @@ -1322,6 +1329,12 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, { async runWorkflow(startRunData: IStartRunData): Promise { const rootStore = useRootStore(); + + if (startRunData.workflowData.settings === null) { + EventReporter.info('Detected workflow payload with settings as null'); + startRunData.workflowData.settings = undefined; + } + try { return await makeRestApiRequest( rootStore.getRestApiContext,