mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-29 15:14:40 +03:00
fix(core): Delete binary data parent folder when pruning executions (#11790)
This commit is contained in:
parent
91f9390b90
commit
17ef2c63f6
@ -93,7 +93,7 @@ export class FileSystemManager implements BinaryData.Manager {
|
||||
// binary files stored in nested dirs - `filesystem-v2`
|
||||
|
||||
const binaryDataDirs = ids.map(({ workflowId, executionId }) =>
|
||||
this.resolvePath(`workflows/${workflowId}/executions/${executionId}/binary_data/`),
|
||||
this.resolvePath(`workflows/${workflowId}/executions/${executionId}`),
|
||||
);
|
||||
|
||||
await Promise.all(
|
||||
|
@ -147,6 +147,11 @@ describe('copyByFilePath()', () => {
|
||||
});
|
||||
|
||||
describe('deleteMany()', () => {
|
||||
const rmOptions = {
|
||||
force: true,
|
||||
recursive: true,
|
||||
};
|
||||
|
||||
it('should delete many files by workflow ID and execution ID', async () => {
|
||||
const ids = [
|
||||
{ workflowId, executionId },
|
||||
@ -160,6 +165,16 @@ describe('deleteMany()', () => {
|
||||
await expect(promise).resolves.not.toThrow();
|
||||
|
||||
expect(fsp.rm).toHaveBeenCalledTimes(2);
|
||||
expect(fsp.rm).toHaveBeenNthCalledWith(
|
||||
1,
|
||||
`${storagePath}/workflows/${workflowId}/executions/${executionId}`,
|
||||
rmOptions,
|
||||
);
|
||||
expect(fsp.rm).toHaveBeenNthCalledWith(
|
||||
2,
|
||||
`${storagePath}/workflows/${otherWorkflowId}/executions/${otherExecutionId}`,
|
||||
rmOptions,
|
||||
);
|
||||
});
|
||||
|
||||
it('should suppress error on non-existing filepath', async () => {
|
||||
|
Loading…
Reference in New Issue
Block a user