mirror of
https://github.com/n8n-io/n8n.git
synced 2024-10-26 13:29:14 +03:00
Changed empty response to be an additional option
This commit is contained in:
parent
99bc8f9c7b
commit
84ec9857b9
@ -203,9 +203,7 @@ export async function executeWebhook(
|
||||
200,
|
||||
) as number;
|
||||
|
||||
if (
|
||||
!['onReceived', 'lastNode', 'responseNode', 'noBodyResponse'].includes(responseMode as string)
|
||||
) {
|
||||
if (!['onReceived', 'lastNode', 'responseNode'].includes(responseMode as string)) {
|
||||
// If the mode is not known we error. Is probably best like that instead of using
|
||||
// the default that people know as early as possible (probably already testing phase)
|
||||
// that something does not resolve properly.
|
||||
@ -350,14 +348,6 @@ export async function executeWebhook(
|
||||
didSendResponse = true;
|
||||
}
|
||||
|
||||
if (responseMode === 'noBodyResponse' && didSendResponse === false) {
|
||||
responseCallback(null, {
|
||||
responseCode,
|
||||
});
|
||||
|
||||
didSendResponse = true;
|
||||
}
|
||||
|
||||
// Initialize the data of the webhook node
|
||||
const nodeExecutionStack: IExecuteData[] = [];
|
||||
nodeExecutionStack.push({
|
||||
|
@ -147,11 +147,6 @@ export class Webhook implements INodeType {
|
||||
name: 'responseMode',
|
||||
type: 'options',
|
||||
options: [
|
||||
{
|
||||
name: 'Empty body response',
|
||||
value: 'noBodyResponse',
|
||||
description: 'Responds with empty body',
|
||||
},
|
||||
{
|
||||
name: 'Immediately',
|
||||
value: 'onReceived',
|
||||
@ -383,6 +378,20 @@ export class Webhook implements INodeType {
|
||||
default: false,
|
||||
description: 'Raw body (binary)',
|
||||
},
|
||||
{
|
||||
displayName: 'Send empty response',
|
||||
name: 'sendEmptyResponse',
|
||||
type: 'boolean',
|
||||
displayOptions: {
|
||||
show: {
|
||||
'/responseMode': [
|
||||
'onReceived',
|
||||
],
|
||||
},
|
||||
},
|
||||
default: false,
|
||||
description: 'Sets the response body to be empty',
|
||||
},
|
||||
],
|
||||
},
|
||||
],
|
||||
@ -557,6 +566,10 @@ export class Webhook implements INodeType {
|
||||
webhookResponse = options.responseData as string;
|
||||
}
|
||||
|
||||
if (options.sendEmptyResponse) {
|
||||
webhookResponse = '';
|
||||
}
|
||||
|
||||
return {
|
||||
webhookResponse,
|
||||
workflowData: [
|
||||
|
Loading…
Reference in New Issue
Block a user