n8n-io/n8n
1
1
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-11 01:28:58 +03:00
Code Issues Projects Releases Wiki Activity

🐛 Fix draggable memory leak (#2503)

Browse Source 
* attempt fix

* wrap in try catch

* Revert "wrap in try catch"

4b0444747f

* ⚡ Improve comment

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
This commit is contained in:
Mutasem Aldmour 2021-11-30 20:37:55 +01:00 committed by GitHub
parent b005686ecd
commit a550093f3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/editor-ui/src/views/NodeView.vue
View File

@ -2003,10 +2003,8 @@ export default mixins(
this.$store.commit('renameNodeSelectedAndExecution', { old: currentName, new: newName });
// Reset all nodes and connections to load the new ones
if (this.instance) {
// On first load it does not exist
this.instance.deleteEveryEndpoint();
}
this.deleteEveryEndpoint();
this.$store.commit('removeAllConnections');
this.$store.commit('removeAllNodes', {setStateDirty: true});
@ -2020,6 +2018,16 @@ export default mixins(
this.deselectAllNodes();
this.nodeSelectedByName(newName);
},
deleteEveryEndpoint () {
// Check as it does not exist on first load
if (this.instance) {
const nodes = this.$store.getters.allNodes as INodeUi[];
// @ts-ignore
nodes.forEach((node: INodeUi) => this.instance.destroyDraggable(`${NODE_NAME_PREFIX}${this.$store.getters.getNodeIndex(node.name)}`));
this.instance.deleteEveryEndpoint();
}
},
matchCredentials(node: INodeUi) {
if (!node.credentials) {
return;
@ -2336,10 +2344,7 @@ export default mixins(
},
resetWorkspace () {
// Reset nodes
if (this.instance) {
// On first load it does not exist
this.instance.deleteEveryEndpoint();
}
this.deleteEveryEndpoint();
if (this.executionWaitingForWebhook === true) {
// Make sure that if there is a waiting test-webhook that