sq/cli/cli.go
Neil O'Toole 3180334c0c
#199: Config overhaul (#214)
* refactor: partially moved over driver.Tuning params to options

* All knobs moved to options

* sq config edit: now has comments for options

* Major work complete on config/options overhaul

* Major work complete on config/options overhaul

* Updated help text for 'sq version'
2023-05-03 06:36:10 -06:00

284 lines
8.2 KiB
Go

// Package cli implements sq's CLI. The spf13/cobra library
// is used, with some notable modifications.
//
// Although cobra provides excellent functionality, it has some issues.
// Most prominently, its documentation suggests reliance
// upon package-level constructs for initializing the
// command tree (bad for testing).
//
// Thus, this cmd package deviates from cobra's suggested
// usage pattern by eliminating all pkg-level constructs
// (which makes testing easier).
//
// The entry point to this pkg is the Execute function.
package cli
import (
"context"
"errors"
"fmt"
"io"
"os"
"strings"
"sync"
"github.com/spf13/pflag"
"github.com/neilotoole/sq/cli/flag"
"github.com/neilotoole/sq/libsq/core/lg"
"github.com/neilotoole/sq/libsq/core/lg/lga"
"github.com/neilotoole/sq/cli/buildinfo"
"github.com/spf13/cobra"
)
func init() { //nolint:gochecknoinits
cobra.EnableCommandSorting = false
}
// errNoMsg is a sentinel error indicating that a command
// has failed, but that no error message should be printed.
// This is useful in the case where any error information may
// already have been printed as part of the command output.
var errNoMsg = errors.New("")
// Execute builds a RunContext using ctx and default
// settings, and invokes ExecuteWith.
func Execute(ctx context.Context, stdin *os.File, stdout, stderr io.Writer, args []string) error {
rc, log, err := newDefaultRunContext(ctx, stdin, stdout, stderr, args)
if err != nil {
printError(ctx, rc, err)
return err
}
defer rc.Close() // ok to call rc.Close on nil rc
ctx = lg.NewContext(ctx, log)
return ExecuteWith(ctx, rc, args)
}
// ExecuteWith invokes the cobra CLI framework, ultimately
// resulting in a command being executed. The caller must
// invoke rc.Close.
func ExecuteWith(ctx context.Context, rc *RunContext, args []string) error {
log := lg.FromContext(ctx)
log.Debug("EXECUTE", "args", strings.Join(args, " "))
log.Debug("Build info", "build", buildinfo.Info())
log.Debug("Config",
"config.version", rc.Config.Version,
lga.Path, rc.ConfigStore.Location(),
)
ctx = WithRunContext(ctx, rc)
rootCmd := newCommandTree(rc)
var err error
// The following is a workaround for the fact that cobra doesn't
// currently (as of 2017, so yeah, "currently") support executing
// the root command with arbitrary args. That is to say, if you execute:
//
// $ sq @sakila_sl3.actor
//
// then cobra will look for a command named "@sakila_sl3.actor",
// and when it doesn't find such a command, it returns
// an "unknown command" error.
//
// NOTE: This entire mechanism is ancient. Perhaps cobra
// now handles this situation?
// We need to perform handling for autocomplete
if len(args) > 0 && args[0] == "__complete" {
if hasMatchingChildCommand(rootCmd, args[1]) {
// If there is a matching child command, we let rootCmd
// handle it, as per normal.
rootCmd.SetArgs(args)
} else {
// There's no command matching the first argument to __complete.
// Therefore, we assume that we want to perform completion
// for the "slq" command (which is the pseudo-root command).
effectiveArgs := append([]string{"__complete", "slq"}, args[1:]...)
rootCmd.SetArgs(effectiveArgs)
}
} else {
var cmd *cobra.Command
cmd, _, err = rootCmd.Find(args)
if err != nil {
// This err will be the "unknown command" error.
// cobra still returns cmd though. It should be
// the root cmd.
if cmd == nil || cmd.Name() != rootCmd.Name() {
// Not sure if this can happen anymore? Can prob delete?
panic(fmt.Sprintf("bad cobra cmd state: %v", cmd))
}
// If we have args [sq, arg1, arg2] then we redirect
// to the "slq" command by modifying args to
// look like: [query, arg1, arg2] -- noting that SetArgs
// doesn't want the first args element.
effectiveArgs := append([]string{"slq"}, args...)
if effectiveArgs, err = preprocessFlagArgVars(effectiveArgs); err != nil {
return err
}
rootCmd.SetArgs(effectiveArgs)
} else {
if cmd.Name() == rootCmd.Name() {
// Not sure why we have two paths to this, but it appears
// that we've found the root cmd again, so again
// we redirect to "slq" cmd.
effectiveArgs := append([]string{"slq"}, args...)
if effectiveArgs, err = preprocessFlagArgVars(effectiveArgs); err != nil {
return err
}
rootCmd.SetArgs(effectiveArgs)
} else {
// It's just a normal command like "sq ls" or such.
// Explicitly set the args on rootCmd as this makes
// cobra happy when this func is executed via tests.
// Haven't explored the reason why.
rootCmd.SetArgs(args)
}
}
}
// Execute rootCmd; cobra will find the appropriate
// sub-command, and ultimately execute that command.
err = rootCmd.ExecuteContext(ctx)
if err != nil {
printError(ctx, rc, err)
}
return err
}
// cobraMu exists because cobra relies upon package-level
// constructs. This does not sit well with parallel tests.
var cobraMu sync.Mutex
// newCommandTree builds sq's command tree, returning
// the root cobra command.
func newCommandTree(rc *RunContext) (rootCmd *cobra.Command) {
cobraMu.Lock()
defer cobraMu.Unlock()
rootCmd = newRootCmd()
rootCmd.DisableAutoGenTag = true
rootCmd.SetOut(rc.Out)
rootCmd.SetErr(rc.ErrOut)
rootCmd.Flags().SortFlags = false
helpCmd := addCmd(rc, rootCmd, newHelpCmd())
rootCmd.SetHelpCommand(helpCmd)
// logFrom the end user's perspective, slqCmd is *effectively* the
// root cmd. We need to perform some trickery to make it output help
// such that "sq help" and "sq --help" output the same thing.
slqCmd := newSLQCmd()
slqCmd.SetHelpFunc(func(command *cobra.Command, i []string) {
panicOn(rootCmd.Help())
})
addCmd(rc, rootCmd, slqCmd)
addCmd(rc, rootCmd, newSrcAddCmd())
addCmd(rc, rootCmd, newSrcCommand())
addCmd(rc, rootCmd, newGroupCommand())
addCmd(rc, rootCmd, newListCmd())
addCmd(rc, rootCmd, newMoveCmd())
addCmd(rc, rootCmd, newRemoveCmd())
addCmd(rc, rootCmd, newInspectCmd())
addCmd(rc, rootCmd, newPingCmd())
addCmd(rc, rootCmd, newSQLCmd())
addCmd(rc, rootCmd, newScratchCmd())
tblCmd := addCmd(rc, rootCmd, newTblCmd())
addCmd(rc, tblCmd, newTblCopyCmd())
addCmd(rc, tblCmd, newTblTruncateCmd())
addCmd(rc, tblCmd, newTblDropCmd())
driverCmd := addCmd(rc, rootCmd, newDriverCmd())
addCmd(rc, driverCmd, newDriverListCmd())
configCmd := addCmd(rc, rootCmd, newConfigCmd())
addCmd(rc, configCmd, newConfigGetCmd())
addCmd(rc, configCmd, newConfigSetCmd())
addCmd(rc, configCmd, newConfigLocationCmd())
addCmd(rc, configCmd, newConfigEditCmd())
addCmd(rc, rootCmd, newCompletionCmd())
addCmd(rc, rootCmd, newVersionCmd())
addCmd(rc, rootCmd, newManCmd())
return rootCmd
}
// hasMatchingChildCommand returns true if s is a full or prefix
// match for any of cmd's children. For example, if cmd has
// children [inspect, ls, rm], then "insp" or "ls" would return true.
func hasMatchingChildCommand(cmd *cobra.Command, s string) bool {
for _, child := range cmd.Commands() {
if strings.HasPrefix(child.Name(), s) {
return true
}
}
return false
}
// addCmd adds the command returned by cmdFn to parentCmd.
func addCmd(rc *RunContext, parentCmd, cmd *cobra.Command) *cobra.Command {
cmd.Flags().SortFlags = false
if cmd.Name() != "help" {
// Don't add the --help flag to the help command.
cmd.Flags().Bool(flag.Help, false, "help for "+cmd.Name())
}
cmd.DisableAutoGenTag = true
cmd.PreRunE = func(cmd *cobra.Command, args []string) error {
rc.Cmd = cmd
rc.Args = args
err := rc.init(cmd.Context())
return err
}
runE := cmd.RunE
cmd.RunE = func(cmd *cobra.Command, args []string) error {
if cmd.Flags().Changed(flag.Version) {
// Bit of a hack: flag --version on any command
// results in execVersion being invoked
return execVersion(cmd, args)
}
return runE(cmd, args)
}
// We handle the errors ourselves (rather than let cobra do it)
cmd.SilenceErrors = true
cmd.SilenceUsage = true
cmd.Flags().SetNormalizeFunc(applyFlagAliases)
parentCmd.AddCommand(cmd)
return cmd
}
func applyFlagAliases(f *pflag.FlagSet, name string) pflag.NormalizedName {
if f == nil {
return pflag.NormalizedName(name)
}
switch name {
case "table":
// Legacy: flag --text was once named --table.
name = flag.Text
default:
}
return pflag.NormalizedName(name)
}