nickzuber/meteorite
1
1
Fork 0
mirror of https://github.com/nickzuber/meteorite.git synced 2024-11-29 09:31:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve notification syncing

Browse Source
This commit is contained in:
Nicholas Zuber 2018-11-13 19:23:45 -05:00
parent 268804c8e3
commit 356f37d3bb
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/providers/Notifications.js
View File

@ -1,4 +1,5 @@
import React from 'react'; import React from 'react';
import moment from 'moment';
import {AuthConsumer} from './Auth'; import {AuthConsumer} from './Auth';
import {StorageProvider, LOCAL_STORAGE_PREFIX} from './Storage'; import {StorageProvider, LOCAL_STORAGE_PREFIX} from './Storage';
import {Status} from '../constants/status'; import {Status} from '../constants/status';
@ -99,6 +100,15 @@ class NotificationsProvider extends React.Component {
} }
requestPage = (page = 1, optimizePolling = true) => { requestPage = (page = 1, optimizePolling = true) => {
// Fetch all notifications from a month ago, including ones that have been read.
// We can tell in the response if a notification has been read or not, so we can
// properly triage that on our side. We want to fetch from a while back so we can
// learn more information on each notification thread, instead of just jumping in
// the middle of the things you're working on and only having part of the story.
//
// 1 month is pretty arbitrary, we can raise this if we want.
const since = moment().subtract(1, 'month').toISOString().split('.')[0] + 'Z';
const headers = { const headers = {
'Authorization': `token ${this.props.token}`, 'Authorization': `token ${this.props.token}`,
'Content-Type': 'application/json', 'Content-Type': 'application/json',
@ -108,7 +118,7 @@ class NotificationsProvider extends React.Component {
headers['If-Modified-Since'] = this.last_modified; headers['If-Modified-Since'] = this.last_modified;
} }
return fetch(`${BASE_GITHUB_API_URL}/notifications?page=${page}&per_page=${PER_PAGE}`, { return fetch(`${BASE_GITHUB_API_URL}/notifications?page=${page}&per_page=${PER_PAGE}&since=${since}&all=true`, {
method: 'GET', method: 'GET',
headers: headers headers: headers
}) })
@ -198,6 +208,8 @@ class NotificationsProvider extends React.Component {
this.setState({newChanges: processedNotifications}); this.setState({newChanges: processedNotifications});
} }
console.log('everythingUpdated', everythingUpdated);
if (nextPage && everythingUpdated) { if (nextPage && everythingUpdated) {
// Still need to fetch more updates. // Still need to fetch more updates.
return this.requestPage(nextPage, false).then(resolve); return this.requestPage(nextPage, false).then(resolve);
@ -370,7 +382,7 @@ class NotificationsProvider extends React.Component {
id: n.id, id: n.id,
isAuthor: reasons.some(r => r.reason === 'author'), isAuthor: reasons.some(r => r.reason === 'author'),
updated_at: n.updated_at, updated_at: n.updated_at,
status: Status.QUEUED, status: n.unread ? Status.QUEUED : Status.STAGED,
reasons: reasons, reasons: reasons,
type: n.subject.type, type: n.subject.type,
name: n.subject.title, name: n.subject.title,