nicolargo/glances
1
1
Fork 0
mirror of https://github.com/nicolargo/glances.git synced 2024-09-21 01:28:04 +03:00
Code Issues Projects Releases Wiki Activity

fix: fix unit testing on macOS

Browse Source 
In test_017_programs, the following exception may occur:

TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'

This commit fixes this exception by giving a default value for None.
This commit is contained in:
Jiajie Chen 2022-07-09 16:32:59 +08:00
parent 5a44de0080
commit c8f6e4d1bc
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
glances/programs.py
View File

@ -23,12 +23,13 @@ def processes_to_programs(processes):
# Create a new entry in the dict (new program)
programs_dict[p[key]] = {
'time_since_update': p['time_since_update'],
'num_threads': p['num_threads'],
'cpu_percent': p['cpu_percent'],
'memory_percent': p['memory_percent'],
'cpu_times': p['cpu_times'],
'memory_info': p['memory_info'],
'io_counters': p['io_counters'],
# some values can be None, e.g. macOS system processes
'num_threads': p['num_threads'] or 0,
'cpu_percent': p['cpu_percent'] or 0,
'memory_percent': p['memory_percent'] or 0,
'cpu_times': p['cpu_times'] or (),
'memory_info': p['memory_info'] or (),
'io_counters': p['io_counters'] or (),
'childrens': [p['pid']],
# Others keys are not used
# but should be set to be compliant with the existing process_list
@ -41,11 +42,13 @@ def processes_to_programs(processes):
}
else:
# Update a existing entry in the dict (existing program)
programs_dict[p[key]]['num_threads'] += p['num_threads']
programs_dict[p[key]]['cpu_percent'] += p['cpu_percent']
programs_dict[p[key]]['memory_percent'] += p['memory_percent']
programs_dict[p[key]]['cpu_times'] += p['cpu_times']
programs_dict[p[key]]['memory_info'] += p['memory_info']
# some values can be None, e.g. macOS system processes
programs_dict[p[key]]['num_threads'] += p['num_threads'] or 0
programs_dict[p[key]]['cpu_percent'] += p['cpu_percent'] or 0
programs_dict[p[key]]['memory_percent'] += p['memory_percent'] or 0
programs_dict[p[key]]['cpu_times'] += p['cpu_times'] or ()
programs_dict[p[key]]['memory_info'] += p['memory_info'] or ()
programs_dict[p[key]]['io_counters'] += p['io_counters']
programs_dict[p[key]]['childrens'].append(p['pid'])
# If all the subprocess has the same value, display it

2
unitest.py
View File

@ -277,7 +277,7 @@ class TestGlances(unittest.TestCase):
def test_017_programs(self):
"""Check Programs function (it's not a plugin)."""
# stats_to_check = [ ]
print('INFO: [TEST_010] Check PROGRAM stats')
print('INFO: [TEST_017] Check PROGRAM stats')
stats_grab = processes_to_programs(stats.get_plugin('processlist').get_raw())
self.assertTrue(type(stats_grab) is list, msg='Programs stats is not a list')
print('INFO: PROGRAM list stats: %s items in the list' % len(stats_grab))