Merge pull request #196 from nix-community/types-compact

This commit is contained in:
Lassulus 2023-04-15 15:44:33 +02:00 committed by GitHub
commit 6cbfde5b50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
28 changed files with 237 additions and 298 deletions

View File

@ -1,3 +1,15 @@
2023-04-07 7d70009
zfs_datasets are now split into zfs_fs and zfs_volume. zfs_type got removed. size is only available for zfs_volume
2023-04-07 654ecb3
lvm_lv types are always part of a lvm_vg and it is no longer possible (and neccessary) to specify the type
2023-04-07 d6f062e
parition types are always part of a table and it is no longer possible (and neccessary) to specify the type
2023-03-22 2624af6
disk config now needs to be inside a disko.devices attrset always

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "100MiB";
@ -22,7 +21,6 @@
}
{
name = "root";
type = "partition";
start = "100MiB";
end = "100%";
part-type = "primary";

View File

@ -10,14 +10,12 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
part-type = "primary";
flags = [ "bios_grub" ];
}
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "128MiB";
@ -29,7 +27,6 @@
};
}
{
type = "partition";
name = "mdadm";
start = "128MiB";
end = "100%";
@ -50,14 +47,12 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
part-type = "primary";
flags = [ "bios_grub" ];
}
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "128MiB";
@ -69,7 +64,6 @@
};
}
{
type = "partition";
name = "mdadm";
start = "128MiB";
end = "100%";
@ -101,7 +95,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "primary";
start = "1MiB";
end = "100%";

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "128MiB";
@ -23,7 +22,6 @@
}
{
name = "root";
type = "partition";
start = "128MiB";
end = "100%";
content = {

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "128MiB";
@ -32,7 +31,6 @@
format = "gpt";
partitions = [
{
type = "partition";
start = "1M";
end = "100%";
name = "luks";
@ -60,7 +58,6 @@
format = "gpt";
partitions = [
{
type = "partition";
start = "1M";
end = "100%";
name = "luks";
@ -90,7 +87,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "bla";
start = "1MiB";
end = "100%";
@ -109,7 +105,6 @@
type = "lvm_vg";
lvs = {
root = {
type = "lvm_lv";
size = "10M";
lvm_type = "mirror";
content = {
@ -122,7 +117,6 @@
};
};
raid1 = {
type = "lvm_lv";
size = "30M";
lvm_type = "raid0";
content = {
@ -131,7 +125,6 @@
};
};
raid2 = {
type = "lvm_lv";
size = "30M";
lvm_type = "raid0";
content = {
@ -140,7 +133,6 @@
};
};
zfs1 = {
type = "lvm_lv";
size = "128M";
lvm_type = "raid0";
content = {
@ -149,7 +141,6 @@
};
};
zfs2 = {
type = "lvm_lv";
size = "128M";
lvm_type = "raid0";
content = {
@ -172,21 +163,21 @@
datasets = {
zfs_fs = {
zfs_type = "filesystem";
type = "zfs_fs";
mountpoint = "/zfs_fs";
options."com.sun:auto-snapshot" = "true";
};
zfs_unmounted_fs = {
zfs_type = "filesystem";
type = "zfs_fs";
options.mountpoint = "none";
};
zfs_legacy_fs = {
zfs_type = "filesystem";
type = "zfs_fs";
options.mountpoint = "legacy";
mountpoint = "/zfs_legacy_fs";
};
zfs_testvolume = {
zfs_type = "volume";
type = "zfs_volume";
size = "10M";
content = {
type = "filesystem";

View File

@ -11,7 +11,6 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
part-type = "primary";
@ -19,7 +18,6 @@
}
{
name = "root";
type = "partition";
# leave space for the grub aka BIOS boot
start = "1M";
end = "100%";

View File

@ -9,13 +9,11 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
flags = [ "bios_grub" ];
}
{
type = "partition";
name = "ESP";
start = "1M";
end = "512M";
@ -28,7 +26,6 @@
}
{
name = "nix";
type = "partition";
start = "512M";
end = "100%";
part-type = "primary";

View File

@ -10,13 +10,11 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
flags = [ "bios_grub" ];
}
{
type = "partition";
name = "ESP";
start = "1M";
end = "512M";
@ -28,7 +26,6 @@
};
}
{
type = "partition";
name = "root";
start = "512M";
end = "100%";

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "100MiB";
@ -24,7 +23,6 @@
};
}
{
type = "partition";
name = "luks";
start = "100MiB";
end = "100%";
@ -48,7 +46,6 @@
type = "lvm_vg";
lvs = {
root = {
type = "lvm_lv";
size = "100M";
content = {
type = "filesystem";
@ -60,7 +57,6 @@
};
};
home = {
type = "lvm_lv";
size = "10M";
content = {
type = "filesystem";
@ -69,7 +65,6 @@
};
};
raw = {
type = "lvm_lv";
size = "10M";
};
};

View File

@ -10,7 +10,6 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "100M";
fs-type = "fat32";
@ -21,7 +20,6 @@
};
}
{
type = "partition";
name = "primary";
start = "100M";
end = "100%";
@ -42,7 +40,6 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "100M";
fs-type = "fat32";
@ -53,7 +50,6 @@
};
}
{
type = "partition";
name = "primary";
start = "100M";
end = "100%";
@ -83,7 +79,6 @@
type = "lvm_vg";
lvs = {
root = {
type = "lvm_lv";
size = "100M";
lvm_type = "mirror";
content = {
@ -96,7 +91,6 @@
};
};
home = {
type = "lvm_lv";
size = "10M";
lvm_type = "raid0";
content = {

View File

@ -10,14 +10,12 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
part-type = "primary";
flags = [ "bios_grub" ];
}
{
type = "partition";
name = "mdadm";
start = "1MiB";
end = "100%";
@ -38,14 +36,12 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
part-type = "primary";
flags = [ "bios_grub" ];
}
{
type = "partition";
name = "mdadm";
start = "1MiB";
end = "100%";
@ -67,7 +63,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "primary";
start = "1MiB";
end = "100%";

View File

@ -10,7 +10,6 @@
partitions = [
{
name = "nix";
type = "partition";
part-type = "primary";
start = "0%";
end = "100%";
@ -33,7 +32,6 @@
partitions = [
{
name = "root";
type = "partition";
part-type = "primary";
start = "0%";
end = "100%";

View File

@ -10,7 +10,6 @@
partitions = [
{
name = "nix";
type = "partition";
part-type = "primary";
start = "0%";
end = "-10MiB";

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "100MiB";
@ -22,7 +21,6 @@
}
{
name = "root";
type = "partition";
start = "100MiB";
end = "100%";
part-type = "primary";

View File

@ -25,7 +25,6 @@ let
partitions = [
{
name = "root";
type = "partition";
part-type = "primary";
start = "1M";
end = "100%";

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "100MiB";
@ -22,7 +21,6 @@
}
{
name = "root";
type = "partition";
start = "100MiB";
end = "-1G";
part-type = "primary";
@ -34,7 +32,6 @@
}
{
name = "swap";
type = "partition";
start = "-1G";
end = "100%";
part-type = "primary";

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "100MiB";
@ -22,7 +21,6 @@
}
{
name = "root";
type = "partition";
start = "100MiB";
end = "100%";
part-type = "primary";

View File

@ -10,7 +10,6 @@
partitions = [
{
name = "boot";
type = "partition";
start = "0";
end = "1M";
part-type = "primary";
@ -18,7 +17,6 @@
}
{
name = "root";
type = "partition";
# leave space for the grub aka BIOS boot
start = "1M";
end = "100%";

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "1MiB";
end = "100MiB";
@ -24,7 +23,6 @@
};
}
{
type = "partition";
start = "100MiB";
end = "100%";
name = "primary";
@ -52,11 +50,11 @@
type = "zpool";
datasets = {
"root" = {
zfs_type = "filesystem";
type = "zfs_fs";
options.mountpoint = "none";
};
"root/zfs_fs" = {
zfs_type = "filesystem";
type = "zfs_fs";
mountpoint = "/zfs_fs";
options."com.sun:auto-snapshot" = "true";
};

View File

@ -9,7 +9,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "ESP";
start = "0";
end = "64MiB";
@ -22,7 +21,6 @@
};
}
{
type = "partition";
name = "zfs";
start = "128MiB";
end = "100%";
@ -42,7 +40,6 @@
format = "gpt";
partitions = [
{
type = "partition";
name = "zfs";
start = "128MiB";
end = "100%";
@ -68,21 +65,21 @@
datasets = {
zfs_fs = {
zfs_type = "filesystem";
type = "zfs_fs";
mountpoint = "/zfs_fs";
options."com.sun:auto-snapshot" = "true";
};
zfs_unmounted_fs = {
zfs_type = "filesystem";
type = "zfs_fs";
options.mountpoint = "none";
};
zfs_legacy_fs = {
zfs_type = "filesystem";
type = "zfs_fs";
options.mountpoint = "legacy";
mountpoint = "/zfs_legacy_fs";
};
zfs_testvolume = {
zfs_type = "volume";
type = "zfs_volume";
size = "10M";
content = {
type = "filesystem";
@ -91,8 +88,7 @@
};
};
encrypted = {
zfs_type = "filesystem";
size = "20M";
type = "zfs_fs";
options = {
mountpoint = "none";
encryption = "aes-256-gcm";
@ -104,8 +100,7 @@
'';
};
"encrypted/test" = {
zfs_type = "filesystem";
size = "2M";
type = "zfs_fs";
mountpoint = "/zfs_crypted";
};
};

View File

@ -133,7 +133,7 @@ rec {
|| lib.hasSuffix "Hook" n
|| isAttrsOfSubmodule o
# TODO don't hardcode diskoLib.subType options.
|| n == "content" || n == "partitions"
|| n == "content" || n == "partitions" || n == "datasets"
);
in
lib.toShellVars
@ -342,14 +342,14 @@ rec {
btrfs_subvol = ./btrfs_subvol.nix;
filesystem = ./filesystem.nix;
table = ./table.nix;
partition = ./partition.nix;
swap = ./swap.nix;
lvm_pv = ./lvm_pv.nix;
lvm_vg = ./lvm_vg.nix;
lvm_lv = ./lvm_lv.nix;
zfs = ./zfs.nix;
zpool = ./zpool.nix;
zfs_dataset = ./zfs_dataset.nix;
zfs_fs = ./zfs_fs.nix;
zfs_volume = ./zfs_volume.nix;
mdadm = ./mdadm.nix;
mdraid = ./mdraid.nix;
luks = ./luks.nix;

View File

@ -1,76 +0,0 @@
{ config, options, lib, diskoLib, ... }:
{
options = {
name = lib.mkOption {
type = lib.types.str;
default = config._module.args.name;
description = "Name of the logical volume";
};
type = lib.mkOption {
type = lib.types.enum [ "lvm_lv" ];
default = "lvm_lv";
internal = true;
description = "Type";
};
size = lib.mkOption {
type = lib.types.str; # TODO lvm size type
description = "Size of the logical volume";
};
lvm_type = lib.mkOption {
type = lib.types.nullOr (lib.types.enum [ "mirror" "raid0" "raid1" ]); # TODO add all lib.types
default = null; # maybe there is always a default type?
description = "LVM type";
};
extraArgs = lib.mkOption {
type = lib.types.listOf lib.types.str;
default = [ ];
description = "Extra arguments";
};
content = diskoLib.partitionType;
_meta = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo diskoLib.jsonType;
default = dev:
lib.optionalAttrs (config.content != null) (config.content._meta dev);
description = "Metadata";
};
_create = diskoLib.mkCreateOption {
inherit config options;
default = { vg }: ''
lvcreate \
--yes \
${if lib.hasInfix "%" config.size then "-l" else "-L"} ${config.size} \
-n ${config.name} \
${lib.optionalString (config.lvm_type != null) "--type=${config.lvm_type}"} \
${toString config.extraArgs} \
${vg}
${lib.optionalString (config.content != null) (config.content._create {dev = "/dev/${vg}/${config.name}";})}
'';
};
_mount = diskoLib.mkMountOption {
inherit config options;
default = { vg }:
lib.optionalAttrs (config.content != null) (config.content._mount { dev = "/dev/${vg}/${config.name}"; });
};
_config = lib.mkOption {
internal = true;
readOnly = true;
default = vg:
[
(lib.optional (config.content != null) (config.content._config "/dev/${vg}/${config.name}"))
(lib.optional (config.lvm_type != null) {
boot.initrd.kernelModules = [ "dm-${config.lvm_type}" ];
})
];
description = "NixOS configuration";
};
_pkgs = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo (lib.types.listOf lib.types.package);
default = pkgs: lib.optionals (config.content != null) (config.content._pkgs pkgs);
description = "Packages";
};
};
}

View File

@ -12,7 +12,30 @@
description = "Type";
};
lvs = lib.mkOption {
type = lib.types.attrsOf subTypes.lvm_lv;
type = lib.types.attrsOf (lib.types.submodule ({ config, ... }: {
options = {
name = lib.mkOption {
type = lib.types.str;
default = config._module.args.name;
description = "Name of the logical volume";
};
size = lib.mkOption {
type = lib.types.str; # TODO lvm size type
description = "Size of the logical volume";
};
lvm_type = lib.mkOption {
type = lib.types.nullOr (lib.types.enum [ "mirror" "raid0" "raid1" ]); # TODO add all lib.types
default = null; # maybe there is always a default type?
description = "LVM type";
};
extraArgs = lib.mkOption {
type = lib.types.listOf lib.types.str;
default = [ ];
description = "Extra arguments";
};
content = diskoLib.partitionType;
};
}));
default = { };
description = "LVS for the volume group";
};
@ -21,7 +44,9 @@
readOnly = true;
type = diskoLib.jsonType;
default =
diskoLib.deepMergeMap (lv: lv._meta [ "lvm_vg" config.name ]) (lib.attrValues config.lvs);
diskoLib.deepMergeMap (lv:
lib.optionalAttrs (lv.content != null) (lv.content._meta [ "lvm_vg" config.name ])
) (lib.attrValues config.lvs);
description = "Metadata";
};
_create = diskoLib.mkCreateOption {
@ -30,14 +55,25 @@
readarray -t lvm_devices < <(cat "$disko_devices_dir"/lvm_${config.name})
vgcreate ${config.name} \
"''${lvm_devices[@]}"
${lib.concatMapStrings (lv: lv._create {vg = config.name; }) (lib.attrValues config.lvs)}
${lib.concatMapStrings (lv: ''
lvcreate \
--yes \
${if lib.hasInfix "%" lv.size then "-l" else "-L"} ${lv.size} \
-n ${lv.name} \
${lib.optionalString (lv.lvm_type != null) "--type=${lv.lvm_type}"} \
${toString lv.extraArgs} \
${config.name}
${lib.optionalString (lv.content != null) (lv.content._create {dev = "/dev/${config.name}/${lv.name}";})}
'') (lib.attrValues config.lvs)}
'';
};
_mount = diskoLib.mkMountOption {
inherit config options;
default = _:
let
lvMounts = diskoLib.deepMergeMap (lv: lv._mount { vg = config.name; }) (lib.attrValues config.lvs);
lvMounts = diskoLib.deepMergeMap (lv:
lib.optionalAttrs (lv.content != null) (lv.content._mount { dev = "/dev/${config.name}/${lv.name}"; })
) (lib.attrValues config.lvs);
in
{
dev = ''
@ -51,14 +87,21 @@
internal = true;
readOnly = true;
default =
map (lv: lv._config config.name) (lib.attrValues config.lvs);
map (lv: [
(lib.optional (lv.content != null) (lv.content._config "/dev/${config.name}/${lv.name}"))
(lib.optional (lv.lvm_type != null) {
boot.initrd.kernelModules = [ "dm-${lv.lvm_type}" ];
})
]) (lib.attrValues config.lvs);
description = "NixOS configuration";
};
_pkgs = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo (lib.types.listOf lib.types.package);
default = pkgs: lib.flatten (map (lv: lv._pkgs pkgs) (lib.attrValues config.lvs));
default = pkgs: lib.flatten (map (lv:
lib.optional (lv.content != null) (lv.content._pkgs pkgs)
) (lib.attrValues config.lvs));
description = "Packages";
};
};

View File

@ -1,100 +0,0 @@
{ config, options, lib, diskoLib, ... }:
{
options = {
type = lib.mkOption {
type = lib.types.enum [ "partition" ];
internal = true;
description = "Type";
};
part-type = lib.mkOption {
type = lib.types.enum [ "primary" "logical" "extended" ];
default = "primary";
description = "Partition type";
};
fs-type = lib.mkOption {
type = lib.types.nullOr (lib.types.enum [ "btrfs" "ext2" "ext3" "ext4" "fat16" "fat32" "hfs" "hfs+" "linux-swap" "ntfs" "reiserfs" "udf" "xfs" ]);
default = null;
description = "Filesystem type to use";
};
name = lib.mkOption {
type = lib.types.nullOr lib.types.str;
description = "Name of the partition";
};
start = lib.mkOption {
type = lib.types.str;
default = "0%";
description = "Start of the partition";
};
end = lib.mkOption {
type = lib.types.str;
default = "100%";
description = "End of the partition";
};
index = lib.mkOption {
type = lib.types.int;
# TODO find a better way to get the index
default = lib.toInt (lib.head (builtins.match ".*entry ([[:digit:]]+)]" config._module.args.name));
description = "Index of the partition";
};
flags = lib.mkOption {
type = lib.types.listOf lib.types.str;
default = [ ];
description = "Partition flags";
};
bootable = lib.mkOption {
type = lib.types.bool;
default = false;
description = "Whether to make the partition bootable";
};
content = diskoLib.partitionType;
_meta = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo diskoLib.jsonType;
default = dev:
lib.optionalAttrs (config.content != null) (config.content._meta dev);
description = "Metadata";
};
_create = diskoLib.mkCreateOption {
inherit config options;
default = { dev, type }: ''
${lib.optionalString (type == "gpt") ''
parted -s ${dev} -- mkpart ${config.name} ${diskoLib.maybeStr config.fs-type} ${config.start} ${config.end}
''}
${lib.optionalString (type == "msdos") ''
parted -s ${dev} -- mkpart ${config.part-type} ${diskoLib.maybeStr config.fs-type} ${diskoLib.maybeStr config.fs-type} ${config.start} ${config.end}
''}
# ensure /dev/disk/by-path/..-partN exists before continuing
udevadm trigger --subsystem-match=block; udevadm settle
${lib.optionalString config.bootable ''
parted -s ${dev} -- set ${toString config.index} boot on
''}
${lib.concatMapStringsSep "" (flag: ''
parted -s ${dev} -- set ${toString config.index} ${flag} on
'') config.flags}
# ensure further operations can detect new partitions
udevadm trigger --subsystem-match=block; udevadm settle
${lib.optionalString (config.content != null) (config.content._create {dev = diskoLib.deviceNumbering dev config.index;})}
'';
};
_mount = diskoLib.mkMountOption {
inherit config options;
default = { dev }:
lib.optionalAttrs (config.content != null) (config.content._mount { dev = diskoLib.deviceNumbering dev config.index; });
};
_config = lib.mkOption {
internal = true;
readOnly = true;
default = dev:
lib.optional (config.content != null) (config.content._config (diskoLib.deviceNumbering dev config.index));
description = "NixOS configuration";
};
_pkgs = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo (lib.types.listOf lib.types.package);
default = pkgs: lib.optionals (config.content != null) (config.content._pkgs pkgs);
description = "Packages";
};
};
}

View File

@ -12,7 +12,51 @@
description = "The kind of partition table";
};
partitions = lib.mkOption {
type = lib.types.listOf subTypes.partition;
type = lib.types.listOf (lib.types.submodule ({ config, ... }: {
options = {
part-type = lib.mkOption {
type = lib.types.enum [ "primary" "logical" "extended" ];
default = "primary";
description = "Partition type";
};
fs-type = lib.mkOption {
type = lib.types.nullOr (lib.types.enum [ "btrfs" "ext2" "ext3" "ext4" "fat16" "fat32" "hfs" "hfs+" "linux-swap" "ntfs" "reiserfs" "udf" "xfs" ]);
default = null;
description = "Filesystem type to use";
};
name = lib.mkOption {
type = lib.types.nullOr lib.types.str;
description = "Name of the partition";
};
start = lib.mkOption {
type = lib.types.str;
default = "0%";
description = "Start of the partition";
};
end = lib.mkOption {
type = lib.types.str;
default = "100%";
description = "End of the partition";
};
index = lib.mkOption {
type = lib.types.int;
# TODO find a better way to get the index
default = lib.toInt (lib.head (builtins.match ".*entry ([[:digit:]]+)]" config._module.args.name));
description = "Index of the partition";
};
flags = lib.mkOption {
type = lib.types.listOf lib.types.str;
default = [ ];
description = "Partition flags";
};
bootable = lib.mkOption {
type = lib.types.bool;
default = false;
description = "Whether to make the partition bootable";
};
content = diskoLib.partitionType;
};
}));
default = [ ];
description = "List of partitions to add to the partition table";
};
@ -21,21 +65,43 @@
readOnly = true;
type = lib.types.functionTo diskoLib.jsonType;
default = dev:
diskoLib.deepMergeMap (partition: partition._meta dev) config.partitions;
lib.foldr lib.recursiveUpdate {} (lib.imap (index: partition:
lib.optionalAttrs (partition.content != null) (partition.content._meta dev)
) config.partitions);
description = "Metadata";
};
_create = diskoLib.mkCreateOption {
inherit config options;
default = { dev }: ''
parted -s ${dev} -- mklabel ${config.format}
${lib.concatMapStrings (partition: partition._create {inherit dev; type = config.format;} ) config.partitions}
${lib.concatStrings (lib.imap (index: partition: ''
${lib.optionalString (config.format == "gpt") ''
parted -s ${dev} -- mkpart ${partition.name} ${diskoLib.maybeStr partition.fs-type} ${partition.start} ${partition.end}
''}
${lib.optionalString (config.format == "msdos") ''
parted -s ${dev} -- mkpart ${partition.part-type} ${diskoLib.maybeStr partition.fs-type} ${diskoLib.maybeStr partition.fs-type} ${partition.start} ${partition.end}
''}
# ensure /dev/disk/by-path/..-partN exists before continuing
udevadm trigger --subsystem-match=block; udevadm settle
${lib.optionalString partition.bootable ''
parted -s ${dev} -- set ${toString index} boot on
''}
${lib.concatMapStringsSep "" (flag: ''
parted -s ${dev} -- set ${toString index} ${flag} on
'') partition.flags}
# ensure further operations can detect new partitions
udevadm trigger --subsystem-match=block; udevadm settle
${lib.optionalString (partition.content != null) (partition.content._create { dev = diskoLib.deviceNumbering dev index; })}
'') config.partitions)}
'';
};
_mount = diskoLib.mkMountOption {
inherit config options;
default = { dev }:
let
partMounts = diskoLib.deepMergeMap (partition: partition._mount { inherit dev; }) config.partitions;
partMounts = lib.foldr lib.recursiveUpdate {} (lib.imap (index: partition:
lib.optionalAttrs (partition.content != null) (partition.content._mount { dev = diskoLib.deviceNumbering dev index; })
) config.partitions);
in
{
dev = partMounts.dev or "";
@ -46,7 +112,9 @@
internal = true;
readOnly = true;
default = dev:
map (partition: partition._config dev) config.partitions;
lib.imap (index: partition:
lib.optional (partition.content != null) (partition.content._config (diskoLib.deviceNumbering dev index))
) config.partitions;
description = "NixOS configuration";
};
_pkgs = lib.mkOption {
@ -54,7 +122,9 @@
readOnly = true;
type = lib.types.functionTo (lib.types.listOf lib.types.package);
default = pkgs:
[ pkgs.parted pkgs.systemdMinimal ] ++ lib.flatten (map (partition: partition._pkgs pkgs) config.partitions);
[ pkgs.parted pkgs.systemdMinimal ] ++ lib.flatten (map (partition:
lib.optional (partition.content != null) (partition.content._pkgs pkgs)
) config.partitions);
description = "Packages";
};
};

View File

@ -7,15 +7,11 @@
description = "Name of the dataset";
};
type = lib.mkOption {
type = lib.types.enum [ "zfs_dataset" ];
default = "zfs_dataset";
type = lib.types.enum [ "zfs_fs" ];
default = "zfs_fs";
internal = true;
description = "Type";
};
zfs_type = lib.mkOption {
type = lib.types.enum [ "filesystem" "volume" ];
description = "The type of the dataset";
};
options = lib.mkOption {
type = lib.types.attrsOf lib.types.str;
default = { };
@ -27,46 +23,30 @@
description = "Mount options";
};
# filesystem options
mountpoint = lib.mkOption {
type = lib.types.nullOr optionTypes.absolute-pathname;
default = null;
description = "Path to mount the dataset to";
};
# volume options
size = lib.mkOption {
type = lib.types.nullOr lib.types.str; # TODO size
default = null;
description = "Size of the dataset";
};
content = diskoLib.partitionType;
_meta = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo diskoLib.jsonType;
default = dev:
lib.optionalAttrs (config.content != null) (config.content._meta dev);
default = dev: {};
description = "Metadata";
};
_create = diskoLib.mkCreateOption {
inherit config options;
default = { zpool }: ''
zfs create ${zpool}/${config.name} \
${lib.concatStringsSep " " (lib.mapAttrsToList (n: v: "-o ${n}=${v}") config.options)} \
${lib.optionalString (config.zfs_type == "volume") "-V ${config.size}"}
${lib.optionalString (config.zfs_type == "volume") ''
udevadm trigger --subsystem-match=block; udevadm settle
${lib.optionalString (config.content != null) (config.content._create {dev = "/dev/zvol/${zpool}/${config.name}";})}
''}
${lib.concatStringsSep " " (lib.mapAttrsToList (n: v: "-o ${n}=${v}") config.options)}
'';
};
_mount = diskoLib.mkMountOption {
inherit config options;
default = { zpool }:
lib.optionalAttrs (config.zfs_type == "volume" && config.content != null) (config.content._mount { dev = "/dev/zvol/${zpool}/${config.name}"; }) //
lib.optionalAttrs (config.zfs_type == "filesystem" && config.options.mountpoint or "" != "none") {
lib.optionalAttrs (config.options.mountpoint or "" != "none") {
fs.${config.mountpoint} = ''
if ! findmnt ${zpool}/${config.name} "${rootMountPoint}${config.mountpoint}" > /dev/null 2>&1; then
mount ${zpool}/${config.name} "${rootMountPoint}${config.mountpoint}" \
@ -82,22 +62,22 @@
internal = true;
readOnly = true;
default = zpool:
(lib.optional (config.zfs_type == "volume" && config.content != null) (config.content._config "/dev/zvol/${zpool}/${config.name}")) ++
(lib.optional (config.zfs_type == "filesystem" && config.options.mountpoint or "" != "none") {
lib.optional (config.options.mountpoint or "" != "none") {
fileSystems.${config.mountpoint} = {
device = "${zpool}/${config.name}";
fsType = "zfs";
options = config.mountOptions ++ lib.optional ((config.options.mountpoint or "") != "legacy") "zfsutil";
};
});
};
description = "NixOS configuration";
};
_pkgs = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo (lib.types.listOf lib.types.package);
default = pkgs: [ pkgs.util-linux ] ++ lib.optionals (config.content != null) (config.content._pkgs pkgs);
default = pkgs: [ pkgs.util-linux ];
description = "Packages";
};
};
}

73
types/zfs_volume.nix Normal file
View File

@ -0,0 +1,73 @@
{ config, options, lib, diskoLib, optionTypes, rootMountPoint, ... }:
{
options = {
name = lib.mkOption {
type = lib.types.str;
default = config._module.args.name;
description = "Name of the dataset";
};
type = lib.mkOption {
type = lib.types.enum [ "zfs_volume" ];
default = "zfs_volume";
internal = true;
description = "Type";
};
options = lib.mkOption {
type = lib.types.attrsOf lib.types.str;
default = { };
description = "Options to set for the dataset";
};
mountOptions = lib.mkOption {
type = lib.types.listOf lib.types.str;
default = [ "defaults" ];
description = "Mount options";
};
# volume options
size = lib.mkOption {
type = lib.types.nullOr lib.types.str; # TODO size
default = null;
description = "Size of the dataset";
};
content = diskoLib.partitionType;
_meta = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo diskoLib.jsonType;
default = dev:
lib.optionalAttrs (config.content != null) (config.content._meta dev);
description = "Metadata";
};
_create = diskoLib.mkCreateOption {
inherit config options;
default = { zpool }: ''
zfs create ${zpool}/${config.name} \
${lib.concatStringsSep " " (lib.mapAttrsToList (n: v: "-o ${n}=${v}") config.options)} -V ${config.size}
udevadm trigger --subsystem-match=block; udevadm settle
${lib.optionalString (config.content != null) (config.content._create {dev = "/dev/zvol/${zpool}/${config.name}";})}
'';
};
_mount = diskoLib.mkMountOption {
inherit config options;
default = { zpool }:
lib.optionalAttrs (config.content != null) (config.content._mount { dev = "/dev/zvol/${zpool}/${config.name}"; });
};
_config = lib.mkOption {
internal = true;
readOnly = true;
default = zpool:
lib.optional (config.content != null) (config.content._config "/dev/zvol/${zpool}/${config.name}");
description = "NixOS configuration";
};
_pkgs = lib.mkOption {
internal = true;
readOnly = true;
type = lib.types.functionTo (lib.types.listOf lib.types.package);
default = pkgs: [ pkgs.util-linux ] ++ lib.optionals (config.content != null) (config.content._pkgs pkgs);
description = "Packages";
};
};
}

View File

@ -38,7 +38,8 @@
description = "Options to pass to mount";
};
datasets = lib.mkOption {
type = lib.types.attrsOf subTypes.zfs_dataset;
type = lib.types.attrsOf (diskoLib.subType { inherit (subTypes) zfs_fs zfs_volume; });
# type = lib.types.attrsOf subTypes.zfs_fs;
description = "List of datasets to define";
};
_meta = lib.mkOption {
@ -72,7 +73,7 @@
zpool list '${config.name}' >/dev/null 2>/dev/null || zpool import '${config.name}'
${lib.concatMapStrings (x: x.dev or "") (lib.attrValues datasetMounts)}
'';
fs = datasetMounts.fs // lib.optionalAttrs (config.mountpoint != null) {
fs = (datasetMounts.fs or {}) // lib.optionalAttrs (config.mountpoint != null) {
${config.mountpoint} = ''
if ! findmnt ${config.name} "${rootMountPoint}${config.mountpoint}" > /dev/null 2>&1; then
mount ${config.name} "${rootMountPoint}${config.mountpoint}" \