nix-community/disko
1
1
Fork 0
mirror of https://github.com/nix-community/disko.git synced 2024-09-11 06:25:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

disko-images: replace nix-copy with cp

Browse Source 
This hopefully fixes the large memory consumption we have seen in the
past. Also presumably coreutils cp is more tuned for performance than
whatever nix does.
This commit is contained in:
Jörg Thalheim 2024-05-06 20:20:01 +02:00
parent 4f8c8580b4
commit 8a4585a200
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/make-disk-image.nix
View File

@ -39,7 +39,9 @@ let
${extraPostVM}
'';
closureInfo = pkgs.callPackage ./closure-info.nix { };
closureInfo = (pkgs.callPackage ./closure-info.nix { }) {
rootPaths = [ systemToInstall.config.system.build.toplevel ];
};
partitioner = ''
# running udev, stolen from stage-1.sh
echo "running udev..."
@ -55,16 +57,23 @@ let
udevadm trigger --action=add
udevadm settle
# populate nix db, so nixos-install doesn't complain
export NIX_STATE_DIR=$TMPDIR/state
${pkgs.fakeroot}/bin/fakeroot nix-store --register-validity --reregister < ${closureInfo {
rootPaths = [ systemToInstall.config.system.build.toplevel ];
}}/registration
${systemToInstall.config.system.build.diskoScript}
'';
installer = ''
${systemToInstall.config.system.build.nixos-install}/bin/nixos-install --system ${systemToInstall.config.system.build.toplevel} --keep-going --no-channel-copy -v --no-root-password --option binary-caches ""
# populate nix db, so nixos-install doesn't complain
export NIX_STATE_DIR=${systemToInstall.config.disko.rootMountPoint}/nix/var/nix
# We have to use fakeroot here, because nix tries to chown files in the original store.
# fakeroot will make override all chown calls to no-ops.
echo "Registering store paths..."
${pkgs.fakeroot}/bin/fakeroot nix-store --register-validity --reregister < ${closureInfo}/registration
# We copy files with cp because `nix copy` seems to have a large memory leak
echo "Copying store paths..."
mkdir -p ${systemToInstall.config.disko.rootMountPoint}/nix/store
xargs cp -r --target-directory=${systemToInstall.config.disko.rootMountPoint}/nix/store < ${closureInfo}/store-paths
${systemToInstall.config.system.build.nixos-install}/bin/nixos-install --root ${systemToInstall.config.disko.rootMountPoint} --system ${systemToInstall.config.system.build.toplevel} --keep-going --no-channel-copy -v --no-root-password --option binary-caches ""
umount -Rv ${systemToInstall.config.disko.rootMountPoint}
'';
QEMU_OPTS = lib.concatMapStringsSep " " (disk: "-drive file=${disk.name}.raw,if=virtio,cache=unsafe,werror=report,format=raw") (lib.attrValues nixosConfig.config.disko.devices.disk);