From bc896554225d5fc2ad523c342374422bb3f21640 Mon Sep 17 00:00:00 2001 From: Antoine Stevan <44101798+amtoine@users.noreply.github.com> Date: Sat, 14 Oct 2023 16:19:04 +0200 Subject: [PATCH] make_release: do not annotate boolean switches in public API (#635) related to - https://github.com/nushell/nushell/pull/10456 - https://github.com/nushell/nushell.github.io/pull/1071 ## description after the changes on boolean switches from https://github.com/nushell/nushell/pull/10456, we need to not annotate then with `: bool` when part of a public API. this PR is required for https://github.com/nushell/nushell.github.io/pull/1071 to move forward. --- make_release/bump-version.nu | 2 +- make_release/nu_release.nu | 2 +- make_release/release-note/list-merged-prs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/make_release/bump-version.nu b/make_release/bump-version.nu index 901e16b6..2cf545de 100755 --- a/make_release/bump-version.nu +++ b/make_release/bump-version.nu @@ -3,7 +3,7 @@ use std log # bump the minor or patch version of the Nushell project def main [ - --patch: bool # update the minor version instead of the minor + --patch # update the minor version instead of the minor ]: nothing -> nothing { let version = open Cargo.toml | get package.version diff --git a/make_release/nu_release.nu b/make_release/nu_release.nu index e5f8713f..550d3481 100644 --- a/make_release/nu_release.nu +++ b/make_release/nu_release.nu @@ -2,7 +2,7 @@ use std log def publish [ crate: path # the path to the crate to publish. - --no-verify: bool # don’t verify the contents by building them. Can be useful for crates with a `build.rs`. + --no-verify # don’t verify the contents by building them. Can be useful for crates with a `build.rs`. ] { cd $crate diff --git a/make_release/release-note/list-merged-prs b/make_release/release-note/list-merged-prs index 7c885847..9ef2bbd1 100755 --- a/make_release/release-note/list-merged-prs +++ b/make_release/release-note/list-merged-prs @@ -13,8 +13,8 @@ def main [ repo: string # the name of the repo, e.g. `nushell/nushell` date?: datetime # the date of the last release (default to 4 weeks ago, excluded) --label: string # the label to filter the PRs by, e.g. `good-first-issue` - --pretty: bool # pretty-print for the MarkDown release not - --no-author: bool # do not group the contributions by author + --pretty # pretty-print for the MarkDown release not + --no-author # do not group the contributions by author ] { let date = $date | default ((date now) - 4wk) | format date "%Y-%m-%d"