mirror of
https://github.com/nushell/nu_scripts.git
synced 2024-09-11 13:45:56 +03:00
hotfix for significant-digits
to not error if the input was 0 (#863)
In the last `pr` there was an error, that I just discovered and fixed.
Also I added test for this case in future, and some test for negative
numbers
```
0 | signfificant digits 2
33 │
34 │ let insignif_position = $n - 1 - ($num | math abs | math log 10 | math floor)
· ──┬─ ────┬───
· │ ╰── 'math log' undefined for values outside the open interval (0, Inf).
· ╰── value originates from here
35 │
╰────
```
I'm sorry for hassle here 😞
This commit is contained in:
parent
ae5c1a2727
commit
f41d050d32
@ -31,7 +31,16 @@ export def 'significant-digits' [
|
|||||||
_ => {$input}
|
_ => {$input}
|
||||||
}
|
}
|
||||||
|
|
||||||
let insignif_position = $n - 1 - ($num | math abs | math log 10 | math floor)
|
let insignif_position = $num
|
||||||
|
| if $in == 0 {
|
||||||
|
0 # it's impoosbile to calculate `math log` from 0, thus 0 errors here
|
||||||
|
} else {
|
||||||
|
math abs
|
||||||
|
| math log 10
|
||||||
|
| math floor
|
||||||
|
| $n - 1 - $in
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
# See the note below the code for an explanation of the construct used.
|
# See the note below the code for an explanation of the construct used.
|
||||||
let scaling_factor = 10 ** ($insignif_position | math abs)
|
let scaling_factor = 10 ** ($insignif_position | math abs)
|
||||||
|
@ -19,3 +19,11 @@ export def "test significant-digits-duration" [] {
|
|||||||
export def "test significant-digits-ints" [] {
|
export def "test significant-digits-ints" [] {
|
||||||
assert equal (123456 | math significant-digits 2) 120000
|
assert equal (123456 | math significant-digits 2) 120000
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export def "test significant-digits-0" [] {
|
||||||
|
assert equal (0 | math significant-digits 2) 0
|
||||||
|
}
|
||||||
|
|
||||||
|
export def "test significant-digits-negative" [] {
|
||||||
|
assert equal (-1.23456789 | math significant-digits 5) (-1.2346)
|
||||||
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user