on master help sign in
Update for new dependent-sum/map + universe
commit816df4d8fb9004c911af7607a9d678edfd30ec94 authorAli Abrar <aliabrar@gmail.com> dateFri 14 Jun 2019, 17:53 (7 years ago) parent1cf6888
5 files changed+43−39
default.nix+11−8 dep/reflex-platform/github.json+2−2 lib/route/obelisk-route.cabal+3−2 lib/route/src/Obelisk/Route.hs+23−22 lib/route/src/Obelisk/Route/TH.hs+4−5
default.nix+11−8
@@ -32,6 +32,7 @@ let
3232 # Fix misc upstream packages
3333 (self: super: let
3434 pkgs = self.callPackage ({ pkgs }: pkgs) {};
35+ universeRepo = hackGet ./dep/universe;
3536 in {
3637 hnix = pkgs.haskell.lib.dontCheck (self.callCabal2nix "hnix" (pkgs.fetchFromGitHub {
3738 owner = "haskell-nix";
@@ -39,14 +40,16 @@ let
3940 rev = "42afdc21da5d9e076eab57eaa42bfdde938192b8";
4041 sha256 = "0psw384dx9bw2dp93xrzw8rd9amvcwgzn64jzzwby7sfspj6k349";
4142 }) {});
42− # Need 8.0.2 build support
43− # PR: https://github.com/dmwit/universe/pull/33
44− universe-template = self.callCabal2nix "universe-template" (pkgs.fetchFromGitHub {
45− owner = "obsidiansystems";
46− repo = "universe";
47− rev = "6a71119bfa5db2b9990a2491c941469ff8ef5d13";
48− sha256 = "0z8smyainnlzcglv3dlx6x1n9j6d2jv48aa8f2421iayfkxg3js5";
49− } + /template) {};
43+ universe = self.callCabal2nixWithOptions "universe" universeRepo "--subpath universe" {};
44+ universe-base = self.callCabal2nixWithOptions "universe" universeRepo "--subpath universe-base" {};
45+ universe-dependent-sum = pkgs.haskell.lib.doJailbreak (self.callCabal2nixWithOptions "universe" universeRepo "--subpath universe-dependent-sum" {});
46+ universe-instances-extended = self.callCabal2nixWithOptions "universe" universeRepo "--subpath universe-instances-extended" {};
47+ universe-reverse-instances = self.callCabal2nixWithOptions "universe" universeRepo "--subpath universe-reverse-instances" {};
48+ universe-instances-base = self.callCabal2nixWithOptions "universe" universeRepo "--subpath deprecated/universe-instances-base" {};
49+ constraints-extras = self.callCabal2nix "constraints-extras" (hackGet ./dep/constraints-extras) {};
50+ dependent-map = self.callCabal2nix "dependent-map" (hackGet ./dep/dependent-map) {};
51+ dependent-sum = self.callCabal2nixWithOptions "dependent-sum" (hackGet ./dep/dependent-sum) "--subpath dependent-sum" {};
52+ dependent-sum-template = self.callCabal2nixWithOptions "dependent-sum-template" (hackGet ./dep/dependent-sum) "--subpath dependent-sum-template" {};
5053 })
5154
5255 pkgs.obeliskExecutableConfig.haskellOverlay
dep/reflex-platform/github.json+2−2
@@ -2,6 +2,6 @@
22 "owner": "reflex-frp",
33 "repo": "reflex-platform",
44 "branch": "cg-bump-reflex-dom",
5− "rev": "35ce47d2d9a5de970a54cbe5e78d7431f688a995",
6− "sha256": "0pvz9853bhf4yy6d94r4jv0nxcj8ma07k9ysgn8zfl26ssmc4fh1"
5+ "rev": "bb1de76a4ec855b6d8147acc4abc47a470ccd84a",
6+ "sha256": "1insdz8m5a5dswflpcxn7hch1wvbxm58fzrbl41ifj66zqg7c34c"
77}
lib/route/obelisk-route.cabal+3−2
@@ -8,10 +8,10 @@ library
88 build-depends: base,
99 categories,
1010 constraints,
11+ constraints-extras,
1112 containers,
1213 dependent-map,
1314 dependent-sum,
14− dependent-sum-universe-orphans,
1515 dependent-sum-template,
1616 either,
1717 ghcjs-dom,
@@ -28,9 +28,10 @@ library
2828 reflex-dom-core,
2929 template-haskell,
3030 text,
31+ th-extras,
3132 transformers,
3233 universe,
33− universe-template
34+ universe-dependent-sum
3435 exposed-modules: Obelisk.Route
3536 Obelisk.Route.TH
3637 Obelisk.Route.Frontend
lib/route/src/Obelisk/Route.hs+23−22
@@ -113,13 +113,12 @@ import Data.Maybe
113113import Data.Monoid ((<>))
114114import Data.Set (Set)
115115import qualified Data.Set as Set
116−import Data.Some (Some)
117−import qualified Data.Some as Some
118−import Data.Some.Universe.Orphans ()
116+import Data.Some (Some(Some))
119117import Data.Text (Text)
120118import qualified Data.Text as T
121−import Data.Text.Encoding
119+import qualified Data.Text.Encoding as T
122120import Data.Universe
121+import Data.Universe.Some
123122import Network.HTTP.Types.URI
124123import qualified Numeric.Lens
125124import Obelisk.Route.TH
@@ -155,7 +154,7 @@ pattern (:/) :: f a -> a -> R f
155154pattern a :/ b = a :=> Identity b
156155
157156mapSome :: (forall a. f a -> g a) -> Some f -> Some g
158−mapSome f (Some.This a) = Some.This $ f a
157+mapSome f (Some a) = Some $ f a
159158
160159hoistR :: (forall x. f x -> g x) -> R f -> R g
161160hoistR f (x :=> Identity y) = f x :/ y
@@ -349,8 +348,8 @@ nothingEncoder = prismEncoder _Nothing
349348
350349someConstEncoder :: (Applicative check, Applicative parse) => Encoder check parse (Some (Const a)) a
351350someConstEncoder = unsafeMkEncoder $ EncoderImpl
352− { _encoderImpl_encode = \(Some.This (Const a)) -> a
353− , _encoderImpl_decode = pure . Some.This . Const
351+ { _encoderImpl_encode = \(Some (Const a)) -> a
352+ , _encoderImpl_decode = pure . Some . Const
354353 }
355354
356355-- | WARNING: This is only safe if the Show and Read instances for 'a' are
@@ -378,7 +377,7 @@ checkEnum1EncoderFunc
378377 -> check (EncoderFunc check' parse p r)
379378checkEnum1EncoderFunc f = do
380379 (encoderImpls :: DMap p (Flip (EncoderImpl parse) r)) <- DMap.fromList <$>
381− traverse (\(Some.This p) -> (p :=>) . Flip <$> unEncoder (f p)) universe
380+ traverse (\(Some p) -> (p :=>) . Flip <$> unEncoder (f p)) universe
382381 pure $ EncoderFunc $ \p -> unsafeMkEncoder . unFlip $
383382 DMap.findWithDefault (error "checkEnum1EncoderFunc: EncoderImpl not found (should be impossible)") p encoderImpls
384383
@@ -433,11 +432,11 @@ chainEncoder cons this rest = Encoder $ do
433432 pure $ EncoderImpl
434433 { _encoderImpl_decode = \v -> do
435434 (here, following) <- _encoderImpl_decode consValid v
436− Some.This r <- _encoderImpl_decode thisValid here
435+ Some r <- _encoderImpl_decode thisValid here
437436 (r :/) <$> _encoderImpl_decode (runIdentity . unEncoder $ rest r) following
438437 , _encoderImpl_encode = \(r :/ s) ->
439438 _encoderImpl_encode consValid
440− ( _encoderImpl_encode thisValid $ Some.This r
439+ ( _encoderImpl_encode thisValid $ Some r
441440 , _encoderImpl_encode (runIdentity . unEncoder $ rest r) s)
442441 }
443442
@@ -504,7 +503,7 @@ enum1Encoder
504503 , Show r
505504 )
506505 => (forall a. p a -> r) -> Encoder check parse (Some p) r
507−enum1Encoder f = enumEncoder $ \(Some.This p) -> f p
506+enum1Encoder f = enumEncoder $ \(Some p) -> f p
508507
509508-- | Encode an enumerable, bounded type. WARNING: Don't use this on types that
510509-- have a large number of values - it will use a lot of memory.
@@ -596,10 +595,10 @@ queryParametersTextEncoder = Encoder $ pure $ EncoderImpl
596595 in (urlDecodeText True k, urlDecodeText True <$> mv)
597596
598597urlEncodeText :: Bool -> Text -> Text
599−urlEncodeText q = decodeUtf8 . urlEncode q . encodeUtf8
598+urlEncodeText q = T.decodeUtf8 . urlEncode q . T.encodeUtf8
600599
601600urlDecodeText :: Bool -> Text -> Text
602−urlDecodeText q = decodeUtf8 . urlDecode q . encodeUtf8
601+urlDecodeText q = T.decodeUtf8 . urlDecode q . T.encodeUtf8
603602
604603listToNonEmptyEncoder :: (Applicative check, Applicative parse, Monoid a, Eq a) => Encoder check parse [a] (NonEmpty a)
605604listToNonEmptyEncoder = Encoder $ pure $ EncoderImpl
@@ -711,9 +710,11 @@ data ObeliskRoute :: (* -> *) -> * -> * where
711710 ObeliskRoute_App :: f a -> ObeliskRoute f a
712711 ObeliskRoute_Resource :: ResourceRoute a -> ObeliskRoute f a
713712
714−instance Universe (Some f) => Universe (Some (ObeliskRoute f)) where
715− universe = fmap (\(Some.This x) -> Some.This (ObeliskRoute_App x)) universe
716− ++ fmap (\(Some.This x) -> Some.This (ObeliskRoute_Resource x)) universe
713+instance UniverseSome f => UniverseSome (ObeliskRoute f) where
714+ universeSome = concat
715+ [ (\(Some x) -> Some (ObeliskRoute_App x)) <$> universe
716+ , (\(Some x) -> Some (ObeliskRoute_Resource x)) <$> universe
717+ ]
717718
718719instance GEq f => GEq (ObeliskRoute f) where
719720 geq (ObeliskRoute_App x) (ObeliskRoute_App y) = geq x y
@@ -801,12 +802,12 @@ indexOnlyRouteEncoder = pathComponentEncoder indexOnlyRouteSegment
801802
802803someSumEncoder :: (Applicative check, Applicative parse) => Encoder check parse (Some (Sum a b)) (Either (Some a) (Some b))
803804someSumEncoder = Encoder $ pure $ EncoderImpl
804− { _encoderImpl_encode = \(Some.This t) -> case t of
805− InL l -> Left $ Some.This l
806− InR r -> Right $ Some.This r
805+ { _encoderImpl_encode = \(Some t) -> case t of
806+ InL l -> Left $ Some l
807+ InR r -> Right $ Some r
807808 , _encoderImpl_decode = pure . \case
808− Left (Some.This l) -> Some.This (InL l)
809− Right (Some.This r) -> Some.This (InR r)
809+ Left (Some l) -> Some (InL l)
810+ Right (Some r) -> Some (InR r)
810811 }
811812
812813data Void1 :: * -> * where {}
@@ -817,7 +818,7 @@ instance Universe (Some Void1) where
817818void1Encoder :: (Applicative check, MonadError Text parse) => Encoder check parse (Some Void1) a
818819void1Encoder = Encoder $ pure $ EncoderImpl
819820 { _encoderImpl_encode = \case
820− Some.This f -> case f of {}
821+ Some f -> case f of {}
821822 , _encoderImpl_decode = \_ -> throwError "void1Encoder: can't decode anything"
822823 }
823824
lib/route/src/Obelisk/Route/TH.hs+4−5
@@ -1,8 +1,9 @@
11module Obelisk.Route.TH (deriveRouteComponent) where
22
3+import Data.Constraint.Extras.TH
34import Data.GADT.Show.TH
45import Data.GADT.Compare.TH
5−import Data.Universe.TH
6+import Data.Universe.Some.TH
67import Language.Haskell.TH
78
89-- | Derive all the typeclasses needed for a RouteComponent type. The argument should be the name of a type of kind @k -> *@
@@ -11,8 +12,6 @@ deriveRouteComponent x = concat <$> traverse ($ x)
1112 [ deriveGShow
1213 , deriveGEq
1314 , deriveGCompare
14− , deriveShowTagIdentity
15− , deriveEqTagIdentity
16− , deriveOrdTagIdentity
17− , deriveSomeUniverse
15+ , deriveUniverseSome
16+ , deriveArgDict
1817 ]